Migrate controltower service to aws-sdk-go-v2

[bschaatsbergen]

Description

Some tech debt I'm addressing to support our migration to aws-sdk-go-v2 and this unblocks the implementation of a new resource in #34557

Relations

Closes #34558.
Relates #32976.

References

Output from Acceptance Testing

% make testacc TESTS= TestAccControlTower PKG=controltower

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[aristosvo]

Hi @bschaatsbergen! I went already ahead (based on your work) with implementation of the landing_zone, as I was in dire need, see this branch. Feel free to copy or to stick to your own code, just wanted to let you know.

Do you already have any idea with regard to testing? I've done work on Azure, but especially with these kind of resources I'm lost on the testing part.

[bschaatsbergen]

Hi @bschaatsbergen! I went already ahead (based on your work) with implementation of the landing_zone, as I was in dire need, see (this branch)[https://github.com/hashicorp/terraform-provider-aws/compare/main...aristosvo:terraform-provider-aws:controltower/landingzone?expand=1]. Feel free to copy or to stick to your own code, just wanted to let you know.

Do you already have any idea with regard to testing? I've done work on Azure, but especially with these kind of resources I'm lost on the testing part.

Hey @aristosvo - thanks for sharing this. Lets get this PR through in order to migrate the service to the aws-sdk-go-v2 pkg and then create a follow-up PR to implement the aws_controltower_landing_zone resource using your code 👍🏼 ! Thanks for your work.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccControlTowerControlsDataSource_\|TestAccControlTowerControl_serial' PKG=controltower
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/controltower/... -v -count 1 -parallel 20  -run=TestAccControlTowerControlsDataSource_\|TestAccControlTowerControl_serial -timeout 360m
=== RUN   TestAccControlTowerControl_serial
=== PAUSE TestAccControlTowerControl_serial
=== RUN   TestAccControlTowerControlsDataSource_basic
=== PAUSE TestAccControlTowerControlsDataSource_basic
=== CONT  TestAccControlTowerControl_serial
=== RUN   TestAccControlTowerControl_serial/Control
=== RUN   TestAccControlTowerControl_serial/Control/disappears
=== CONT  TestAccControlTowerControlsDataSource_basic
--- PASS: TestAccControlTowerControlsDataSource_basic (23.06s)
=== RUN   TestAccControlTowerControl_serial/Control/basic
--- PASS: TestAccControlTowerControl_serial (446.58s)
    --- PASS: TestAccControlTowerControl_serial/Control (446.58s)
        --- PASS: TestAccControlTowerControl_serial/Control/disappears (221.97s)
        --- PASS: TestAccControlTowerControl_serial/Control/basic (224.61s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/controltower	451.750s

[ewbankkit]

@bschaatsbergen Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.28.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.