-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate securityhub
service to aws-sdk-go-v2
#34693
Migrate securityhub
service to aws-sdk-go-v2
#34693
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
Great work @DanielRieske! |
…1.5.1'." This reverts commit e3b9e0b.
…n' during Create.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSecurityHub_serial' PKG=securityhub
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/securityhub/... -v -count 1 -parallel 20 -run=TestAccSecurityHub_serial -timeout 360m
=== RUN TestAccSecurityHub_serial
=== PAUSE TestAccSecurityHub_serial
=== CONT TestAccSecurityHub_serial
=== RUN TestAccSecurityHub_serial/ActionTarget
=== RUN TestAccSecurityHub_serial/ActionTarget/basic
=== RUN TestAccSecurityHub_serial/ActionTarget/disappears
=== RUN TestAccSecurityHub_serial/ActionTarget/Description
=== RUN TestAccSecurityHub_serial/ActionTarget/Name
=== RUN TestAccSecurityHub_serial/Insight
=== RUN TestAccSecurityHub_serial/Insight/KeywordFilters
=== RUN TestAccSecurityHub_serial/Insight/MultipleFilters
=== RUN TestAccSecurityHub_serial/Insight/Name
=== RUN TestAccSecurityHub_serial/Insight/NumberFilters
=== RUN TestAccSecurityHub_serial/Insight/DateFilters
=== RUN TestAccSecurityHub_serial/Insight/disappears
=== RUN TestAccSecurityHub_serial/Insight/GroupByAttribute
=== RUN TestAccSecurityHub_serial/Insight/IpFilters
=== RUN TestAccSecurityHub_serial/Insight/MapFilters
=== RUN TestAccSecurityHub_serial/Insight/WorkflowStatus
=== RUN TestAccSecurityHub_serial/Insight/basic
=== RUN TestAccSecurityHub_serial/InviteAccepter
=== RUN TestAccSecurityHub_serial/InviteAccepter/basic
=== RUN TestAccSecurityHub_serial/OrganizationConfiguration
=== RUN TestAccSecurityHub_serial/OrganizationConfiguration/basic
=== RUN TestAccSecurityHub_serial/OrganizationConfiguration/AutoEnableStandards
=== RUN TestAccSecurityHub_serial/ProductSubscription
=== RUN TestAccSecurityHub_serial/ProductSubscription/basic
=== RUN TestAccSecurityHub_serial/Account
=== RUN TestAccSecurityHub_serial/Account/MigrateV0
=== RUN TestAccSecurityHub_serial/Account/Full
=== RUN TestAccSecurityHub_serial/Account/RemoveControlFindingGeneratorDefaultValue
=== RUN TestAccSecurityHub_serial/Account/basic
=== RUN TestAccSecurityHub_serial/Account/disappears
=== RUN TestAccSecurityHub_serial/Account/EnableDefaultStandardsFalse
=== RUN TestAccSecurityHub_serial/Member
=== RUN TestAccSecurityHub_serial/Member/basic
=== RUN TestAccSecurityHub_serial/Member/invite
=== RUN TestAccSecurityHub_serial/OrganizationAdminAccount
=== RUN TestAccSecurityHub_serial/OrganizationAdminAccount/basic
acctest.go:981: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN TestAccSecurityHub_serial/OrganizationAdminAccount/disappears
acctest.go:981: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN TestAccSecurityHub_serial/OrganizationAdminAccount/MultiRegion
acctest.go:981: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN TestAccSecurityHub_serial/StandardsControl
=== RUN TestAccSecurityHub_serial/StandardsControl/basic
=== RUN TestAccSecurityHub_serial/StandardsControl/DisabledControlStatus
=== RUN TestAccSecurityHub_serial/StandardsControl/EnabledControlStatusAndDisabledReason
=== RUN TestAccSecurityHub_serial/StandardsSubscription
=== RUN TestAccSecurityHub_serial/StandardsSubscription/basic
=== RUN TestAccSecurityHub_serial/StandardsSubscription/disappears
=== RUN TestAccSecurityHub_serial/FindingAggregator
=== RUN TestAccSecurityHub_serial/FindingAggregator/disappears
=== RUN TestAccSecurityHub_serial/FindingAggregator/basic
--- PASS: TestAccSecurityHub_serial (818.82s)
--- PASS: TestAccSecurityHub_serial/ActionTarget (94.72s)
--- PASS: TestAccSecurityHub_serial/ActionTarget/basic (18.79s)
--- PASS: TestAccSecurityHub_serial/ActionTarget/disappears (15.60s)
--- PASS: TestAccSecurityHub_serial/ActionTarget/Description (29.30s)
--- PASS: TestAccSecurityHub_serial/ActionTarget/Name (31.02s)
--- PASS: TestAccSecurityHub_serial/Insight (289.25s)
--- PASS: TestAccSecurityHub_serial/Insight/KeywordFilters (19.57s)
--- PASS: TestAccSecurityHub_serial/Insight/MultipleFilters (30.68s)
--- PASS: TestAccSecurityHub_serial/Insight/Name (31.78s)
--- PASS: TestAccSecurityHub_serial/Insight/NumberFilters (47.84s)
--- PASS: TestAccSecurityHub_serial/Insight/DateFilters (37.17s)
--- PASS: TestAccSecurityHub_serial/Insight/disappears (16.88s)
--- PASS: TestAccSecurityHub_serial/Insight/GroupByAttribute (29.74s)
--- PASS: TestAccSecurityHub_serial/Insight/IpFilters (18.89s)
--- PASS: TestAccSecurityHub_serial/Insight/MapFilters (18.66s)
--- PASS: TestAccSecurityHub_serial/Insight/WorkflowStatus (19.20s)
--- PASS: TestAccSecurityHub_serial/Insight/basic (18.82s)
--- PASS: TestAccSecurityHub_serial/InviteAccepter (31.69s)
--- PASS: TestAccSecurityHub_serial/InviteAccepter/basic (31.69s)
--- PASS: TestAccSecurityHub_serial/OrganizationConfiguration (71.37s)
--- PASS: TestAccSecurityHub_serial/OrganizationConfiguration/basic (36.53s)
--- PASS: TestAccSecurityHub_serial/OrganizationConfiguration/AutoEnableStandards (34.85s)
--- PASS: TestAccSecurityHub_serial/ProductSubscription (39.77s)
--- PASS: TestAccSecurityHub_serial/ProductSubscription/basic (39.77s)
--- PASS: TestAccSecurityHub_serial/Account (62.19s)
--- PASS: TestAccSecurityHub_serial/Account/MigrateV0 (3.54s)
--- PASS: TestAccSecurityHub_serial/Account/Full (9.44s)
--- PASS: TestAccSecurityHub_serial/Account/RemoveControlFindingGeneratorDefaultValue (1.00s)
--- PASS: TestAccSecurityHub_serial/Account/basic (17.94s)
--- PASS: TestAccSecurityHub_serial/Account/disappears (15.64s)
--- PASS: TestAccSecurityHub_serial/Account/EnableDefaultStandardsFalse (14.64s)
--- PASS: TestAccSecurityHub_serial/Member (39.01s)
--- PASS: TestAccSecurityHub_serial/Member/basic (18.93s)
--- PASS: TestAccSecurityHub_serial/Member/invite (20.08s)
--- PASS: TestAccSecurityHub_serial/OrganizationAdminAccount (2.82s)
--- SKIP: TestAccSecurityHub_serial/OrganizationAdminAccount/basic (0.19s)
--- SKIP: TestAccSecurityHub_serial/OrganizationAdminAccount/disappears (0.07s)
--- SKIP: TestAccSecurityHub_serial/OrganizationAdminAccount/MultiRegion (2.55s)
--- PASS: TestAccSecurityHub_serial/StandardsControl (107.33s)
--- PASS: TestAccSecurityHub_serial/StandardsControl/basic (10.34s)
--- PASS: TestAccSecurityHub_serial/StandardsControl/DisabledControlStatus (8.85s)
--- PASS: TestAccSecurityHub_serial/StandardsControl/EnabledControlStatusAndDisabledReason (88.14s)
--- PASS: TestAccSecurityHub_serial/StandardsSubscription (17.70s)
--- PASS: TestAccSecurityHub_serial/StandardsSubscription/basic (8.74s)
--- PASS: TestAccSecurityHub_serial/StandardsSubscription/disappears (8.95s)
--- PASS: TestAccSecurityHub_serial/FindingAggregator (62.98s)
--- PASS: TestAccSecurityHub_serial/FindingAggregator/disappears (18.04s)
--- PASS: TestAccSecurityHub_serial/FindingAggregator/basic (44.94s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/securityhub 823.868s
% make testacc TESTARGS='-run=TestAccSecurityHub_serial/OrganizationAdminAccount' PKG=securityhub
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/securityhub/... -v -count 1 -parallel 20 -run=TestAccSecurityHub_serial/OrganizationAdminAccount -timeout 360m
=== RUN TestAccSecurityHub_serial
=== PAUSE TestAccSecurityHub_serial
=== CONT TestAccSecurityHub_serial
=== RUN TestAccSecurityHub_serial/OrganizationAdminAccount
=== RUN TestAccSecurityHub_serial/OrganizationAdminAccount/basic
=== RUN TestAccSecurityHub_serial/OrganizationAdminAccount/disappears
=== RUN TestAccSecurityHub_serial/OrganizationAdminAccount/MultiRegion
--- PASS: TestAccSecurityHub_serial (81.42s)
--- PASS: TestAccSecurityHub_serial/OrganizationAdminAccount (81.42s)
--- PASS: TestAccSecurityHub_serial/OrganizationAdminAccount/basic (23.65s)
--- PASS: TestAccSecurityHub_serial/OrganizationAdminAccount/disappears (20.85s)
--- PASS: TestAccSecurityHub_serial/OrganizationAdminAccount/MultiRegion (36.92s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/securityhub 86.811s
This functionality has been released in v5.30.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Migrating the
securityhub
service toaws-sdk-go-v2
to allow the creation of theaws_securityhub_automation_rule
resource in #32210.Note to the reviewer that this service had a few test scenarios that requires multiple accounts and an account that isn't in an organization. I did not have access to these accounts so I wasn't able to test it.
Relations
Relates #32976
Closes #34692
References
Output from Acceptance Testing