Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add region argument to target_table in aws_glue_catalog_table #34817

Merged
6 changes: 6 additions & 0 deletions .changelog/34817.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
```release-note:enhancement
resource/aws_glue_catalog_table: Add `region` attribute to `target_table` block.
```
```release-note:enhancement
data-source//aws_glue_catalog_table: Add `region` attribute to `target_table` block.
```

Unchanged files with check annotations Beta

},
},
},
}

Check failure on line 388 in internal/service/glue/catalog_table.go

GitHub Actions / go build

syntax error: unexpected newline in composite literal; possibly missing comma or }

Check failure on line 388 in internal/service/glue/catalog_table.go

GitHub Actions / providerlint

syntax error: unexpected newline in composite literal; possibly missing comma or }

Check failure on line 388 in internal/service/glue/catalog_table.go

GitHub Actions / providerlint

missing ',' before newline in composite literal

Check failure on line 388 in internal/service/glue/catalog_table.go

GitHub Actions / 1 of 2

syntax error: unexpected newline in composite literal; possibly missing comma or }

Check failure on line 388 in internal/service/glue/catalog_table.go

GitHub Actions / 1 of 2

missing ',' before newline in composite literal (typecheck)

Check failure on line 388 in internal/service/glue/catalog_table.go

GitHub Actions / build-32-bit

syntax error: unexpected newline in composite literal; possibly missing comma or }
}
func ReadTableID(id string) (string, string, string, error) {

Check failure on line 391 in internal/service/glue/catalog_table.go

GitHub Actions / go build

syntax error: unexpected ReadTableID, expected (

Check failure on line 391 in internal/service/glue/catalog_table.go

GitHub Actions / providerlint

syntax error: unexpected ReadTableID, expected (

Check failure on line 391 in internal/service/glue/catalog_table.go

GitHub Actions / providerlint

expected '(', found ReadTableID

Check failure on line 391 in internal/service/glue/catalog_table.go

GitHub Actions / providerlint

expected ')', found string

Check failure on line 391 in internal/service/glue/catalog_table.go

GitHub Actions / 1 of 2

syntax error: unexpected ReadTableID, expected (

Check failure on line 391 in internal/service/glue/catalog_table.go

GitHub Actions / 1 of 2

expected '(', found ReadTableID (typecheck)

Check failure on line 391 in internal/service/glue/catalog_table.go

GitHub Actions / build-32-bit

syntax error: unexpected ReadTableID, expected (
idParts := strings.Split(id, ":")
if len(idParts) != 3 {
return "", "", "", fmt.Errorf("expected ID in format catalog-id:database-name:table-name, received: %s", id)
return idParts[0], idParts[1], idParts[2], nil
}
func resourceCatalogTableCreate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {

Check failure on line 399 in internal/service/glue/catalog_table.go

GitHub Actions / go build

syntax error: unexpected resourceCatalogTableCreate, expected (

Check failure on line 399 in internal/service/glue/catalog_table.go

GitHub Actions / providerlint

syntax error: unexpected resourceCatalogTableCreate, expected (

Check failure on line 399 in internal/service/glue/catalog_table.go

GitHub Actions / providerlint

expected '(', found resourceCatalogTableCreate

Check failure on line 399 in internal/service/glue/catalog_table.go

GitHub Actions / providerlint

mixed named and unnamed parameters

Check failure on line 399 in internal/service/glue/catalog_table.go

GitHub Actions / providerlint

expected ')', found context

Check failure on line 399 in internal/service/glue/catalog_table.go

GitHub Actions / 1 of 2

syntax error: unexpected resourceCatalogTableCreate, expected (

Check failure on line 399 in internal/service/glue/catalog_table.go

GitHub Actions / 1 of 2

expected '(', found resourceCatalogTableCreate (typecheck)

Check failure on line 399 in internal/service/glue/catalog_table.go

GitHub Actions / build-32-bit

syntax error: unexpected resourceCatalogTableCreate, expected (
var diags diag.Diagnostics
conn := meta.(*conns.AWSClient).GlueConn(ctx)

Check failure on line 401 in internal/service/glue/catalog_table.go

GitHub Actions / go build

syntax error: non-declaration statement outside function body

Check failure on line 401 in internal/service/glue/catalog_table.go

GitHub Actions / providerlint

syntax error: non-declaration statement outside function body

Check failure on line 401 in internal/service/glue/catalog_table.go

GitHub Actions / 1 of 2

syntax error: non-declaration statement outside function body (typecheck)

Check failure on line 401 in internal/service/glue/catalog_table.go

GitHub Actions / build-32-bit

syntax error: non-declaration statement outside function body
catalogID := createCatalogID(d, meta.(*conns.AWSClient).AccountID)
dbName := d.Get("database_name").(string)
name := d.Get("name").(string)
return append(diags, resourceCatalogTableRead(ctx, d, meta)...)
}
func resourceCatalogTableRead(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {

Check failure on line 424 in internal/service/glue/catalog_table.go

GitHub Actions / 1 of 2

expected '(', found resourceCatalogTableRead (typecheck)
var diags diag.Diagnostics
conn := meta.(*conns.AWSClient).GlueConn(ctx)
return diags
}
func resourceCatalogTableUpdate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {

Check failure on line 505 in internal/service/glue/catalog_table.go

GitHub Actions / 1 of 2

expected '(', found resourceCatalogTableUpdate (typecheck)
var diags diag.Diagnostics
conn := meta.(*conns.AWSClient).GlueConn(ctx)
// Copyright (c) HashiCorp, Inc.

Check failure on line 1 in internal/service/glue/catalog_database.go

GitHub Actions / 1 of 2

: # github.com/hashicorp/terraform-provider-aws/internal/service/glue
// SPDX-License-Identifier: MPL-2.0
package glue