Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix error when LB Rule action contains both target_group_arn and forward #35034

Closed
wants to merge 2 commits into from

Conversation

gdavison
Copy link
Contributor

Fixes error when LB Rule action contains both target_group_arn and forward. While specifying both values is technically valid in the API, the logic in the provider ignores forward if target_group_arn is set.

This PR will disallow setting both.

Currently implemented for aws_lb_listener, but contains errors in plan-time validation. Needs to also be implemented for aws_lb_listener_rule

Relations

Closes #22526

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

…n` or `default_action.forward` in `aws_lb_listener`. Also moves validation for requiring `default_action` fields to correspond to value of `type`
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Dec 21, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 21, 2023
@gdavison
Copy link
Contributor Author

gdavison commented Feb 6, 2024

Superseded by #35671

@gdavison gdavison closed this Feb 6, 2024
Copy link

github-actions bot commented Mar 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stickiness not getting applied for single target group block for aws_lb_listener and aws_lb_listener_rule
1 participant