Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_lb: Handle case where no updated attributes are supported #35228

Merged
merged 2 commits into from
Jan 11, 2024
Merged

aws_lb: Handle case where no updated attributes are supported #35228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44850f0
Handle case where no updated attributes are supported
Jan 10, 2024
2ec57a6
Update 35228.txt
ewbankkit Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/35228.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/aws_lb: Fix `ValidationError: Attributes cannot be empty` errors
```
4 changes: 4 additions & 0 deletions internal/service/elbv2/load_balancer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,6 +667,10 @@ func modifyLoadBalancerAttributes(ctx context.Context, conn *elbv2.ELBV2, arn st

// Not all attributes are supported in all partitions.
for {
if len(input.Attributes) == 0 {
return nil
}

ewbankkit marked this conversation as resolved.
Show resolved Hide resolved
_, err := conn.ModifyLoadBalancerAttributesWithContext(ctx, input)

if err != nil {
Expand Down
Loading