-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement configuring ignore_tags via environment variables #35264
Merged
Commits on Jan 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6e39c92 - Browse repository at this point
Copy the full SHA 6e39c92View commit details
Commits on Aug 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 54472d0 - Browse repository at this point
Copy the full SHA 54472d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 769190a - Browse repository at this point
Copy the full SHA 769190aView commit details -
internal/provider: adjust ignore tags envvar constant names
Also updates go docs for the default tags and ignore tags environment variables constants
Configuration menu - View commit details
-
Copy full SHA for e06b8c4 - Browse repository at this point
Copy the full SHA e06b8c4View commit details -
internal/provider(test): add TestExpandIgnoreTags test
```console % go test -v ./internal/provider/... -run=TestExpandIgnoreTags ? github.com/hashicorp/terraform-provider-aws/internal/provider/fwprovider [no test files] === RUN TestExpandIgnoreTags --- PASS: TestExpandIgnoreTags (0.00s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/provider 4.747s ```
Configuration menu - View commit details
-
Copy full SHA for 8aeb7c1 - Browse repository at this point
Copy the full SHA 8aeb7c1View commit details
Commits on Aug 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 51ba323 - Browse repository at this point
Copy the full SHA 51ba323View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb1a3ab - Browse repository at this point
Copy the full SHA bb1a3abView commit details -
internal/provider: adjust expandIgnoreTags logic
These changes retain legacy behavior which returns nil when no keys or prefixes are set and, for non-nil return objects, returns nil for empty key or prefix lists rather than the zero value `KeyValueTags` struct. Also adds additional test cases to cover variations on empty keys/prefixes and duplicated values.
Configuration menu - View commit details
-
Copy full SHA for bd75cc3 - Browse repository at this point
Copy the full SHA bd75cc3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.