Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement configuring ignore_tags via environment variables #35264

Merged
merged 8 commits into from
Aug 6, 2024

Commits on Jan 12, 2024

  1. Configuration menu
    Copy the full SHA
    6e39c92 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Configuration menu
    Copy the full SHA
    54472d0 View commit details
    Browse the repository at this point in the history
  2. chore: changelog

    jar-b committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    769190a View commit details
    Browse the repository at this point in the history
  3. internal/provider: adjust ignore tags envvar constant names

    Also updates go docs for the default tags and ignore tags environment variables constants
    jar-b committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    e06b8c4 View commit details
    Browse the repository at this point in the history
  4. internal/provider(test): add TestExpandIgnoreTags test

    ```console
    % go test -v ./internal/provider/... -run=TestExpandIgnoreTags
    ?       github.com/hashicorp/terraform-provider-aws/internal/provider/fwprovider        [no test files]
    === RUN   TestExpandIgnoreTags
    --- PASS: TestExpandIgnoreTags (0.00s)
    PASS
    ok      github.com/hashicorp/terraform-provider-aws/internal/provider   4.747s
    ```
    jar-b committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    8aeb7c1 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Configuration menu
    Copy the full SHA
    51ba323 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bb1a3ab View commit details
    Browse the repository at this point in the history
  3. internal/provider: adjust expandIgnoreTags logic

    These changes retain legacy behavior which returns nil when no keys or prefixes are set and, for non-nil return objects, returns nil for empty key or prefix lists rather than the zero value `KeyValueTags` struct. Also adds additional test cases to cover variations on empty keys/prefixes and duplicated values.
    jar-b committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    bd75cc3 View commit details
    Browse the repository at this point in the history