-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data source for default scraper configuration #35280
Add data source for default scraper configuration #35280
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Any updates on this one @justinretzolk ? |
% make testacc TESTARGS='-run=TestAccAMPScraperConfigurationDataSource_' PKG=amp make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.23.2 test ./internal/service/amp/... -v -count 1 -parallel 20 -run=TestAccAMPScraperConfigurationDataSource_ -timeout 360m 2024/10/09 14:12:44 Initializing Terraform AWS Provider... === RUN TestAccAMPScraperConfigurationDataSource_basic === PAUSE TestAccAMPScraperConfigurationDataSource_basic === CONT TestAccAMPScraperConfigurationDataSource_basic --- PASS: TestAccAMPScraperConfigurationDataSource_basic (8.80s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/amp 13.916s
…aper_configuration'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAMPDefaultScraperConfigurationDataSource_' PKG=amp
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/amp/... -v -count 1 -parallel 20 -run=TestAccAMPDefaultScraperConfigurationDataSource_ -timeout 360m
2024/10/09 14:32:22 Initializing Terraform AWS Provider...
=== RUN TestAccAMPDefaultScraperConfigurationDataSource_basic
=== PAUSE TestAccAMPDefaultScraperConfigurationDataSource_basic
=== CONT TestAccAMPDefaultScraperConfigurationDataSource_basic
--- PASS: TestAccAMPDefaultScraperConfigurationDataSource_basic (8.46s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/amp 13.694s
@bonclay7 Thanks for the contribution 🎉 👏. |
% make golangci-lint PKG=amp
make: golangci-lint Checks / 1 of 3...
make: golangci-lint Checks / 2 of 3...
WARN [config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`.
make: golangci-lint Checks / 3 of 3... |
@bonclay7 Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.72.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Amazon Managed service for Prometheus proposes a default, AWS-managed scrape configuration for the managed collector. This simplifies even further Prometheus metrics collection for EKS. This PR proposes a data source and documentation updates to use with the scraper.
Relations
Continuation of #34749
Output from Acceptance Testing