Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Set application autoscaling policy type by the configuration used #3536

Closed
wants to merge 2 commits into from

Conversation

tomelliff
Copy link
Contributor

@tomelliff tomelliff commented Feb 26, 2018

Just a failing test for now but should fix #3520 when tests pass.

No idea why this doesn't work right now but step scaling for ECS and target tracking for DDB does.
Raised an AWS support ticket to see if they can explain what's wrong there in the mean time.

TODO:

  • deprecate policy_type and simply get it from the type of scaling policy configuration used
  • expand the acceptance test to check the returned target tracking scaling configuration

@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Feb 26, 2018
No idea why this doesn't work but step scaling for ECS and target tracking for DDB does.
Raised an AWS support ticket to see if they can explain what's wrong there in the mean time.
@ghost ghost added the size/M Managed by automation to categorize the size of a PR. label Feb 26, 2018
@bflad bflad added bug Addresses a defect in current functionality. service/ecs Issues and PRs that pertain to the ecs service. labels Feb 27, 2018
To make it go green had to add policy_type which normally defaults to StepScaling.
This should probably be set by the type of scaling configuration block used in the resource instead and then deprecated.
Wanted to get the test built up and green before starting to refactor though.
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Feb 27, 2018
@tomelliff
Copy link
Contributor Author

I've fleshed out the acceptance test to cover a target tracking policy on an ECS service to match some amount of requests per target and added the currently necessary policy_type parameter for now before I refactor it out and deprecate it later tonight.

@tomelliff tomelliff changed the title WIP: Fix ECS target tracking autoscaling policy WIP: Set application autoscaling policy type by the configuration used Feb 27, 2018
@bflad
Copy link
Contributor

bflad commented Oct 9, 2018

Hi @tomelliff 👋 Are you planning on continuing work on this? If so, just let us know. If not, let's close this out to clean up the open pull requests to only those actually work in progress. Thanks!

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Oct 9, 2018
@bflad
Copy link
Contributor

bflad commented Nov 14, 2018

It's been a long time since we heard from you here so we're going to close this out to leave only actionable pull requests in the queue. If you or someone wants to continue this work please feel free to open a new PR (keeping the original commits 😄 ).

@bflad bflad closed this Nov 14, 2018
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
@breathingdust breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ecs Issues and PRs that pertain to the ecs service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/aws_appautoscaling_policy: ValidationException when creating target_tracking_scaling_policy_configuration
3 participants