Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct variable block in shield_application_layer_automatic_response documentation #35373

Merged
merged 1 commit into from
Jan 18, 2024
Merged

docs: correct variable block in shield_application_layer_automatic_response documentation #35373

merged 1 commit into from
Jan 18, 2024

Conversation

ntse
Copy link
Contributor

@ntse ntse commented Jan 18, 2024

Description

Corrects the var block in aws_shield_application_layer_automatic_response documentation page.

Relations

Closes #35372

References

https://developer.hashicorp.com/terraform/language/values/variables

Output from Acceptance Testing

n/a

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/shield Issues and PRs that pertain to the shield service. labels Jan 18, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jan 18, 2024
@ntse ntse changed the title docs: correct variable block in docs: correct variable block in shield_application_layer_automatic_response documentation Jan 18, 2024
Copy link
Member

@justinretzolk justinretzolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for taking the time to not only report this issue, but also to raise a PR to fix it! We really appreciate the contribution! I'll get this merged once the checks finish up 🚀

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jan 18, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @ntse 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk merged commit a12f861 into hashicorp:main Jan 18, 2024
58 checks passed
@github-actions github-actions bot added this to the v5.33.0 milestone Jan 18, 2024
@ntse ntse deleted the d-correct_shield_application_layer_automatic_response_var_block branch January 18, 2024 17:32
Copy link

This functionality has been released in v5.33.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/shield Issues and PRs that pertain to the shield service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs]: Invalid "var" block in aws_shield_application_layer_automatic_response
2 participants