Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: Migrate codegurureviewer resources to AWS SDK for Go v2 #35539

Merged
merged 8 commits into from
Jan 29, 2024

Conversation

ewbankkit
Copy link
Contributor

Description

Ibid.

Relations

Relates #32976.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccCodeGuruReviewerRepositoryAssociation_' PKG=codegurureviewer ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codegurureviewer/... -v -count 1 -parallel 2  -run=TestAccCodeGuruReviewerRepositoryAssociation_ -timeout 360m
=== RUN   TestAccCodeGuruReviewerRepositoryAssociation_basic
=== PAUSE TestAccCodeGuruReviewerRepositoryAssociation_basic
=== RUN   TestAccCodeGuruReviewerRepositoryAssociation_KMSKey
=== PAUSE TestAccCodeGuruReviewerRepositoryAssociation_KMSKey
=== RUN   TestAccCodeGuruReviewerRepositoryAssociation_S3Repository
=== PAUSE TestAccCodeGuruReviewerRepositoryAssociation_S3Repository
=== RUN   TestAccCodeGuruReviewerRepositoryAssociation_tags
=== PAUSE TestAccCodeGuruReviewerRepositoryAssociation_tags
=== RUN   TestAccCodeGuruReviewerRepositoryAssociation_disappears
=== PAUSE TestAccCodeGuruReviewerRepositoryAssociation_disappears
=== CONT  TestAccCodeGuruReviewerRepositoryAssociation_basic
=== CONT  TestAccCodeGuruReviewerRepositoryAssociation_tags
--- PASS: TestAccCodeGuruReviewerRepositoryAssociation_basic (75.49s)
=== CONT  TestAccCodeGuruReviewerRepositoryAssociation_disappears
--- PASS: TestAccCodeGuruReviewerRepositoryAssociation_tags (120.12s)
=== CONT  TestAccCodeGuruReviewerRepositoryAssociation_S3Repository
--- PASS: TestAccCodeGuruReviewerRepositoryAssociation_disappears (84.71s)
=== CONT  TestAccCodeGuruReviewerRepositoryAssociation_KMSKey
--- PASS: TestAccCodeGuruReviewerRepositoryAssociation_S3Repository (76.59s)
--- PASS: TestAccCodeGuruReviewerRepositoryAssociation_KMSKey (73.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codegurureviewer	244.340s

% make testacc TESTARGS='-run=TestAccCodeGuruReviewerRepositoryAssociation_' PKG=codegurureviewer ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codegurureviewer/... -v -count 1 -parallel 2  -run=TestAccCodeGuruReviewerRepositoryAssociation_ -timeout 360m
=== RUN   TestAccCodeGuruReviewerRepositoryAssociation_basic
=== PAUSE TestAccCodeGuruReviewerRepositoryAssociation_basic
=== RUN   TestAccCodeGuruReviewerRepositoryAssociation_KMSKey
=== PAUSE TestAccCodeGuruReviewerRepositoryAssociation_KMSKey
=== RUN   TestAccCodeGuruReviewerRepositoryAssociation_S3Repository
=== PAUSE TestAccCodeGuruReviewerRepositoryAssociation_S3Repository
=== RUN   TestAccCodeGuruReviewerRepositoryAssociation_tags
=== PAUSE TestAccCodeGuruReviewerRepositoryAssociation_tags
=== RUN   TestAccCodeGuruReviewerRepositoryAssociation_disappears
=== PAUSE TestAccCodeGuruReviewerRepositoryAssociation_disappears
=== CONT  TestAccCodeGuruReviewerRepositoryAssociation_basic
=== CONT  TestAccCodeGuruReviewerRepositoryAssociation_tags
--- PASS: TestAccCodeGuruReviewerRepositoryAssociation_basic (75.49s)
=== CONT  TestAccCodeGuruReviewerRepositoryAssociation_disappears
--- PASS: TestAccCodeGuruReviewerRepositoryAssociation_tags (120.12s)
=== CONT  TestAccCodeGuruReviewerRepositoryAssociation_S3Repository
--- PASS: TestAccCodeGuruReviewerRepositoryAssociation_disappears (84.71s)
=== CONT  TestAccCodeGuruReviewerRepositoryAssociation_KMSKey
--- PASS: TestAccCodeGuruReviewerRepositoryAssociation_S3Repository (76.59s)
--- PASS: TestAccCodeGuruReviewerRepositoryAssociation_KMSKey (73.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codegurureviewer	244.340s
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/codegurureviewer Issues and PRs that pertain to the codegurureviewer service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Jan 29, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 29, 2024
@ewbankkit ewbankkit merged commit 8c5f6a3 into main Jan 29, 2024
67 checks passed
@ewbankkit ewbankkit deleted the td-migrate-codegurureviewer-to-aws-sdk-v2 branch January 29, 2024 13:54
@github-actions github-actions bot added this to the v5.35.0 milestone Jan 29, 2024
github-actions bot pushed a commit that referenced this pull request Jan 29, 2024
Copy link

github-actions bot commented Feb 2, 2024

This functionality has been released in v5.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Mar 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2024
@justinretzolk justinretzolk added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/codegurureviewer Issues and PRs that pertain to the codegurureviewer service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants