Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add improved validation and required acceptance tests for aws_lb_listener and aws_lb_listener_rule #35583

Merged
merged 17 commits into from
Feb 1, 2024
Merged

Add improved validation and required acceptance tests for aws_lb_listener and aws_lb_listener_rule #35583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1a10001
Adds all parameters to `TestAccELBV2Listener_basic`
gdavison Jan 22, 2024
c1850cc
Creates constants for ALPN Policy
gdavison Jan 22, 2024
22f7061
Adds separate `basic` tests for each LB type
gdavison Jan 22, 2024
78519ba
Adds `plancheck` for `TestAccELBV2Listener_DefaultAction_orderRecreates`
gdavison Jan 22, 2024
f6bbee0
Renames `TestAccELBV2Listener_DefaultAction_orderRecreates` to `TestA…
gdavison Jan 24, 2024
5d8d4ea
Adds `disappears` test
gdavison Jan 24, 2024
6f204e8
Adds `mutual_authentication` check to `TestAccELBV2Listener_Protocol_…
gdavison Jan 25, 2024
5f74801
Adds function to return single `error` from an SDK `diag.Diagnostic`
gdavison Dec 21, 2023
33f49ac
Adds restriction to only allow one of `default_action.target_group_ar…
gdavison Jan 27, 2024
824d326
Renames `TestAccELBV2ListenerRule_ActionOrder_recreates` to `TestAccE…
gdavison Jan 29, 2024
47efbd1
Separates tests for default and specified order in Listener Rule
gdavison Jan 29, 2024
c26d99c
Adds restriction to only allow one of `action.target_group_arn` or `a…
gdavison Jan 30, 2024
b76d4b4
Refactors validation
gdavison Jan 31, 2024
bb99e7d
Removes noise from Semgrep rules
gdavison Jan 31, 2024
24c51eb
Removes unneeded `DiffSupressFunc`s
gdavison Jan 31, 2024
f8ea4d0
Linting fixes
gdavison Jan 31, 2024
7dc1920
Linting fixes
gdavison Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .ci/.semgrep-caps-aws-ec2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ rules:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)AWS"
- pattern-not-regex: "[Aa]wsSdkId"
severity: WARNING
- id: aws-in-var-name
languages:
Expand All @@ -53,6 +54,7 @@ rules:
metavariable: $NAME
patterns:
- pattern-regex: "(?i)AWS"
- pattern-not-regex: "[Aa]wsSdkId"
severity: WARNING
- id: caps0-in-func-name
languages:
Expand All @@ -67,6 +69,7 @@ rules:
metavariable: $NAME
patterns:
- pattern-regex: "(Cloudformation|ElasticSearch|Autoscaling|Elasticache|ApiGateway|Cloudfront|Cloudwatch|Workspaces|Appconfig|Guardduty|Sagemaker|DynamoDb|Dynamodb|Gamelift|Opsworks|Precheck|Rabbitmq|Worklink|Appmesh|Appsync|Graphql)"
- focus-metavariable: $NAME
severity: WARNING
- id: caps0-in-const-name
languages:
Expand Down Expand Up @@ -109,6 +112,7 @@ rules:
metavariable: $NAME
patterns:
- pattern-regex: "(Haproxy|AcmPca|Acmpca|Dnssec|Byoip|Cname|DocDb|Docdb|Fqdns|Https|Ipset|Iscsi|Mysql|Oauth|Posix|Wafv2|Cidr|Coip|Dhcp|Dkim|Ecmp)"
- focus-metavariable: $NAME
severity: WARNING
- id: caps1-in-const-name
languages:
Expand Down Expand Up @@ -151,6 +155,7 @@ rules:
metavariable: $NAME
patterns:
- pattern-regex: "(Fifo|Grpc|Http|Ipam|Jdbc|Json|Mwaa|Oidc|Pitr|Qldb|Sasl|Smtp|Voip|Xray|Yaml|Acl|Acm|Ami|Api|Arn|Asg)"
- focus-metavariable: $NAME
severity: WARNING
- id: caps2-in-const-name
languages:
Expand Down Expand Up @@ -193,6 +198,7 @@ rules:
metavariable: $NAME
patterns:
- pattern-regex: "(Asn|Bgp|Cmk|Cpu|Css|Csv|Dax|Dlm|Dms|Dns|Ebs|Ec2|Ecr|Ecs|Efs|Eip|Eks|Elb|Emr|FSX|Fms)"
- focus-metavariable: $NAME
severity: WARNING
- id: caps3-in-const-name
languages:
Expand Down Expand Up @@ -235,6 +241,7 @@ rules:
metavariable: $NAME
patterns:
- pattern-regex: "(Fsx|Gcm|Gp2|Gp3|Hsm|Hvm|Iam|Iot|Kms|Mfa|Msk|Nfs|Php|Rds|Rfc|Sfn|Smb|Sms|Sns|Sql|Sqs)"
- focus-metavariable: $NAME
severity: WARNING
- id: caps4-in-const-name
languages:
Expand Down Expand Up @@ -277,6 +284,7 @@ rules:
metavariable: $NAME
patterns:
- pattern-regex: "(Ssh|Ssl|Ssm|Sso|Sts|Swf|Tcp|Tls|Ttl|Uri|Url|Vgw|Vpc|Vpn|Waf|Xss|Db|Ip)"
- focus-metavariable: $NAME
severity: WARNING
- id: caps5-in-const-name
languages:
Expand Down Expand Up @@ -320,6 +328,7 @@ rules:
patterns:
- pattern-regex: "(?i)EC2"
- pattern-not-regex: ^TestAcc.*
- focus-metavariable: $NAME
severity: WARNING
- id: ec2-in-const-name
languages:
Expand Down
Loading
Loading