Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: Migrate cloud9 resources to AWS SDK for Go v2 #35599

Merged
merged 8 commits into from
Feb 16, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Feb 1, 2024

Description

Ibid.

Relations

Relates #32976.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccCloud9' PKG=cloud9 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloud9/... -v -count 1 -parallel 3  -run=TestAccCloud9 -timeout 360m
=== RUN   TestAccCloud9EnvironmentEC2_basic
=== PAUSE TestAccCloud9EnvironmentEC2_basic
=== RUN   TestAccCloud9EnvironmentEC2_allFields
=== PAUSE TestAccCloud9EnvironmentEC2_allFields
=== RUN   TestAccCloud9EnvironmentEC2_tags
=== PAUSE TestAccCloud9EnvironmentEC2_tags
=== RUN   TestAccCloud9EnvironmentEC2_disappears
=== PAUSE TestAccCloud9EnvironmentEC2_disappears
=== RUN   TestAccCloud9EnvironmentMembership_basic
=== PAUSE TestAccCloud9EnvironmentMembership_basic
=== RUN   TestAccCloud9EnvironmentMembership_disappears
=== PAUSE TestAccCloud9EnvironmentMembership_disappears
=== RUN   TestAccCloud9EnvironmentMembership_Disappears_env
=== PAUSE TestAccCloud9EnvironmentMembership_Disappears_env
=== CONT  TestAccCloud9EnvironmentEC2_basic
=== CONT  TestAccCloud9EnvironmentEC2_tags
=== CONT  TestAccCloud9EnvironmentMembership_Disappears_env
--- PASS: TestAccCloud9EnvironmentEC2_basic (160.02s)
=== CONT  TestAccCloud9EnvironmentEC2_allFields
--- PASS: TestAccCloud9EnvironmentMembership_Disappears_env (165.91s)
=== CONT  TestAccCloud9EnvironmentMembership_basic
--- PASS: TestAccCloud9EnvironmentEC2_tags (246.72s)
=== CONT  TestAccCloud9EnvironmentEC2_disappears
--- PASS: TestAccCloud9EnvironmentMembership_basic (182.86s)
=== CONT  TestAccCloud9EnvironmentMembership_disappears
--- PASS: TestAccCloud9EnvironmentEC2_allFields (234.72s)
--- PASS: TestAccCloud9EnvironmentEC2_disappears (157.69s)
--- PASS: TestAccCloud9EnvironmentMembership_disappears (156.42s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloud9	539.769s

Copy link

github-actions bot commented Feb 1, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. service/cloud9 Issues and PRs that pertain to the cloud9 service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Feb 1, 2024
@ewbankkit ewbankkit added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Feb 1, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 1, 2024
Copy link

github-actions bot commented Feb 1, 2024

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@ewbankkit
Copy link
Contributor Author

Blocked by aws/aws-sdk-go-v2#2476.

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

# Conflicts:
#	go.mod
#	go.sum
#	names/names.go
@ewbankkit ewbankkit merged commit ed21e02 into main Feb 16, 2024
45 checks passed
@ewbankkit ewbankkit deleted the td-migrate-cloud9-to-aws-sdk-v2 branch February 16, 2024 19:55
@github-actions github-actions bot added this to the v5.38.0 milestone Feb 16, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 23, 2024
Copy link

This functionality has been released in v5.38.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
@justinretzolk justinretzolk added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/cloud9 Issues and PRs that pertain to the cloud9 service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants