Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech Debt: synthetics service to AWS Go SDKv2 #35600

Merged
merged 8 commits into from
Feb 2, 2024

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Feb 1, 2024

Description

Relations

Relates #32976

References

Output from Acceptance Testing

% make testacc TESTARGS="-run=TestAccSynthetics" PKG=synthetics

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/synthetics/... -v -count 1 -parallel 20  -run=TestAccSynthetics -timeout 360m
--- PASS: TestAccSyntheticsGroup_disappears (15.82s)
--- PASS: TestAccSyntheticsGroup_basic (17.69s)
--- PASS: TestAccSyntheticsGroup_tags (31.50s)
--- PASS: TestAccSyntheticsGroupAssociation_disappears (59.94s)
--- PASS: TestAccSyntheticsCanary_s3 (62.23s)
--- PASS: TestAccSyntheticsCanary_artifactEncryption (65.36s)
--- PASS: TestAccSyntheticsCanary_disappears (65.90s)
--- PASS: TestAccSyntheticsCanary_runTracing (66.15s)
--- PASS: TestAccSyntheticsGroupAssociation_basic (68.31s)
--- PASS: TestAccSyntheticsCanary_runEnvironmentVariables (70.80s)
--- PASS: TestAccSyntheticsCanary_tags (75.68s)
--- PASS: TestAccSyntheticsCanary_startCanary (81.70s)
--- PASS: TestAccSyntheticsCanary_basic (88.25s)
--- PASS: TestAccSyntheticsCanary_run (89.31s)
--- PASS: TestAccSyntheticsCanary_runtimeVersion (97.08s)
--- PASS: TestAccSyntheticsCanary_StartCanary_codeChanges (98.67s)
--- PASS: TestAccSyntheticsCanary_vpc (1939.52s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/synthetics	1946.647s

Copy link

github-actions bot commented Feb 1, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/synthetics Issues and PRs that pertain to the synthetics service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. labels Feb 1, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 1, 2024
Copy link

github-actions bot commented Feb 1, 2024

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@johnsonaj johnsonaj added the technical-debt Addresses areas of the codebase that need refactoring or redesign. label Feb 2, 2024
@johnsonaj johnsonaj marked this pull request as ready for review February 2, 2024 00:31
@johnsonaj johnsonaj merged commit bd1cd87 into main Feb 2, 2024
44 checks passed
@johnsonaj johnsonaj deleted the td-synthetics_sdkv2_framework branch February 2, 2024 17:54
@github-actions github-actions bot added this to the v5.36.0 milestone Feb 2, 2024
@johnsonaj
Copy link
Contributor Author

johnsonaj commented Feb 5, 2024

Relates aws/go-sdk-v2/#2482

Copy link

github-actions bot commented Feb 8, 2024

This functionality has been released in v5.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/synthetics Issues and PRs that pertain to the synthetics service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant