r/aws_kinesis_firehose_delivery_stream: Change parameters from TypeList to TypeSet

[ewbankkit]

Description

Changes extended_s3_configuration.processing_configuration.processors.parameters from TypeList to TypeSet as order is not significant.

Previously:

% make testacc TESTARGS='-run=TestAccFirehoseDeliveryStream_extendedS3Updates' PKG=firehose
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/firehose/... -v -count 1 -parallel 20  -run=TestAccFirehoseDeliveryStream_extendedS3Updates -timeout 360m
=== RUN   TestAccFirehoseDeliveryStream_extendedS3Updates
=== PAUSE TestAccFirehoseDeliveryStream_extendedS3Updates
=== CONT  TestAccFirehoseDeliveryStream_extendedS3Updates
    delivery_stream_test.go:843: Step 3/5 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        Terraform used the selected providers to generate the following execution
        plan. Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # aws_kinesis_firehose_delivery_stream.test will be updated in-place
          ~ resource "aws_kinesis_firehose_delivery_stream" "test" {
                id             = "arn:aws:firehose:us-west-2:123456789012:deliverystream/tf-acc-test-4767943819471478403"
                name           = "tf-acc-test-4767943819471478403"
                tags           = {}
                # (5 unchanged attributes hidden)
        
              ~ extended_s3_configuration {
                    # (6 unchanged attributes hidden)
        
        
                  ~ processing_configuration {
                        # (1 unchanged attribute hidden)
        
                      ~ processors {
                            # (1 unchanged attribute hidden)
        
                          ~ parameters {
                              ~ parameter_name  = "LambdaArn" -> "BufferIntervalInSeconds"
                              ~ parameter_value = "arn:aws:lambda:us-west-2:123456789012:function:tf-acc-test-4767943819471478403:$LATEST" -> "70"
                            }
                          ~ parameters {
                              ~ parameter_name  = "BufferSizeInMBs" -> "LambdaArn"
                              ~ parameter_value = "1.1" -> "arn:aws:lambda:us-west-2:123456789012:function:tf-acc-test-4767943819471478403:$LATEST"
                            }
                          ~ parameters {
                              ~ parameter_name  = "BufferIntervalInSeconds" -> "BufferSizeInMBs"
                              ~ parameter_value = "70" -> "1.1"
                            }
                        }
                    }
        
                    # (2 unchanged blocks hidden)
                }
        
                # (1 unchanged block hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccFirehoseDeliveryStream_extendedS3Updates (147.42s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/firehose	158.714s
FAIL
make: *** [testacc] Error 1

Relations

Closes #35669.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccFirehoseDeliveryStream_extendedS3Updates' PKG=firehose
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/firehose/... -v -count 1 -parallel 20  -run=TestAccFirehoseDeliveryStream_extendedS3Updates -timeout 360m
=== RUN   TestAccFirehoseDeliveryStream_extendedS3Updates
=== PAUSE TestAccFirehoseDeliveryStream_extendedS3Updates
=== CONT  TestAccFirehoseDeliveryStream_extendedS3Updates
--- PASS: TestAccFirehoseDeliveryStream_extendedS3Updates (245.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/firehose	256.791s

% make testacc TESTARGS='-run=TestAccFirehoseDeliveryStream_basic' PKG=firehose
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/firehose/... -v -count 1 -parallel 20  -run=TestAccFirehoseDeliveryStream_basic -timeout 360m
=== RUN   TestAccFirehoseDeliveryStream_basic
=== PAUSE TestAccFirehoseDeliveryStream_basic
=== CONT  TestAccFirehoseDeliveryStream_basic
--- PASS: TestAccFirehoseDeliveryStream_basic (230.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/firehose	241.982s

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/firehose/... -v -count 1 -parallel 20  -run=TestAccFirehoseDeliveryStream_openSearchServerlessUpdates -timeout 360m
=== RUN   TestAccFirehoseDeliveryStream_openSearchServerlessUpdates
=== PAUSE TestAccFirehoseDeliveryStream_openSearchServerlessUpdates
=== CONT  TestAccFirehoseDeliveryStream_openSearchServerlessUpdates
--- PASS: TestAccFirehoseDeliveryStream_openSearchServerlessUpdates (587.55s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/firehose	598.900s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🎉

[github-actions]

This functionality has been released in v5.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.