Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes unexpected diff for aws_lb_listener and aws_lb_listener_rule #35678

Merged
merged 6 commits into from
Feb 7, 2024
Merged

Fixes unexpected diff for aws_lb_listener and aws_lb_listener_rule #35678

merged 6 commits into from
Feb 7, 2024

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Feb 7, 2024

Description

Prior to v5.35.0, invalid parameters for the action type were ignored. In order to provide warnings to users in advance of returning errors in v6.0, the invalid configurations were no longer ignored. However, this caused unexpected diffs to be reported for existing aws_lb_listener and aws_lb_listener_rule resources.

Ignores the invalid configuration again. This means that there will be no warnings about the invalid configuration for users.

Relations

Closes #35668

References

Output from Acceptance Testing

% make testacc PKG=elbv2 TESTS=TestAccELBV2Listener_

--- PASS: TestAccELBV2Listener_forwardTargetARNAndBlock (4.80s)
--- PASS: TestAccELBV2Listener_LoadBalancerARN_gatewayLoadBalancer (167.17s)
--- PASS: TestAccELBV2Listener_Gateway_basic (187.15s)
--- PASS: TestAccELBV2Listener_EmptyDefaultAction (0.00s)
    --- PASS: TestAccELBV2Listener_EmptyDefaultAction/authenticate-oidc (1.39s)
    --- PASS: TestAccELBV2Listener_EmptyDefaultAction/fixed-response (1.53s)
    --- PASS: TestAccELBV2Listener_EmptyDefaultAction/forward (1.43s)
    --- PASS: TestAccELBV2Listener_EmptyDefaultAction/redirect (1.61s)
    --- PASS: TestAccELBV2Listener_EmptyDefaultAction/authenticate-cognito (1.91s)
--- PASS: TestAccELBV2Listener_fixedResponse (203.64s)
--- PASS: TestAccELBV2Listener_Protocol_tls (212.16s)
--- PASS: TestAccELBV2Listener_oidc (224.74s)
--- PASS: TestAccELBV2Listener_DefaultAction_defaultOrder (225.49s)
--- PASS: TestAccELBV2Listener_DefaultAction_actionDisappears (226.60s)
--- PASS: TestAccELBV2Listener_mutualAuthentication (228.68s)
--- PASS: TestAccELBV2Listener_disappears (230.89s)
--- PASS: TestAccELBV2Listener_cognito (234.95s)
--- PASS: TestAccELBV2Listener_DefaultAction_specifyOrder (236.55s)
--- PASS: TestAccELBV2Listener_Application_basic (237.40s)
--- PASS: TestAccELBV2Listener_tags (251.23s)
--- PASS: TestAccELBV2Listener_redirect (255.89s)
--- PASS: TestAccELBV2Listener_forwardWeighted (257.19s)
--- PASS: TestAccELBV2Listener_mutualAuthenticationPassthrough (257.39s)
--- PASS: TestAccELBV2Listener_redirectWithTargetGroupARN (260.94s)
--- PASS: TestAccELBV2Listener_Protocol_https (273.93s)
--- PASS: TestAccELBV2Listener_backwardsCompatibility (274.42s)
--- PASS: TestAccELBV2Listener_Protocol_upd (283.94s)
--- PASS: TestAccELBV2Listener_Network_basic (196.09s)
% make testacc PKG=elbv2 TESTS=TestAccELBV2ListenerRule_

--- PASS: TestAccELBV2ListenerRule_ConditionHTTPHeader_invalid (3.96s)
--- PASS: TestAccELBV2ListenerRule_forwardTargetARNAndBlock (5.22s)
--- PASS: TestAccELBV2ListenerRule_conditionAttributesCount (21.88s)
--- PASS: TestAccELBV2ListenerRule_basic (199.00s)
--- PASS: TestAccELBV2ListenerRule_cognito (205.27s)
--- PASS: TestAccELBV2ListenerRule_conditionHTTPHeader (215.73s)
--- PASS: TestAccELBV2ListenerRule_updateRulePriority (225.82s)
--- PASS: TestAccELBV2ListenerRule_conditionHTTPRequestMethod (228.47s)
--- PASS: TestAccELBV2ListenerRule_conditionUpdateMultiple (230.99s)
--- PASS: TestAccELBV2ListenerRule_conditionMultiple (234.38s)
--- PASS: TestAccELBV2ListenerRule_Action_defaultOrder (237.08s)
--- PASS: TestAccELBV2ListenerRule_conditionSourceIP (237.53s)
--- PASS: TestAccELBV2ListenerRule_Action_specifyOrder (237.65s)
--- PASS: TestAccELBV2ListenerRule_conditionHostHeader (238.93s)
--- PASS: TestAccELBV2ListenerRule_EmptyAction (0.00s)
    --- PASS: TestAccELBV2ListenerRule_EmptyAction/forward (1.42s)
    --- PASS: TestAccELBV2ListenerRule_EmptyAction/redirect (1.53s)
    --- PASS: TestAccELBV2ListenerRule_EmptyAction/fixed-response (1.76s)
    --- PASS: TestAccELBV2ListenerRule_EmptyAction/authenticate-cognito (1.74s)
    --- PASS: TestAccELBV2ListenerRule_EmptyAction/authenticate-oidc (1.70s)
--- PASS: TestAccELBV2ListenerRule_conditionQueryString (242.39s)
--- FAIL: TestAccELBV2ListenerRule_priority (246.14s)
--- PASS: TestAccELBV2ListenerRule_changeListenerRuleARNForcesNew (253.08s)
--- PASS: TestAccELBV2ListenerRule_fixedResponse (248.93s)
--- PASS: TestAccELBV2ListenerRule_updateFixedResponse (258.86s)
--- PASS: TestAccELBV2ListenerRule_oidc (263.31s)
--- PASS: TestAccELBV2ListenerRule_redirectWithTargetGroupARN (269.66s)
--- PASS: TestAccELBV2ListenerRule_conditionUpdateMixed (280.04s)
--- PASS: TestAccELBV2ListenerRule_redirect (260.90s)
--- PASS: TestAccELBV2ListenerRule_backwardsCompatibility (197.27s)
--- PASS: TestAccELBV2ListenerRule_Action_actionDisappears (193.72s)
--- PASS: TestAccELBV2ListenerRule_disappears (195.89s)
--- PASS: TestAccELBV2ListenerRule_tags (215.25s)
--- PASS: TestAccELBV2ListenerRule_conditionPathPattern (207.06s)
--- PASS: TestAccELBV2ListenerRule_forwardWeighted (215.71s)
--- PASS: TestAccELBV2ListenerRule_priority (299.62s)

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Feb 7, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 7, 2024
@ewbankkit
Copy link
Contributor

Needs a CHANGELOG entry.

ewbankkit
ewbankkit approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccELBV2Listener_\|TestAccELBV2ListenerRule_' PKG=elbv2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/elbv2/... -v -count 1 -parallel 2  -run=TestAccELBV2Listener_\|TestAccELBV2ListenerRule_ -timeout 360m
=== RUN   TestAccELBV2ListenerRule_basic
=== PAUSE TestAccELBV2ListenerRule_basic
=== RUN   TestAccELBV2ListenerRule_disappears
=== PAUSE TestAccELBV2ListenerRule_disappears
=== RUN   TestAccELBV2ListenerRule_tags
=== PAUSE TestAccELBV2ListenerRule_tags
=== RUN   TestAccELBV2ListenerRule_forwardWeighted
=== PAUSE TestAccELBV2ListenerRule_forwardWeighted
=== RUN   TestAccELBV2ListenerRule_forwardTargetARNAndBlock
=== PAUSE TestAccELBV2ListenerRule_forwardTargetARNAndBlock
=== RUN   TestAccELBV2ListenerRule_backwardsCompatibility
=== PAUSE TestAccELBV2ListenerRule_backwardsCompatibility
=== RUN   TestAccELBV2ListenerRule_redirect
=== PAUSE TestAccELBV2ListenerRule_redirect
=== RUN   TestAccELBV2ListenerRule_fixedResponse
=== PAUSE TestAccELBV2ListenerRule_fixedResponse
=== RUN   TestAccELBV2ListenerRule_updateFixedResponse
=== PAUSE TestAccELBV2ListenerRule_updateFixedResponse
=== RUN   TestAccELBV2ListenerRule_updateRulePriority
=== PAUSE TestAccELBV2ListenerRule_updateRulePriority
=== RUN   TestAccELBV2ListenerRule_changeListenerRuleARNForcesNew
=== PAUSE TestAccELBV2ListenerRule_changeListenerRuleARNForcesNew
=== RUN   TestAccELBV2ListenerRule_priority
=== PAUSE TestAccELBV2ListenerRule_priority
=== RUN   TestAccELBV2ListenerRule_cognito
=== PAUSE TestAccELBV2ListenerRule_cognito
=== RUN   TestAccELBV2ListenerRule_oidc
=== PAUSE TestAccELBV2ListenerRule_oidc
=== RUN   TestAccELBV2ListenerRule_Action_defaultOrder
=== PAUSE TestAccELBV2ListenerRule_Action_defaultOrder
=== RUN   TestAccELBV2ListenerRule_Action_specifyOrder
=== PAUSE TestAccELBV2ListenerRule_Action_specifyOrder
=== RUN   TestAccELBV2ListenerRule_Action_actionDisappears
=== PAUSE TestAccELBV2ListenerRule_Action_actionDisappears
=== RUN   TestAccELBV2ListenerRule_EmptyAction
=== PAUSE TestAccELBV2ListenerRule_EmptyAction
=== RUN   TestAccELBV2ListenerRule_redirectWithTargetGroupARN
=== PAUSE TestAccELBV2ListenerRule_redirectWithTargetGroupARN
=== RUN   TestAccELBV2ListenerRule_conditionAttributesCount
=== PAUSE TestAccELBV2ListenerRule_conditionAttributesCount
=== RUN   TestAccELBV2ListenerRule_conditionHostHeader
=== PAUSE TestAccELBV2ListenerRule_conditionHostHeader
=== RUN   TestAccELBV2ListenerRule_conditionHTTPHeader
=== PAUSE TestAccELBV2ListenerRule_conditionHTTPHeader
=== RUN   TestAccELBV2ListenerRule_ConditionHTTPHeader_invalid
=== PAUSE TestAccELBV2ListenerRule_ConditionHTTPHeader_invalid
=== RUN   TestAccELBV2ListenerRule_conditionHTTPRequestMethod
=== PAUSE TestAccELBV2ListenerRule_conditionHTTPRequestMethod
=== RUN   TestAccELBV2ListenerRule_conditionPathPattern
=== PAUSE TestAccELBV2ListenerRule_conditionPathPattern
=== RUN   TestAccELBV2ListenerRule_conditionQueryString
=== PAUSE TestAccELBV2ListenerRule_conditionQueryString
=== RUN   TestAccELBV2ListenerRule_conditionSourceIP
=== PAUSE TestAccELBV2ListenerRule_conditionSourceIP
=== RUN   TestAccELBV2ListenerRule_conditionUpdateMixed
=== PAUSE TestAccELBV2ListenerRule_conditionUpdateMixed
=== RUN   TestAccELBV2ListenerRule_conditionMultiple
=== PAUSE TestAccELBV2ListenerRule_conditionMultiple
=== RUN   TestAccELBV2ListenerRule_conditionUpdateMultiple
=== PAUSE TestAccELBV2ListenerRule_conditionUpdateMultiple
=== RUN   TestAccELBV2Listener_Application_basic
=== PAUSE TestAccELBV2Listener_Application_basic
=== RUN   TestAccELBV2Listener_Network_basic
=== PAUSE TestAccELBV2Listener_Network_basic
=== RUN   TestAccELBV2Listener_Gateway_basic
=== PAUSE TestAccELBV2Listener_Gateway_basic
=== RUN   TestAccELBV2Listener_disappears
=== PAUSE TestAccELBV2Listener_disappears
=== RUN   TestAccELBV2Listener_tags
=== PAUSE TestAccELBV2Listener_tags
=== RUN   TestAccELBV2Listener_forwardWeighted
=== PAUSE TestAccELBV2Listener_forwardWeighted
=== RUN   TestAccELBV2Listener_forwardTargetARNAndBlock
=== PAUSE TestAccELBV2Listener_forwardTargetARNAndBlock
=== RUN   TestAccELBV2Listener_Protocol_upd
=== PAUSE TestAccELBV2Listener_Protocol_upd
=== RUN   TestAccELBV2Listener_backwardsCompatibility
=== PAUSE TestAccELBV2Listener_backwardsCompatibility
=== RUN   TestAccELBV2Listener_Protocol_https
=== PAUSE TestAccELBV2Listener_Protocol_https
=== RUN   TestAccELBV2Listener_mutualAuthentication
=== PAUSE TestAccELBV2Listener_mutualAuthentication
=== RUN   TestAccELBV2Listener_mutualAuthenticationPassthrough
=== PAUSE TestAccELBV2Listener_mutualAuthenticationPassthrough
=== RUN   TestAccELBV2Listener_LoadBalancerARN_gatewayLoadBalancer
=== PAUSE TestAccELBV2Listener_LoadBalancerARN_gatewayLoadBalancer
=== RUN   TestAccELBV2Listener_Protocol_tls
=== PAUSE TestAccELBV2Listener_Protocol_tls
=== RUN   TestAccELBV2Listener_redirect
=== PAUSE TestAccELBV2Listener_redirect
=== RUN   TestAccELBV2Listener_fixedResponse
=== PAUSE TestAccELBV2Listener_fixedResponse
=== RUN   TestAccELBV2Listener_cognito
=== PAUSE TestAccELBV2Listener_cognito
=== RUN   TestAccELBV2Listener_oidc
=== PAUSE TestAccELBV2Listener_oidc
=== RUN   TestAccELBV2Listener_DefaultAction_defaultOrder
=== PAUSE TestAccELBV2Listener_DefaultAction_defaultOrder
=== RUN   TestAccELBV2Listener_DefaultAction_specifyOrder
=== PAUSE TestAccELBV2Listener_DefaultAction_specifyOrder
=== RUN   TestAccELBV2Listener_DefaultAction_actionDisappears
=== PAUSE TestAccELBV2Listener_DefaultAction_actionDisappears
=== RUN   TestAccELBV2Listener_EmptyDefaultAction
=== PAUSE TestAccELBV2Listener_EmptyDefaultAction
=== RUN   TestAccELBV2Listener_redirectWithTargetGroupARN
=== PAUSE TestAccELBV2Listener_redirectWithTargetGroupARN
=== CONT  TestAccELBV2ListenerRule_basic
=== CONT  TestAccELBV2ListenerRule_conditionUpdateMixed
--- PASS: TestAccELBV2ListenerRule_basic (204.23s)
=== CONT  TestAccELBV2Listener_mutualAuthentication
--- PASS: TestAccELBV2ListenerRule_conditionUpdateMixed (265.94s)
=== CONT  TestAccELBV2Listener_redirectWithTargetGroupARN
--- PASS: TestAccELBV2Listener_redirectWithTargetGroupARN (274.55s)
=== CONT  TestAccELBV2Listener_EmptyDefaultAction
=== RUN   TestAccELBV2Listener_EmptyDefaultAction/redirect
=== PAUSE TestAccELBV2Listener_EmptyDefaultAction/redirect
=== RUN   TestAccELBV2Listener_EmptyDefaultAction/fixed-response
=== PAUSE TestAccELBV2Listener_EmptyDefaultAction/fixed-response
=== RUN   TestAccELBV2Listener_EmptyDefaultAction/forward
=== PAUSE TestAccELBV2Listener_EmptyDefaultAction/forward
=== RUN   TestAccELBV2Listener_EmptyDefaultAction/authenticate-oidc
=== PAUSE TestAccELBV2Listener_EmptyDefaultAction/authenticate-oidc
=== RUN   TestAccELBV2Listener_EmptyDefaultAction/authenticate-cognito
=== PAUSE TestAccELBV2Listener_EmptyDefaultAction/authenticate-cognito
=== CONT  TestAccELBV2Listener_DefaultAction_actionDisappears
--- PASS: TestAccELBV2Listener_mutualAuthentication (209.59s)
=== CONT  TestAccELBV2Listener_DefaultAction_specifyOrder
--- PASS: TestAccELBV2Listener_DefaultAction_actionDisappears (212.14s)
=== CONT  TestAccELBV2Listener_DefaultAction_defaultOrder
--- PASS: TestAccELBV2Listener_DefaultAction_specifyOrder (194.77s)
=== CONT  TestAccELBV2Listener_oidc
--- PASS: TestAccELBV2Listener_DefaultAction_defaultOrder (217.12s)
=== CONT  TestAccELBV2Listener_cognito
--- PASS: TestAccELBV2Listener_oidc (233.59s)
=== CONT  TestAccELBV2Listener_fixedResponse
--- PASS: TestAccELBV2Listener_cognito (223.43s)
=== CONT  TestAccELBV2Listener_redirect
--- PASS: TestAccELBV2Listener_fixedResponse (232.93s)
=== CONT  TestAccELBV2Listener_Protocol_tls
--- PASS: TestAccELBV2Listener_redirect (222.80s)
=== CONT  TestAccELBV2Listener_LoadBalancerARN_gatewayLoadBalancer
--- PASS: TestAccELBV2Listener_LoadBalancerARN_gatewayLoadBalancer (192.93s)
=== CONT  TestAccELBV2Listener_mutualAuthenticationPassthrough
--- PASS: TestAccELBV2Listener_Protocol_tls (330.42s)
=== CONT  TestAccELBV2ListenerRule_Action_defaultOrder
--- PASS: TestAccELBV2Listener_mutualAuthenticationPassthrough (217.15s)
=== CONT  TestAccELBV2ListenerRule_conditionSourceIP
--- PASS: TestAccELBV2ListenerRule_Action_defaultOrder (212.92s)
=== CONT  TestAccELBV2ListenerRule_fixedResponse
--- PASS: TestAccELBV2ListenerRule_conditionSourceIP (220.73s)
=== CONT  TestAccELBV2ListenerRule_oidc
--- PASS: TestAccELBV2ListenerRule_fixedResponse (209.01s)
=== CONT  TestAccELBV2ListenerRule_cognito
--- PASS: TestAccELBV2ListenerRule_oidc (219.49s)
=== CONT  TestAccELBV2ListenerRule_conditionQueryString
--- PASS: TestAccELBV2ListenerRule_cognito (219.77s)
=== CONT  TestAccELBV2ListenerRule_priority
--- PASS: TestAccELBV2ListenerRule_conditionQueryString (218.55s)
=== CONT  TestAccELBV2ListenerRule_changeListenerRuleARNForcesNew
--- PASS: TestAccELBV2ListenerRule_priority (362.16s)
=== CONT  TestAccELBV2ListenerRule_updateRulePriority
--- PASS: TestAccELBV2ListenerRule_changeListenerRuleARNForcesNew (237.46s)
=== CONT  TestAccELBV2ListenerRule_conditionPathPattern
--- PASS: TestAccELBV2ListenerRule_updateRulePriority (228.48s)
=== CONT  TestAccELBV2ListenerRule_conditionHTTPRequestMethod
--- PASS: TestAccELBV2ListenerRule_conditionPathPattern (221.33s)
=== CONT  TestAccELBV2ListenerRule_ConditionHTTPHeader_invalid
--- PASS: TestAccELBV2ListenerRule_ConditionHTTPHeader_invalid (1.89s)
=== CONT  TestAccELBV2ListenerRule_conditionHTTPHeader
--- PASS: TestAccELBV2ListenerRule_conditionHTTPRequestMethod (221.32s)
=== CONT  TestAccELBV2ListenerRule_updateFixedResponse
--- PASS: TestAccELBV2ListenerRule_conditionHTTPHeader (219.33s)
=== CONT  TestAccELBV2ListenerRule_conditionHostHeader
--- PASS: TestAccELBV2ListenerRule_updateFixedResponse (246.61s)
=== CONT  TestAccELBV2ListenerRule_conditionAttributesCount
--- PASS: TestAccELBV2ListenerRule_conditionHostHeader (215.17s)
=== CONT  TestAccELBV2Listener_tags
--- PASS: TestAccELBV2ListenerRule_conditionAttributesCount (22.57s)
=== CONT  TestAccELBV2ListenerRule_redirectWithTargetGroupARN
--- PASS: TestAccELBV2ListenerRule_redirectWithTargetGroupARN (271.87s)
=== CONT  TestAccELBV2Listener_Protocol_https
--- PASS: TestAccELBV2Listener_Protocol_https (214.70s)
=== CONT  TestAccELBV2ListenerRule_EmptyAction
=== RUN   TestAccELBV2ListenerRule_EmptyAction/forward
=== PAUSE TestAccELBV2ListenerRule_EmptyAction/forward
=== RUN   TestAccELBV2ListenerRule_EmptyAction/authenticate-oidc
=== PAUSE TestAccELBV2ListenerRule_EmptyAction/authenticate-oidc
=== RUN   TestAccELBV2ListenerRule_EmptyAction/authenticate-cognito
=== PAUSE TestAccELBV2ListenerRule_EmptyAction/authenticate-cognito
=== RUN   TestAccELBV2ListenerRule_EmptyAction/redirect
=== PAUSE TestAccELBV2ListenerRule_EmptyAction/redirect
=== RUN   TestAccELBV2ListenerRule_EmptyAction/fixed-response
=== PAUSE TestAccELBV2ListenerRule_EmptyAction/fixed-response
=== CONT  TestAccELBV2Listener_backwardsCompatibility
--- PASS: TestAccELBV2Listener_tags (237.78s)
=== CONT  TestAccELBV2ListenerRule_Action_actionDisappears
--- PASS: TestAccELBV2Listener_backwardsCompatibility (222.41s)
=== CONT  TestAccELBV2ListenerRule_Action_specifyOrder
--- PASS: TestAccELBV2ListenerRule_Action_actionDisappears (234.44s)
=== CONT  TestAccELBV2Listener_Protocol_upd
--- PASS: TestAccELBV2ListenerRule_Action_specifyOrder (239.16s)
=== CONT  TestAccELBV2Listener_forwardTargetARNAndBlock
--- PASS: TestAccELBV2Listener_forwardTargetARNAndBlock (3.20s)
=== CONT  TestAccELBV2ListenerRule_forwardTargetARNAndBlock
--- PASS: TestAccELBV2ListenerRule_forwardTargetARNAndBlock (3.36s)
=== CONT  TestAccELBV2ListenerRule_redirect
--- PASS: TestAccELBV2Listener_Protocol_upd (242.86s)
=== CONT  TestAccELBV2ListenerRule_backwardsCompatibility
--- PASS: TestAccELBV2ListenerRule_backwardsCompatibility (235.27s)
=== CONT  TestAccELBV2Listener_forwardWeighted
--- PASS: TestAccELBV2ListenerRule_redirect (269.81s)
=== CONT  TestAccELBV2ListenerRule_conditionUpdateMultiple
--- PASS: TestAccELBV2Listener_forwardWeighted (256.87s)
=== CONT  TestAccELBV2Listener_Application_basic
--- PASS: TestAccELBV2ListenerRule_conditionUpdateMultiple (246.61s)
=== CONT  TestAccELBV2ListenerRule_tags
--- PASS: TestAccELBV2Listener_Application_basic (214.65s)
=== CONT  TestAccELBV2Listener_disappears
--- PASS: TestAccELBV2ListenerRule_tags (236.26s)
=== CONT  TestAccELBV2Listener_Network_basic
--- PASS: TestAccELBV2Listener_disappears (219.15s)
=== CONT  TestAccELBV2ListenerRule_forwardWeighted
--- PASS: TestAccELBV2Listener_Network_basic (239.89s)
=== CONT  TestAccELBV2ListenerRule_conditionMultiple
--- PASS: TestAccELBV2ListenerRule_forwardWeighted (243.00s)
=== CONT  TestAccELBV2ListenerRule_disappears
--- PASS: TestAccELBV2ListenerRule_conditionMultiple (220.17s)
=== CONT  TestAccELBV2Listener_Gateway_basic
--- PASS: TestAccELBV2ListenerRule_disappears (220.00s)
=== CONT  TestAccELBV2Listener_EmptyDefaultAction/redirect
=== CONT  TestAccELBV2Listener_EmptyDefaultAction/forward
=== CONT  TestAccELBV2Listener_EmptyDefaultAction/fixed-response
=== CONT  TestAccELBV2Listener_EmptyDefaultAction/authenticate-oidc
=== CONT  TestAccELBV2Listener_EmptyDefaultAction/authenticate-cognito
--- PASS: TestAccELBV2Listener_EmptyDefaultAction (0.00s)
    --- PASS: TestAccELBV2Listener_EmptyDefaultAction/redirect (3.18s)
    --- PASS: TestAccELBV2Listener_EmptyDefaultAction/forward (3.09s)
    --- PASS: TestAccELBV2Listener_EmptyDefaultAction/fixed-response (3.09s)
    --- PASS: TestAccELBV2Listener_EmptyDefaultAction/authenticate-oidc (3.09s)
    --- PASS: TestAccELBV2Listener_EmptyDefaultAction/authenticate-cognito (3.09s)
=== CONT  TestAccELBV2ListenerRule_EmptyAction/forward
=== CONT  TestAccELBV2ListenerRule_EmptyAction/redirect
--- PASS: TestAccELBV2Listener_Gateway_basic (206.97s)
=== CONT  TestAccELBV2ListenerRule_EmptyAction/fixed-response
=== CONT  TestAccELBV2ListenerRule_EmptyAction/authenticate-cognito
=== CONT  TestAccELBV2ListenerRule_EmptyAction/authenticate-oidc
--- PASS: TestAccELBV2ListenerRule_EmptyAction (0.00s)
    --- PASS: TestAccELBV2ListenerRule_EmptyAction/forward (3.10s)
    --- PASS: TestAccELBV2ListenerRule_EmptyAction/redirect (3.30s)
    --- PASS: TestAccELBV2ListenerRule_EmptyAction/fixed-response (3.40s)
    --- PASS: TestAccELBV2ListenerRule_EmptyAction/authenticate-cognito (3.56s)
    --- PASS: TestAccELBV2ListenerRule_EmptyAction/authenticate-oidc (3.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	5250.537s

@gdavison gdavison force-pushed the b-elbv2-unexpected-diff branch from 3bc1a49 to 7a3920f Compare February 7, 2024 21:26
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@gdavison gdavison merged commit bfcae6a into main Feb 7, 2024
37 checks passed
@gdavison gdavison deleted the b-elbv2-unexpected-diff branch February 7, 2024 22:15
@github-actions github-actions bot added this to the v5.36.0 milestone Feb 7, 2024
github-actions bot pushed a commit that referenced this pull request Feb 7, 2024
Update CHANGELOG.md for #35678
36b2390
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024

This functionality has been released in v5.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Feb 10, 2024
This was referenced Feb 14, 2024
Closed
Merged
VenelinMartinov added a commit to pulumi/pulumi-aws that referenced this pull request Feb 14, 2024
@VenelinMartinov
Revert upstream changes triggering LB panic (#3426)
32a25bf 
This reverts the following upstream PRs:
hashicorp/terraform-provider-aws#35671
hashicorp/terraform-provider-aws#35678
as a quick fix to mitigate
#3421 until we root-cause it.

Details on my findings so far:
#3421 (comment)
It looks to me like the issue originates somewhere in our handling of
nulls/empty in the bridge, so seems unlikely to get fixed today.

It also adds a test for LB listeners. I've verified that the test
triggers the panic without the patches and that the patches resolve it.
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.36.0
Development

Successfully merging this pull request may close these issues.

[Bug]: unexpected plan diff on aws_lb_listener when upgrading from 5.34.0 to 5.35.0
3 participants
@gdavison @ewbankkit @justinretzolk