Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: Migrate cloudsearch resources to AWS SDK for Go v2 #35764

Merged
merged 11 commits into from
Feb 12, 2024

Conversation

ewbankkit
Copy link
Contributor

Description

Ibid.

Relations

Relates #32976.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccCloudSearch' PKG=cloudsearch ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudsearch/... -v -count 1 -parallel 2  -run=TestAccCloudSearch -timeout 360m
=== RUN   TestAccCloudSearchDomainServiceAccessPolicy_basic
=== PAUSE TestAccCloudSearchDomainServiceAccessPolicy_basic
=== RUN   TestAccCloudSearchDomainServiceAccessPolicy_update
=== PAUSE TestAccCloudSearchDomainServiceAccessPolicy_update
=== RUN   TestAccCloudSearchDomain_basic
=== PAUSE TestAccCloudSearchDomain_basic
=== RUN   TestAccCloudSearchDomain_disappears
=== PAUSE TestAccCloudSearchDomain_disappears
=== RUN   TestAccCloudSearchDomain_indexFields
=== PAUSE TestAccCloudSearchDomain_indexFields
=== RUN   TestAccCloudSearchDomain_sourceFields
=== PAUSE TestAccCloudSearchDomain_sourceFields
=== RUN   TestAccCloudSearchDomain_update
=== PAUSE TestAccCloudSearchDomain_update
=== CONT  TestAccCloudSearchDomainServiceAccessPolicy_basic
=== CONT  TestAccCloudSearchDomain_indexFields
--- PASS: TestAccCloudSearchDomainServiceAccessPolicy_basic (1809.10s)
=== CONT  TestAccCloudSearchDomain_update
--- PASS: TestAccCloudSearchDomain_indexFields (2594.00s)
=== CONT  TestAccCloudSearchDomain_sourceFields
--- PASS: TestAccCloudSearchDomain_update (2058.34s)
=== CONT  TestAccCloudSearchDomain_basic
--- PASS: TestAccCloudSearchDomain_sourceFields (1633.14s)
=== CONT  TestAccCloudSearchDomain_disappears
--- PASS: TestAccCloudSearchDomain_basic (704.65s)
=== CONT  TestAccCloudSearchDomainServiceAccessPolicy_update
--- PASS: TestAccCloudSearchDomain_disappears (824.51s)
--- PASS: TestAccCloudSearchDomainServiceAccessPolicy_update (2462.50s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudsearch	7045.461s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cloudsearch Issues and PRs that pertain to the cloudsearch service. sweeper Pertains to changes to or issues with the sweeper. client-connections Pertains to the AWS Client and service connections. flex Pertains to FLatteners and EXpanders. generators Relates to code generators. labels Feb 12, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 12, 2024
@ewbankkit ewbankkit merged commit 0bac348 into main Feb 12, 2024
67 checks passed
@ewbankkit ewbankkit deleted the td-migrate-cloudsearch-to-aws-sdk-v2 branch February 12, 2024 14:52
@github-actions github-actions bot added this to the v5.37.0 milestone Feb 12, 2024
github-actions bot pushed a commit that referenced this pull request Feb 12, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc TESTARGS='-run=TestAccCloudSearch' PKG=cloudsearch
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cloudsearch/... -v -count 1 -parallel 20  -run=TestAccCloudSearch -timeout 360m
go: downloading github.com/aws/aws-sdk-go-v2/service/cloudsearch v1.20.6
        === RUN   TestAccCloudSearchDomainServiceAccessPolicy_basic
=== PAUSE TestAccCloudSearchDomainServiceAccessPolicy_basic
=== RUN   TestAccCloudSearchDomainServiceAccessPolicy_update
=== PAUSE TestAccCloudSearchDomainServiceAccessPolicy_update
=== RUN   TestAccCloudSearchDomain_basic
=== PAUSE TestAccCloudSearchDomain_basic
=== RUN   TestAccCloudSearchDomain_disappears
=== PAUSE TestAccCloudSearchDomain_disappears
=== RUN   TestAccCloudSearchDomain_indexFields
=== PAUSE TestAccCloudSearchDomain_indexFields
=== RUN   TestAccCloudSearchDomain_sourceFields
=== PAUSE TestAccCloudSearchDomain_sourceFields
=== RUN   TestAccCloudSearchDomain_update
=== PAUSE TestAccCloudSearchDomain_update
=== CONT  TestAccCloudSearchDomainServiceAccessPolicy_basic
=== CONT  TestAccCloudSearchDomain_update
=== CONT  TestAccCloudSearchDomain_sourceFields
=== CONT  TestAccCloudSearchDomain_indexFields
=== CONT  TestAccCloudSearchDomain_disappears
=== CONT  TestAccCloudSearchDomain_basic
=== CONT  TestAccCloudSearchDomainServiceAccessPolicy_update
--- PASS: TestAccCloudSearchDomain_basic (742.22s)
--- PASS: TestAccCloudSearchDomain_disappears (885.58s)
--- PASS: TestAccCloudSearchDomain_sourceFields (1599.18s)
--- PASS: TestAccCloudSearchDomain_indexFields (1908.37s)
--- PASS: TestAccCloudSearchDomain_update (2136.54s)
--- PASS: TestAccCloudSearchDomainServiceAccessPolicy_basic (2282.50s)
--- PASS: TestAccCloudSearchDomainServiceAccessPolicy_update (2470.36s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudsearch        2477.399s

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 15, 2024
Copy link

This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

ewbankkit added a commit that referenced this pull request Feb 27, 2024
…ddress or nil pointer dereference' in sweeper (#35764).
@ewbankkit ewbankkit mentioned this pull request Feb 27, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
@justinretzolk justinretzolk added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. flex Pertains to FLatteners and EXpanders. generators Relates to code generators. service/cloudsearch Issues and PRs that pertain to the cloudsearch service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants