r/aws_vpn_gateway: Fix acceptance tests

[ewbankkit]

Description

Address failing aws_vpn_gateway acceptance test by introducing waiters for Create and Delete.
Fixes:

=== RUN   TestAccSiteVPNGateway_disappears
=== PAUSE TestAccSiteVPNGateway_disappears
=== CONT  TestAccSiteVPNGateway_disappears
    vpnsite_gateway_test.go:141: Step 1/1 error: Error running apply: exit status 1
        Error: creating EC2 VPN Gateway: attaching EC2 VPN Gateway (vgw-04d50bfe2d2e5397e) to VPC (vpc-03def81e63e9deaa0): InvalidParameterValue: This call cannot be completed because there is a conflicting pending workflow for vgw-04d50bfe2d2e5397e
          status code: 400, request id: d728e6eb-490a-4a41-b627-1d676d2ba74c
          with aws_vpn_gateway.test,
          on terraform_plugin_test.tf line 20, in resource "aws_vpn_gateway" "test":
          20: resource "aws_vpn_gateway" "test" {
    testing_new.go:91: Error running post-test destroy, there may be dangling resources: exit status 1
        Error: deleting EC2 VPN Gateway (vgw-04d50bfe2d2e5397e): detaching EC2 VPN Gateway (vgw-04d50bfe2d2e5397e) from VPC (vpc-03def81e63e9deaa0): InvalidParameterValue: This call cannot be completed because there is a conflicting pending workflow for vgw-04d50bfe2d2e5397e
          status code: 400, request id: bddf1e96-3ffe-4d9a-9e66-636483f643dd
--- FAIL: TestAccSiteVPNGateway_disappears (71.94s)

Relations

Relates #35747.

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccSiteVPNGateway_' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccSiteVPNGateway_ -timeout 360m
=== RUN   TestAccSiteVPNGateway_basic
=== PAUSE TestAccSiteVPNGateway_basic
=== RUN   TestAccSiteVPNGateway_withAvailabilityZoneSetToState
=== PAUSE TestAccSiteVPNGateway_withAvailabilityZoneSetToState
=== RUN   TestAccSiteVPNGateway_amazonSideASN
=== PAUSE TestAccSiteVPNGateway_amazonSideASN
=== RUN   TestAccSiteVPNGateway_disappears
=== PAUSE TestAccSiteVPNGateway_disappears
=== RUN   TestAccSiteVPNGateway_reattach
=== PAUSE TestAccSiteVPNGateway_reattach
=== RUN   TestAccSiteVPNGateway_tags
=== PAUSE TestAccSiteVPNGateway_tags
=== CONT  TestAccSiteVPNGateway_basic
=== CONT  TestAccSiteVPNGateway_disappears
=== CONT  TestAccSiteVPNGateway_tags
--- PASS: TestAccSiteVPNGateway_tags (139.06s)
=== CONT  TestAccSiteVPNGateway_amazonSideASN
--- PASS: TestAccSiteVPNGateway_disappears (156.22s)
=== CONT  TestAccSiteVPNGateway_reattach
--- PASS: TestAccSiteVPNGateway_basic (266.08s)
=== CONT  TestAccSiteVPNGateway_withAvailabilityZoneSetToState
--- PASS: TestAccSiteVPNGateway_amazonSideASN (130.85s)
--- PASS: TestAccSiteVPNGateway_withAvailabilityZoneSetToState (127.91s)
--- PASS: TestAccSiteVPNGateway_reattach (360.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	528.175s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.