Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glue crawler: treat "Cannot update Crawler while running..." as RetryableError #35913

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

szemek
Copy link
Contributor

@szemek szemek commented Feb 21, 2024

Improvement for updating crawlers

Description

There are situations when we try to update running crawlers. It would be useful to treat as retryable error and repeat until crawler is ready to be updated. Provider allows to set retry_mode and max_retries https://registry.terraform.io/providers/hashicorp/aws/latest/docs

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/glue Issues and PRs that pertain to the glue service. size/XS Managed by automation to categorize the size of a PR. labels Feb 21, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 21, 2024
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 7, 2024
@szemek szemek force-pushed the f-retryable-error-for-running-crawler branch from c74bbd5 to f6300fe Compare July 11, 2024 06:32
@szemek szemek requested a review from a team as a code owner July 11, 2024 06:32
@szemek szemek force-pushed the f-retryable-error-for-running-crawler branch from f6300fe to e5107e3 Compare July 17, 2024 12:19
@szemek szemek force-pushed the f-retryable-error-for-running-crawler branch from e5107e3 to 9913ab5 Compare September 6, 2024 05:59
@szemek szemek force-pushed the f-retryable-error-for-running-crawler branch from 9913ab5 to 272744b Compare October 3, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/glue Issues and PRs that pertain to the glue service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants