-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Create own struct to be able to add omitempty json tag on attributes #35950
Merged
jar-b
merged 13 commits into
hashicorp:main
from
stromp:b-filter_null_values_so_AWS_does_not_complain
Jul 30, 2024
Merged
Bug: Create own struct to be able to add omitempty json tag on attributes #35950
jar-b
merged 13 commits into
hashicorp:main
from
stromp:b-filter_null_values_so_AWS_does_not_complain
Jul 30, 2024
Commits on Jun 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5e9b22e - Browse repository at this point
Copy the full SHA 5e9b22eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c39c26 - Browse repository at this point
Copy the full SHA 1c39c26View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2337370 - Browse repository at this point
Copy the full SHA 2337370View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ce87b3 - Browse repository at this point
Copy the full SHA 9ce87b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for be9730b - Browse repository at this point
Copy the full SHA be9730bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f57402d - Browse repository at this point
Copy the full SHA f57402dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e30c2e - Browse repository at this point
Copy the full SHA 5e30c2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 432903e - Browse repository at this point
Copy the full SHA 432903eView commit details -
Configuration menu - View commit details
-
Copy full SHA for a9e5047 - Browse repository at this point
Copy the full SHA a9e5047View commit details -
Configuration menu - View commit details
-
Copy full SHA for f416856 - Browse repository at this point
Copy the full SHA f416856View commit details
Commits on Jul 30, 2024
-
r/aws_ssm_patch_baseline: use RemoveEmptyFields helper
This generic helper function strips nil values, empty arrays, and empty objects from the provided byte slice, preventing nil values from the AWS API response from being stored in the computed `json` attribute.
Configuration menu - View commit details
-
Copy full SHA for d39ce44 - Browse repository at this point
Copy the full SHA d39ce44View commit details -
r/aws_ssm_patch_baseline(test): add approval rule with empty response…
… case This test verifies that nil values returned in the ApprovalRule response are appropriately scrubbed from the `json` attribute. ```console % make testacc PKG=ssm TESTS=TestAccSSMPatchBaseline_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.2 test ./internal/service/ssm/... -v -count 1 -parallel 20 -run='TestAccSSMPatchBaseline_' -timeout 360m --- PASS: TestAccSSMPatchBaseline_disappears (31.31s) === CONT TestAccSSMPatchBaseline_tags_null --- PASS: TestAccSSMPatchBaseline_rejectPatchesAction (37.77s) === CONT TestAccSSMPatchBaseline_tags_DefaultTags_providerOnly --- PASS: TestAccSSMPatchBaseline_approvedPatchesNonSec (39.94s) === CONT TestAccSSMPatchBaseline_tags_DefaultTags_updateToProviderOnly --- PASS: TestAccSSMPatchBaseline_tags_DefaultTags_nullOverlappingResourceTag (43.85s) === CONT TestAccSSMPatchBaseline_tags_DefaultTags_updateToResourceOnly --- PASS: TestAccSSMPatchBaseline_tags_DefaultTags_nullNonOverlappingResourceTag (43.91s) === CONT TestAccSSMPatchBaseline_tags_DefaultTags_overlapping --- PASS: TestAccSSMPatchBaseline_tags_DefaultTags_emptyProviderOnlyTag (45.51s) === CONT TestAccSSMPatchBaseline_tags_EmptyTag_OnUpdate_Replace --- PASS: TestAccSSMPatchBaseline_tags_ComputedTag_OnCreate (49.76s) --- PASS: TestAccSSMPatchBaseline_tags_DefaultTags_emptyResourceTag (50.56s) --- PASS: TestAccSSMPatchBaseline_operatingSystem (56.32s) --- PASS: TestAccSSMPatchBaseline_sources (59.38s) --- PASS: TestAccSSMPatchBaseline_approveUntilDateParam (59.69s) --- PASS: TestAccSSMPatchBaseline_approvalRuleEmpty (67.48s) --- PASS: TestAccSSMPatchBaseline_basic (67.74s) --- PASS: TestAccSSMPatchBaseline_tags_AddOnUpdate (68.98s) --- PASS: TestAccSSMPatchBaseline_tags_ComputedTag_OnUpdate_Replace (70.36s) --- PASS: TestAccSSMPatchBaseline_tags_EmptyTag_OnCreate (72.92s) --- PASS: TestAccSSMPatchBaseline_tags_null (42.16s) --- PASS: TestAccSSMPatchBaseline_tags_ComputedTag_OnUpdate_Add (75.00s) --- PASS: TestAccSSMPatchBaseline_tags_EmptyTag_OnUpdate_Add (85.97s) --- PASS: TestAccSSMPatchBaseline_tags_DefaultTags_updateToResourceOnly (42.60s) --- PASS: TestAccSSMPatchBaseline_tags_DefaultTags_updateToProviderOnly (46.77s) --- PASS: TestAccSSMPatchBaseline_tags_EmptyTag_OnUpdate_Replace (41.84s) --- PASS: TestAccSSMPatchBaseline_tags_DefaultTags_nonOverlapping (89.47s) --- PASS: TestAccSSMPatchBaseline_tags (100.06s) --- PASS: TestAccSSMPatchBaseline_tags_DefaultTags_overlapping (59.82s) --- PASS: TestAccSSMPatchBaseline_tags_DefaultTags_providerOnly (77.53s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ssm 121.254s ```
Configuration menu - View commit details
-
Copy full SHA for 5add456 - Browse repository at this point
Copy the full SHA 5add456View commit details -
Configuration menu - View commit details
-
Copy full SHA for aee1403 - Browse repository at this point
Copy the full SHA aee1403View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.