Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Create own struct to be able to add omitempty json tag on attributes #35950

Merged

Commits on Jun 6, 2024

  1. Configuration menu
    Copy the full SHA
    5e9b22e View commit details
    Browse the repository at this point in the history
  2. fixing formatting

    stromp committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    1c39c26 View commit details
    Browse the repository at this point in the history
  3. Reverting accidental change

    stromp committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    2337370 View commit details
    Browse the repository at this point in the history
  4. reverting more

    stromp committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    9ce87b3 View commit details
    Browse the repository at this point in the history
  5. Fix return

    stromp committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    be9730b View commit details
    Browse the repository at this point in the history
  6. Update patch_baseline_test.go

    fix indenting
    stromp committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    f57402d View commit details
    Browse the repository at this point in the history
  7. fix formatting

    stromp committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    5e30c2e View commit details
    Browse the repository at this point in the history
  8. remove empty import

    stromp committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    432903e View commit details
    Browse the repository at this point in the history
  9. fixing for v2

    stromp committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    a9e5047 View commit details
    Browse the repository at this point in the history
  10. FIx

    stromp committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    f416856 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. r/aws_ssm_patch_baseline: use RemoveEmptyFields helper

    This generic helper function strips nil values, empty arrays, and empty objects from the provided byte slice, preventing nil values from the AWS API response from being stored in the computed `json` attribute.
    jar-b committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    d39ce44 View commit details
    Browse the repository at this point in the history
  2. r/aws_ssm_patch_baseline(test): add approval rule with empty response…

    … case
    
    This test verifies that nil values returned in the ApprovalRule response are appropriately scrubbed from the `json` attribute.
    
    ```console
    % make testacc PKG=ssm TESTS=TestAccSSMPatchBaseline_
    make: Verifying source code with gofmt...
    ==> Checking that code complies with gofmt requirements...
    TF_ACC=1 go1.22.2 test ./internal/service/ssm/... -v -count 1 -parallel 20 -run='TestAccSSMPatchBaseline_'  -timeout 360m
    
    --- PASS: TestAccSSMPatchBaseline_disappears (31.31s)
    === CONT  TestAccSSMPatchBaseline_tags_null
    --- PASS: TestAccSSMPatchBaseline_rejectPatchesAction (37.77s)
    === CONT  TestAccSSMPatchBaseline_tags_DefaultTags_providerOnly
    --- PASS: TestAccSSMPatchBaseline_approvedPatchesNonSec (39.94s)
    === CONT  TestAccSSMPatchBaseline_tags_DefaultTags_updateToProviderOnly
    --- PASS: TestAccSSMPatchBaseline_tags_DefaultTags_nullOverlappingResourceTag (43.85s)
    === CONT  TestAccSSMPatchBaseline_tags_DefaultTags_updateToResourceOnly
    --- PASS: TestAccSSMPatchBaseline_tags_DefaultTags_nullNonOverlappingResourceTag (43.91s)
    === CONT  TestAccSSMPatchBaseline_tags_DefaultTags_overlapping
    --- PASS: TestAccSSMPatchBaseline_tags_DefaultTags_emptyProviderOnlyTag (45.51s)
    === CONT  TestAccSSMPatchBaseline_tags_EmptyTag_OnUpdate_Replace
    --- PASS: TestAccSSMPatchBaseline_tags_ComputedTag_OnCreate (49.76s)
    --- PASS: TestAccSSMPatchBaseline_tags_DefaultTags_emptyResourceTag (50.56s)
    --- PASS: TestAccSSMPatchBaseline_operatingSystem (56.32s)
    --- PASS: TestAccSSMPatchBaseline_sources (59.38s)
    --- PASS: TestAccSSMPatchBaseline_approveUntilDateParam (59.69s)
    --- PASS: TestAccSSMPatchBaseline_approvalRuleEmpty (67.48s)
    --- PASS: TestAccSSMPatchBaseline_basic (67.74s)
    --- PASS: TestAccSSMPatchBaseline_tags_AddOnUpdate (68.98s)
    --- PASS: TestAccSSMPatchBaseline_tags_ComputedTag_OnUpdate_Replace (70.36s)
    --- PASS: TestAccSSMPatchBaseline_tags_EmptyTag_OnCreate (72.92s)
    --- PASS: TestAccSSMPatchBaseline_tags_null (42.16s)
    --- PASS: TestAccSSMPatchBaseline_tags_ComputedTag_OnUpdate_Add (75.00s)
    --- PASS: TestAccSSMPatchBaseline_tags_EmptyTag_OnUpdate_Add (85.97s)
    --- PASS: TestAccSSMPatchBaseline_tags_DefaultTags_updateToResourceOnly (42.60s)
    --- PASS: TestAccSSMPatchBaseline_tags_DefaultTags_updateToProviderOnly (46.77s)
    --- PASS: TestAccSSMPatchBaseline_tags_EmptyTag_OnUpdate_Replace (41.84s)
    --- PASS: TestAccSSMPatchBaseline_tags_DefaultTags_nonOverlapping (89.47s)
    --- PASS: TestAccSSMPatchBaseline_tags (100.06s)
    --- PASS: TestAccSSMPatchBaseline_tags_DefaultTags_overlapping (59.82s)
    --- PASS: TestAccSSMPatchBaseline_tags_DefaultTags_providerOnly (77.53s)
    PASS
    ok      github.com/hashicorp/terraform-provider-aws/internal/service/ssm        121.254s
    ```
    jar-b committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    5add456 View commit details
    Browse the repository at this point in the history
  3. chore: changelog

    jar-b committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    aee1403 View commit details
    Browse the repository at this point in the history