Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of nodejs14.x runtime for service/lambda acceptance tests #35967

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Replace use of nodejs14.x runtime for service/lambda acceptance tests #35967

merged 1 commit into from
Feb 26, 2024

Conversation

surajsubramanian
Copy link
Contributor

@surajsubramanian surajsubramanian commented Feb 24, 2024

Description

Relations

Relates #35939

Output from Acceptance Testing

function_url_data_source_test.go
> make testacc TESTS=TestAccLambdaFunctionURLDataSource_basic PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaFunctionURLDataSource_basic'  -timeout 360m
=== RUN   TestAccLambdaFunctionURLDataSource_basic
=== PAUSE TestAccLambdaFunctionURLDataSource_basic
=== CONT  TestAccLambdaFunctionURLDataSource_basic
--- PASS: TestAccLambdaFunctionURLDataSource_basic (36.11s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     43.486s
function_url_test.go
> make testacc TESTS=TestAccLambdaFunctionURL_ PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaFunctionURL_'  -timeout 360m
=== RUN   TestAccLambdaFunctionURL_basic
=== PAUSE TestAccLambdaFunctionURL_basic
=== RUN   TestAccLambdaFunctionURL_Cors
=== PAUSE TestAccLambdaFunctionURL_Cors
=== RUN   TestAccLambdaFunctionURL_Alias
=== PAUSE TestAccLambdaFunctionURL_Alias
=== RUN   TestAccLambdaFunctionURL_TwoURLs
=== PAUSE TestAccLambdaFunctionURL_TwoURLs
=== RUN   TestAccLambdaFunctionURL_invokeMode
=== PAUSE TestAccLambdaFunctionURL_invokeMode
=== CONT  TestAccLambdaFunctionURL_basic
=== CONT  TestAccLambdaFunctionURL_TwoURLs
=== CONT  TestAccLambdaFunctionURL_Cors
=== CONT  TestAccLambdaFunctionURL_Alias
=== CONT  TestAccLambdaFunctionURL_invokeMode
--- PASS: TestAccLambdaFunctionURL_Alias (52.04s)
--- PASS: TestAccLambdaFunctionURL_TwoURLs (63.28s)
--- PASS: TestAccLambdaFunctionURL_basic (65.49s)
--- PASS: TestAccLambdaFunctionURL_Cors (67.17s)
--- PASS: TestAccLambdaFunctionURL_invokeMode (80.02s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     87.416s
invocation_test.go
> make testacc TESTS=TestAccLambdaInvocation_terraformKey PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaInvocation_terraformKey'  -timeout 360m
=== RUN   TestAccLambdaInvocation_terraformKey
=== PAUSE TestAccLambdaInvocation_terraformKey
=== CONT  TestAccLambdaInvocation_terraformKey
--- PASS: TestAccLambdaInvocation_terraformKey (34.60s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     42.206s
function_test.go
> make testacc TESTS=TestAccLambdaFunction_versionedUpdate PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaFunction_versionedUpdate'  -timeout 360m
=== RUN   TestAccLambdaFunction_versionedUpdate
=== PAUSE TestAccLambdaFunction_versionedUpdate
=== CONT  TestAccLambdaFunction_versionedUpdate
--- PASS: TestAccLambdaFunction_versionedUpdate (87.30s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     94.633s
layer_version_test.go
> make testacc TESTS=TestAccLambdaLayerVersion_skipDestroy PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaLayerVersion_skipDestroy'  -timeout 360m
=== RUN   TestAccLambdaLayerVersion_skipDestroy
=== PAUSE TestAccLambdaLayerVersion_skipDestroy
=== CONT  TestAccLambdaLayerVersion_skipDestroy
--- PASS: TestAccLambdaLayerVersion_skipDestroy (33.57s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lambda     40.939s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lambda Issues and PRs that pertain to the lambda service. labels Feb 24, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 24, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Feb 26, 2024
@ewbankkit ewbankkit self-assigned this Feb 26, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 26, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLambdaFunction_versionedUpdate\|TestAccLambdaFunctionURLDataSource_basic\|TestAccLambdaFunctionURL_\|TestAccLambdaInvocation_lifecycle_scopeCreateOnlyToCRUD\|TestAccLambdaLayerVersion_skipDestroy' PKG=lambda ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 3  -run=TestAccLambdaFunction_versionedUpdate\|TestAccLambdaFunctionURLDataSource_basic\|TestAccLambdaFunctionURL_\|TestAccLambdaInvocation_lifecycle_scopeCreateOnlyToCRUD\|TestAccLambdaLayerVersion_skipDestroy -timeout 360m
=== RUN   TestAccLambdaFunction_versionedUpdate
=== PAUSE TestAccLambdaFunction_versionedUpdate
=== RUN   TestAccLambdaFunctionURLDataSource_basic
=== PAUSE TestAccLambdaFunctionURLDataSource_basic
=== RUN   TestAccLambdaFunctionURL_basic
=== PAUSE TestAccLambdaFunctionURL_basic
=== RUN   TestAccLambdaFunctionURL_Cors
=== PAUSE TestAccLambdaFunctionURL_Cors
=== RUN   TestAccLambdaFunctionURL_Alias
=== PAUSE TestAccLambdaFunctionURL_Alias
=== RUN   TestAccLambdaFunctionURL_TwoURLs
=== PAUSE TestAccLambdaFunctionURL_TwoURLs
=== RUN   TestAccLambdaFunctionURL_invokeMode
=== PAUSE TestAccLambdaFunctionURL_invokeMode
=== RUN   TestAccLambdaInvocation_lifecycle_scopeCreateOnlyToCRUD
=== PAUSE TestAccLambdaInvocation_lifecycle_scopeCreateOnlyToCRUD
=== RUN   TestAccLambdaLayerVersion_skipDestroy
=== PAUSE TestAccLambdaLayerVersion_skipDestroy
=== CONT  TestAccLambdaFunction_versionedUpdate
=== CONT  TestAccLambdaFunctionURL_TwoURLs
=== CONT  TestAccLambdaFunctionURL_Cors
--- PASS: TestAccLambdaFunctionURL_TwoURLs (51.07s)
=== CONT  TestAccLambdaInvocation_lifecycle_scopeCreateOnlyToCRUD
--- PASS: TestAccLambdaFunctionURL_Cors (79.77s)
=== CONT  TestAccLambdaLayerVersion_skipDestroy
--- PASS: TestAccLambdaInvocation_lifecycle_scopeCreateOnlyToCRUD (50.71s)
=== CONT  TestAccLambdaFunctionURL_basic
--- PASS: TestAccLambdaLayerVersion_skipDestroy (39.31s)
=== CONT  TestAccLambdaFunctionURLDataSource_basic
--- PASS: TestAccLambdaFunction_versionedUpdate (120.05s)
=== CONT  TestAccLambdaFunctionURL_Alias
--- PASS: TestAccLambdaFunctionURL_basic (35.42s)
=== CONT  TestAccLambdaFunctionURL_invokeMode
--- PASS: TestAccLambdaFunctionURLDataSource_basic (32.75s)
--- PASS: TestAccLambdaFunctionURL_Alias (42.13s)
--- PASS: TestAccLambdaFunctionURL_invokeMode (67.63s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	216.572s

@ewbankkit
Copy link
Contributor

@surajsubramanian Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit fa2db56 into hashicorp:main Feb 26, 2024
131 checks passed
@github-actions github-actions bot added this to the v5.39.0 milestone Feb 26, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 1, 2024
Copy link

github-actions bot commented Mar 1, 2024

This functionality has been released in v5.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@surajsubramanian surajsubramanian deleted the b-lambda_replace-nodejs14 branch March 1, 2024 12:59
Copy link

github-actions bot commented Apr 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/lambda Issues and PRs that pertain to the lambda service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants