Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech debt: Migrate cognitoidentity resources to AWS SDK for Go v2 #36100

Merged
merged 14 commits into from
Mar 8, 2024
Prev Previous commit
Next Next commit
cognitoidentity: add endpoint id constant, update partition pre checks
  • Loading branch information
jar-b committed Mar 7, 2024
commit f93a1c12e73c0eb7862813be6265d869249ef317
12 changes: 6 additions & 6 deletions internal/service/cognitoidentity/pool_data_source_test.go
Original file line number Diff line number Diff line change
@@ -29,7 +29,7 @@ func TestAccCognitoIdentityPoolDataSource_basic(t *testing.T) {
resource.ParallelTest(t, resource.TestCase{
PreCheck: func() {
acctest.PreCheck(ctx, t)
acctest.PreCheckPartitionHasService(t, cognitoidentity.ServiceID)
acctest.PreCheckPartitionHasService(t, names.CognitoIdentityEndpointID)
testAccPreCheck(ctx, t)
},
ErrorCheck: acctest.ErrorCheck(t, names.CognitoIdentityServiceID),
@@ -65,7 +65,7 @@ func TestAccCognitoIdentityPoolDataSource_openidConnectProviderARNs(t *testing.T
resource.ParallelTest(t, resource.TestCase{
PreCheck: func() {
acctest.PreCheck(ctx, t)
acctest.PreCheckPartitionHasService(t, cognitoidentity.ServiceID)
acctest.PreCheckPartitionHasService(t, names.CognitoIdentityEndpointID)
testAccPreCheck(ctx, t)
},
ErrorCheck: acctest.ErrorCheck(t, names.CognitoIdentityServiceID),
@@ -99,7 +99,7 @@ func TestAccCognitoIdentityPoolDataSource_cognitoIdentityProviders(t *testing.T)
resource.ParallelTest(t, resource.TestCase{
PreCheck: func() {
acctest.PreCheck(ctx, t)
acctest.PreCheckPartitionHasService(t, cognitoidentity.ServiceID)
acctest.PreCheckPartitionHasService(t, names.CognitoIdentityEndpointID)
testAccPreCheck(ctx, t)
},
ErrorCheck: acctest.ErrorCheck(t, names.CognitoIdentityServiceID),
@@ -134,7 +134,7 @@ func TestAccCognitoIdentityPoolDataSource_samlProviderARNs(t *testing.T) {
resource.ParallelTest(t, resource.TestCase{
PreCheck: func() {
acctest.PreCheck(ctx, t)
acctest.PreCheckPartitionHasService(t, cognitoidentity.ServiceID)
acctest.PreCheckPartitionHasService(t, names.CognitoIdentityEndpointID)
testAccPreCheck(ctx, t)
},
ErrorCheck: acctest.ErrorCheck(t, names.CognitoIdentityServiceID),
@@ -168,7 +168,7 @@ func TestAccCognitoIdentityPoolDataSource_supportedLoginProviders(t *testing.T)
resource.ParallelTest(t, resource.TestCase{
PreCheck: func() {
acctest.PreCheck(ctx, t)
acctest.PreCheckPartitionHasService(t, cognitoidentity.ServiceID)
acctest.PreCheckPartitionHasService(t, names.CognitoIdentityEndpointID)
testAccPreCheck(ctx, t)
},
ErrorCheck: acctest.ErrorCheck(t, names.CognitoIdentityServiceID),
@@ -202,7 +202,7 @@ func TestAccCognitoIdentityPoolDataSource_tags(t *testing.T) {
resource.ParallelTest(t, resource.TestCase{
PreCheck: func() {
acctest.PreCheck(ctx, t)
acctest.PreCheckPartitionHasService(t, cognitoidentity.ServiceID)
acctest.PreCheckPartitionHasService(t, names.CognitoIdentityEndpointID)
testAccPreCheck(ctx, t)
},
ErrorCheck: acctest.ErrorCheck(t, names.CognitoIdentityServiceID),
1 change: 1 addition & 0 deletions names/names.go
Original file line number Diff line number Diff line change
@@ -40,6 +40,7 @@ const (
CodeArtifactEndpointID = "codeartifact"
CodeGuruReviewerEndpointID = "codeguru-reviewer"
CodeStarConnectionsEndpointID = "codestar-connections"
CognitoIdentityEndpointID = "cognito-identity"
ComprehendEndpointID = "comprehend"
ConfigServiceEndpointID = "config"
ECREndpointID = "api.ecr"
Loading