r/medialive_input: export destinations attribute

[chrisandrews7]

Description

Destination attributes are not currently exported on the medialive_input resource.
And with no data source available, its not possible to access the url, port, ip of the endpoints associated with the input.

References

• Go AWS SDK for InputDestinations
• AWS Docs

Output from Acceptance Testing

% make testacc TESTS=TestAccMediaLiveInput_ PKG=medialive 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/medialive/... -v -count 1 -parallel 20 -run='TestAccMediaLiveInput_'  -timeout 360m
=== RUN   TestAccMediaLiveInput_basic
=== PAUSE TestAccMediaLiveInput_basic
=== RUN   TestAccMediaLiveInput_destinations
=== PAUSE TestAccMediaLiveInput_destinations
=== RUN   TestAccMediaLiveInput_update
=== PAUSE TestAccMediaLiveInput_update
=== RUN   TestAccMediaLiveInput_updateTags
=== PAUSE TestAccMediaLiveInput_updateTags
=== RUN   TestAccMediaLiveInput_disappears
=== PAUSE TestAccMediaLiveInput_disappears
=== CONT  TestAccMediaLiveInput_basic
=== CONT  TestAccMediaLiveInput_disappears
=== CONT  TestAccMediaLiveInput_update
=== CONT  TestAccMediaLiveInput_destinations
=== CONT  TestAccMediaLiveInput_updateTags
--- PASS: TestAccMediaLiveInput_disappears (60.35s)
--- PASS: TestAccMediaLiveInput_basic (64.54s)
--- PASS: TestAccMediaLiveInput_destinations (76.24s)
--- PASS: TestAccMediaLiveInput_updateTags (87.87s)
--- PASS: TestAccMediaLiveInput_update (107.61s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/medialive  107.693s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[chrisandrews7]

@jar-b Sorry I know I've probably reached my quota for today ;)

[johnsonaj]

Hi @chrisandrews7 thank you for the contribution! After reviewing this resource it looks like adding a data source is the ideal approach to retrieve the destinations output.

the aws_medialive_input destination attribute has different values than what is returned by the output. Adding the additional attributes here would cause unexpected drift in the resource for any configured destinations.

I'll close out this PR with the addition of a data source for the input resource.

[chrisandrews7]

Yep absolutely makes sense. Thanks @johnsonaj

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.