Migrate LakeFormation Service to AWS Go SDKv2 #36362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
github-actions
bot
added
size/XL
terraform-aws-provider
bot
added
the
prioritized
|
Thank you for your contribution! 🚀 A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored. For additional information refer to the AWS SDK for Go Versions page in the contributor guide. |
johnsonaj
added
technical-debt
jar-b
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
LGTM 🎉
% make testacc TESTARGS="-run=TestAccLakeFormation" PKG=lakeformation
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lakeformation/... -v -count 1 -parallel 20 -run=TestAccLakeFormation -timeout 360m
--- PASS: TestAccLakeFormationResource_basic (17.49s)
--- PASS: TestAccLakeFormationResource_disappears (17.88s)
--- PASS: TestAccLakeFormationResourceDataSource_basic (18.04s)
--- PASS: TestAccLakeFormationResource_serviceLinkedRole (18.17s)
--- PASS: TestAccLakeFormationResource_hybridAccessEnabled (18.28s)
--- PASS: TestAccLakeFormationResource_updateRoleToRole (27.85s)
--- PASS: TestAccLakeFormationResource_updateSLRToRole (28.79s)
=== RUN TestAccLakeFormation_serial/PermissionsTableWithColumns/wildcardSelectPlus
permissions_test.go:793: Step 1/1 error: Error running apply: exit status 1
Error: reading Lake Formation permissions: operation error LakeFormation: ListPermissions, https response error StatusCode: 400, RequestID: 40fea2de-35be-46f2-96cf-fc839c53d
161, InvalidInputException: Invalid principal, arn: arn:aws:iam::727561393803:role/tf-acc-test-909699663469884911
with aws_lakeformation_permissions.test,
on terraform_plugin_test.tf line 66, in resource "aws_lakeformation_permissions" "test":
66: resource "aws_lakeformation_permissions" "test" {
--- FAIL: TestAccLakeFormation_serial (1096.20s)
--- PASS: TestAccLakeFormation_serial/PermissionsBasic (282.60s)
--- PASS: TestAccLakeFormation_serial/PermissionsBasic/databaseIAMAllowed (43.95s)
--- PASS: TestAccLakeFormation_serial/PermissionsBasic/databaseMultiple (20.09s)
--- PASS: TestAccLakeFormation_serial/PermissionsBasic/dataLocation (22.26s)
--- PASS: TestAccLakeFormation_serial/PermissionsBasic/lfTag (19.16s)
--- PASS: TestAccLakeFormation_serial/PermissionsBasic/lfTagPolicyMultiple (19.19s)
--- PASS: TestAccLakeFormation_serial/PermissionsBasic/database (19.78s)
--- PASS: TestAccLakeFormation_serial/PermissionsBasic/dataCellsFilter (17.77s)
--- PASS: TestAccLakeFormation_serial/PermissionsBasic/disappears (82.50s)
--- PASS: TestAccLakeFormation_serial/PermissionsBasic/lfTagPolicy (19.26s)
--- PASS: TestAccLakeFormation_serial/PermissionsBasic/basic (18.62s)
--- PASS: TestAccLakeFormation_serial/PermissionsTable (209.43s)
--- PASS: TestAccLakeFormation_serial/PermissionsTable/multipleRoles (21.45s)
--- PASS: TestAccLakeFormation_serial/PermissionsTable/selectOnly (21.22s)
--- PASS: TestAccLakeFormation_serial/PermissionsTable/wildcardSelectOnly (20.90s)
--- PASS: TestAccLakeFormation_serial/PermissionsTable/wildcardSelectPlus (21.08s)
--- PASS: TestAccLakeFormation_serial/PermissionsTable/basic (21.21s)
--- PASS: TestAccLakeFormation_serial/PermissionsTable/iamAllowed (42.72s)
--- PASS: TestAccLakeFormation_serial/PermissionsTable/implicit (20.14s)
--- PASS: TestAccLakeFormation_serial/PermissionsTable/selectPlus (21.09s)
--- PASS: TestAccLakeFormation_serial/PermissionsTable/wildcardNoSelect (19.62s)
--- PASS: TestAccLakeFormation_serial/ResourceLFTags (135.56s)
--- PASS: TestAccLakeFormation_serial/ResourceLFTags/table (22.26s)
--- PASS: TestAccLakeFormation_serial/ResourceLFTags/tableWithColumns (22.68s)
--- PASS: TestAccLakeFormation_serial/ResourceLFTags/basic (11.47s)
--- PASS: TestAccLakeFormation_serial/ResourceLFTags/database (20.95s)
--- PASS: TestAccLakeFormation_serial/ResourceLFTags/databaseMultipleTags (20.73s)
--- PASS: TestAccLakeFormation_serial/ResourceLFTags/disappears (12.56s)
--- PASS: TestAccLakeFormation_serial/ResourceLFTags/hierarchy (24.91s)
--- PASS: TestAccLakeFormation_serial/LFTags (79.40s)
--- PASS: TestAccLakeFormation_serial/LFTags/valuesOverFifty (25.03s)
--- PASS: TestAccLakeFormation_serial/LFTags/basic (12.81s)
--- PASS: TestAccLakeFormation_serial/LFTags/disappears (10.88s)
--- PASS: TestAccLakeFormation_serial/LFTags/tagKeyComplex (10.24s)
--- PASS: TestAccLakeFormation_serial/LFTags/values (20.44s)
--- PASS: TestAccLakeFormation_serial/DataLakeSettings (39.21s)
--- PASS: TestAccLakeFormation_serial/DataLakeSettings/basic (9.58s)
--- PASS: TestAccLakeFormation_serial/DataLakeSettings/disappears (10.38s)
--- PASS: TestAccLakeFormation_serial/DataLakeSettings/withoutCatalogId (9.67s)
--- PASS: TestAccLakeFormation_serial/DataLakeSettings/readOnlyAdmins (9.57s)
--- PASS: TestAccLakeFormation_serial/DataCellsFilter (41.46s)
--- PASS: TestAccLakeFormation_serial/DataCellsFilter/basic (15.50s)
--- PASS: TestAccLakeFormation_serial/DataCellsFilter/columnWildcard (12.76s)
--- PASS: TestAccLakeFormation_serial/DataCellsFilter/disappears (13.20s)
--- PASS: TestAccLakeFormation_serial/DataLakeSettingsDataSource (20.53s)
--- PASS: TestAccLakeFormation_serial/DataLakeSettingsDataSource/basic (10.17s)
--- PASS: TestAccLakeFormation_serial/DataLakeSettingsDataSource/readOnlyAdmins (10.36s)
--- PASS: TestAccLakeFormation_serial/PermissionsDataSource (169.78s)
--- PASS: TestAccLakeFormation_serial/PermissionsDataSource/dataLocation (23.04s)
--- PASS: TestAccLakeFormation_serial/PermissionsDataSource/lfTag (19.74s)
--- PASS: TestAccLakeFormation_serial/PermissionsDataSource/lfTagPolicy (19.85s)
--- PASS: TestAccLakeFormation_serial/PermissionsDataSource/table (22.51s)
--- PASS: TestAccLakeFormation_serial/PermissionsDataSource/tableWithColumns (21.89s)
--- PASS: TestAccLakeFormation_serial/PermissionsDataSource/basic (19.25s)
--- PASS: TestAccLakeFormation_serial/PermissionsDataSource/dataCellsFilter (22.34s)
--- PASS: TestAccLakeFormation_serial/PermissionsDataSource/database (21.16s)
--- FAIL: TestAccLakeFormation_serial/PermissionsTableWithColumns (118.24s)
--- PASS: TestAccLakeFormation_serial/PermissionsTableWithColumns/basic (44.28s)
--- PASS: TestAccLakeFormation_serial/PermissionsTableWithColumns/implicit (20.54s)
--- PASS: TestAccLakeFormation_serial/PermissionsTableWithColumns/wildcardExcludedColumns (19.25s)
--- PASS: TestAccLakeFormation_serial/PermissionsTableWithColumns/wildcardSelectOnly (21.41s)
--- FAIL: TestAccLakeFormation_serial/PermissionsTableWithColumns/wildcardSelectPlus (12.76s)
FAIL
FAIL github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation 1100.415sFailure was transient and passed on a second attempt. Non-blocking, but potentially a future enhancement to retry failures related to IAM propagation.
% make testacc TESTARGS="-run=TestAccLakeFormation_serial/PermissionsTableWithColumns/wildcardSelectPlus" PKG=lakeformation
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lakeformation/... -v -count 1 -parallel 20 -run=TestAccLakeFormation_serial/PermissionsTableWithColumns/wildcardSelectPlus -timeout 360m
=== RUN TestAccLakeFormation_serial
=== PAUSE TestAccLakeFormation_serial
=== CONT TestAccLakeFormation_serial
=== RUN TestAccLakeFormation_serial/PermissionsTableWithColumns
=== RUN TestAccLakeFormation_serial/PermissionsTableWithColumns/wildcardSelectPlus
--- PASS: TestAccLakeFormation_serial (22.11s)
--- PASS: TestAccLakeFormation_serial/PermissionsTableWithColumns (22.11s)
--- PASS: TestAccLakeFormation_serial/PermissionsTableWithColumns/wildcardSelectPlus (22.11s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/lakeformation 26.315s
jar-b
reviewed
Mar 14, 2024
Co-authored-by: Jared Baker <jar-b@users.noreply.github.com>
|
@jar-b found the error causing that intermittent failure☝🏾 |
|
This functionality has been released in v5.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
github-actions
bot
removed
the
prioritized
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relations
Closes #36179
References
Output from Acceptance Testing