Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AWS SDK for Go Migration] ECR (Elastic Container Registry) Service #36493

Merged
merged 37 commits into from
Mar 29, 2024
Merged

[AWS SDK for Go Migration] ECR (Elastic Container Registry) Service #36493

merged 37 commits into from
Mar 29, 2024

Conversation

alexknez
Copy link
Contributor

@alexknez alexknez commented Mar 20, 2024 •
edited by ewbankkit
Loading

Description

[AWS SDK for Go Migration] ECR (Elastic Container Registry) Service

Relations

Closes #36149.
Relates #32976.
Closes #35231.
Closes #35184.
Closes #6133.

References

Output from Acceptance Testing

% make testacc TESTARGS="-run=TestAccECR" PKG=ecr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ecr/... -v -count 1 -parallel 20  -run=TestAccECR -timeout 360m
=== RUN   TestAccECRAuthorizationTokenDataSource_basic
--- PASS: TestAccECRAuthorizationTokenDataSource_basic (22.42s)
=== RUN   TestAccECRImageDataSource_basic
=== PAUSE TestAccECRImageDataSource_basic
=== RUN   TestAccECRLifecyclePolicy_basic
=== PAUSE TestAccECRLifecyclePolicy_basic
=== RUN   TestAccECRLifecyclePolicy_ignoreEquivalent
=== PAUSE TestAccECRLifecyclePolicy_ignoreEquivalent
=== RUN   TestAccECRLifecyclePolicy_detectDiff
=== PAUSE TestAccECRLifecyclePolicy_detectDiff
=== RUN   TestAccECRPullThroughCacheRuleDataSource_basic
=== PAUSE TestAccECRPullThroughCacheRuleDataSource_basic
=== RUN   TestAccECRPullThroughCacheRuleDataSource_repositoryPrefixWithSlash
=== PAUSE TestAccECRPullThroughCacheRuleDataSource_repositoryPrefixWithSlash
=== RUN   TestAccECRPullThroughCacheRuleDataSource_credential
=== PAUSE TestAccECRPullThroughCacheRuleDataSource_credential
=== RUN   TestAccECRPullThroughCacheRule_basic
=== PAUSE TestAccECRPullThroughCacheRule_basic
=== RUN   TestAccECRPullThroughCacheRule_credentialARN
=== PAUSE TestAccECRPullThroughCacheRule_credentialARN
=== RUN   TestAccECRPullThroughCacheRule_disappears
=== PAUSE TestAccECRPullThroughCacheRule_disappears
=== RUN   TestAccECRPullThroughCacheRule_failWhenAlreadyExists
=== PAUSE TestAccECRPullThroughCacheRule_failWhenAlreadyExists
=== RUN   TestAccECRPullThroughCacheRule_repositoryPrefixWithSlash
=== PAUSE TestAccECRPullThroughCacheRule_repositoryPrefixWithSlash
=== RUN   TestAccECRRegistryPolicy_serial
=== PAUSE TestAccECRRegistryPolicy_serial
=== RUN   TestAccECRScanningConfiguration_serial
=== PAUSE TestAccECRScanningConfiguration_serial
=== RUN   TestAccECRReplicationConfiguration_serial
=== PAUSE TestAccECRReplicationConfiguration_serial
=== RUN   TestAccECRRepositoriesDataSource_basic
=== PAUSE TestAccECRRepositoriesDataSource_basic
=== RUN   TestAccECRRepositoryDataSource_basic
=== PAUSE TestAccECRRepositoryDataSource_basic
=== RUN   TestAccECRRepositoryDataSource_encryption
=== PAUSE TestAccECRRepositoryDataSource_encryption
=== RUN   TestAccECRRepositoryDataSource_nonExistent
=== PAUSE TestAccECRRepositoryDataSource_nonExistent
=== RUN   TestAccECRRepositoryPolicy_basic
=== PAUSE TestAccECRRepositoryPolicy_basic
=== RUN   TestAccECRRepositoryPolicy_IAM_basic
=== PAUSE TestAccECRRepositoryPolicy_IAM_basic
=== RUN   TestAccECRRepositoryPolicy_IAM_principalOrder
=== PAUSE TestAccECRRepositoryPolicy_IAM_principalOrder
=== RUN   TestAccECRRepositoryPolicy_disappears
=== PAUSE TestAccECRRepositoryPolicy_disappears
=== RUN   TestAccECRRepositoryPolicy_Disappears_repository
=== PAUSE TestAccECRRepositoryPolicy_Disappears_repository
=== RUN   TestAccECRRepository_basic
=== PAUSE TestAccECRRepository_basic
=== RUN   TestAccECRRepository_disappears
=== PAUSE TestAccECRRepository_disappears
=== RUN   TestAccECRRepository_tags
=== PAUSE TestAccECRRepository_tags
=== RUN   TestAccECRRepository_immutability
=== PAUSE TestAccECRRepository_immutability
=== RUN   TestAccECRRepository_Image_scanning
=== PAUSE TestAccECRRepository_Image_scanning
=== RUN   TestAccECRRepository_Encryption_kms
=== PAUSE TestAccECRRepository_Encryption_kms
=== RUN   TestAccECRRepository_Encryption_aes256
=== PAUSE TestAccECRRepository_Encryption_aes256
=== CONT  TestAccECRImageDataSource_basic
=== CONT  TestAccECRRepositoryDataSource_basic
=== CONT  TestAccECRRepository_basic
=== CONT  TestAccECRRepositoryPolicy_IAM_basic
=== CONT  TestAccECRPullThroughCacheRule_credentialARN
=== CONT  TestAccECRRegistryPolicy_serial
=== RUN   TestAccECRRegistryPolicy_serial/basic
=== CONT  TestAccECRPullThroughCacheRule_failWhenAlreadyExists
=== CONT  TestAccECRPullThroughCacheRule_repositoryPrefixWithSlash
=== CONT  TestAccECRReplicationConfiguration_serial
=== RUN   TestAccECRReplicationConfiguration_serial/repositoryFilter
=== CONT  TestAccECRRepositoriesDataSource_basic
=== CONT  TestAccECRPullThroughCacheRuleDataSource_basic
=== CONT  TestAccECRPullThroughCacheRule_basic
=== CONT  TestAccECRPullThroughCacheRuleDataSource_credential
=== CONT  TestAccECRPullThroughCacheRuleDataSource_repositoryPrefixWithSlash
=== CONT  TestAccECRRepositoryDataSource_nonExistent
=== CONT  TestAccECRRepositoryPolicy_basic
=== CONT  TestAccECRPullThroughCacheRule_disappears
=== CONT  TestAccECRRepositoryPolicy_disappears
=== CONT  TestAccECRRepositoryPolicy_Disappears_repository
=== CONT  TestAccECRRepositoryDataSource_encryption
--- PASS: TestAccECRRepositoryDataSource_nonExistent (7.29s)
=== CONT  TestAccECRRepositoryPolicy_IAM_principalOrder
--- PASS: TestAccECRPullThroughCacheRule_failWhenAlreadyExists (23.55s)
=== CONT  TestAccECRRepository_Image_scanning
--- PASS: TestAccECRPullThroughCacheRuleDataSource_basic (34.75s)
=== CONT  TestAccECRRepository_Encryption_aes256
--- PASS: TestAccECRImageDataSource_basic (35.90s)
=== CONT  TestAccECRRepository_Encryption_kms
--- PASS: TestAccECRPullThroughCacheRuleDataSource_repositoryPrefixWithSlash (38.73s)
=== CONT  TestAccECRLifecyclePolicy_ignoreEquivalent
--- PASS: TestAccECRRepositoriesDataSource_basic (39.00s)
=== CONT  TestAccECRLifecyclePolicy_detectDiff
--- PASS: TestAccECRPullThroughCacheRule_repositoryPrefixWithSlash (46.11s)
=== CONT  TestAccECRRepository_tags
--- PASS: TestAccECRPullThroughCacheRuleDataSource_credential (46.41s)
=== CONT  TestAccECRRepository_immutability
--- PASS: TestAccECRRepositoryDataSource_basic (46.50s)
=== CONT  TestAccECRScanningConfiguration_serial
=== RUN   TestAccECRScanningConfiguration_serial/basic
--- PASS: TestAccECRPullThroughCacheRule_disappears (48.41s)
=== CONT  TestAccECRLifecyclePolicy_basic
--- PASS: TestAccECRRepositoryPolicy_Disappears_repository (48.73s)
=== CONT  TestAccECRRepository_disappears
--- PASS: TestAccECRRepositoryPolicy_disappears (49.09s)
--- PASS: TestAccECRRepositoryDataSource_encryption (49.74s)
--- PASS: TestAccECRPullThroughCacheRule_basic (54.87s)
--- PASS: TestAccECRRepository_basic (55.50s)
--- PASS: TestAccECRPullThroughCacheRule_credentialARN (55.73s)
--- PASS: TestAccECRRepositoryPolicy_IAM_basic (61.30s)
--- PASS: TestAccECRRepositoryPolicy_basic (68.98s)
=== RUN   TestAccECRRegistryPolicy_serial/disappears
--- PASS: TestAccECRRepository_disappears (28.88s)
=== RUN   TestAccECRScanningConfiguration_serial/update
--- PASS: TestAccECRRepositoryPolicy_IAM_principalOrder (71.72s)
--- PASS: TestAccECRRepository_immutability (34.31s)
--- PASS: TestAccECRLifecyclePolicy_ignoreEquivalent (42.97s)
--- PASS: TestAccECRLifecyclePolicy_detectDiff (43.46s)
--- PASS: TestAccECRLifecyclePolicy_basic (34.33s)
=== RUN   TestAccECRReplicationConfiguration_serial/basic
--- PASS: TestAccECRRepository_Encryption_aes256 (57.64s)
--- PASS: TestAccECRRegistryPolicy_serial (93.98s)
    --- PASS: TestAccECRRegistryPolicy_serial/basic (77.33s)
    --- PASS: TestAccECRRegistryPolicy_serial/disappears (16.65s)
--- PASS: TestAccECRRepository_Encryption_kms (60.11s)
--- PASS: TestAccECRRepository_Image_scanning (74.26s)
--- PASS: TestAccECRRepository_tags (59.66s)
--- PASS: TestAccECRScanningConfiguration_serial (78.65s)
    --- PASS: TestAccECRScanningConfiguration_serial/basic (32.29s)
    --- PASS: TestAccECRScanningConfiguration_serial/update (46.37s)
--- PASS: TestAccECRReplicationConfiguration_serial (127.85s)
    --- PASS: TestAccECRReplicationConfiguration_serial/repositoryFilter (89.19s)
    --- PASS: TestAccECRReplicationConfiguration_serial/basic (38.66s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecr        155.900s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecr Issues and PRs that pertain to the ecr service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Mar 20, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Mar 20, 2024
@alexknez alexknez force-pushed the f-migrate-ecr-sdk-v2 branch 2 times, most recently from 1d17cbd to 609af72 Compare March 20, 2024 22:50
@alexknez alexknez force-pushed the f-migrate-ecr-sdk-v2 branch from 609af72 to a92b240 Compare March 20, 2024 23:31
@alexknez alexknez marked this pull request as draft March 20, 2024 23:43
@alexknez alexknez marked this pull request as ready for review March 21, 2024 00:01
@justinretzolk justinretzolk added aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 21, 2024
@ewbankkit ewbankkit self-assigned this Mar 28, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 28, 2024
ewbankkit
ewbankkit approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccECR' PKG=ecr ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ecr/... -v -count 1 -parallel 3  -run=TestAccECR -timeout 360m
=== RUN   TestAccECRAuthorizationTokenDataSource_basic
--- PASS: TestAccECRAuthorizationTokenDataSource_basic (25.39s)
=== RUN   TestAccECRImageDataSource_basic
=== PAUSE TestAccECRImageDataSource_basic
=== RUN   TestAccECRLifecyclePolicy_basic
=== PAUSE TestAccECRLifecyclePolicy_basic
=== RUN   TestAccECRLifecyclePolicy_disappears
=== PAUSE TestAccECRLifecyclePolicy_disappears
=== RUN   TestAccECRLifecyclePolicy_ignoreEquivalent
=== PAUSE TestAccECRLifecyclePolicy_ignoreEquivalent
=== RUN   TestAccECRLifecyclePolicy_detectDiff
=== PAUSE TestAccECRLifecyclePolicy_detectDiff
=== RUN   TestAccECRPullThroughCacheRuleDataSource_basic
=== PAUSE TestAccECRPullThroughCacheRuleDataSource_basic
=== RUN   TestAccECRPullThroughCacheRuleDataSource_repositoryPrefixWithSlash
=== PAUSE TestAccECRPullThroughCacheRuleDataSource_repositoryPrefixWithSlash
=== RUN   TestAccECRPullThroughCacheRuleDataSource_credential
=== PAUSE TestAccECRPullThroughCacheRuleDataSource_credential
=== RUN   TestAccECRPullThroughCacheRule_basic
=== PAUSE TestAccECRPullThroughCacheRule_basic
=== RUN   TestAccECRPullThroughCacheRule_credentialARN
=== PAUSE TestAccECRPullThroughCacheRule_credentialARN
=== RUN   TestAccECRPullThroughCacheRule_disappears
=== PAUSE TestAccECRPullThroughCacheRule_disappears
=== RUN   TestAccECRPullThroughCacheRule_failWhenAlreadyExists
=== PAUSE TestAccECRPullThroughCacheRule_failWhenAlreadyExists
=== RUN   TestAccECRPullThroughCacheRule_repositoryPrefixWithSlash
=== PAUSE TestAccECRPullThroughCacheRule_repositoryPrefixWithSlash
=== RUN   TestAccECRRegistryPolicy_serial
=== PAUSE TestAccECRRegistryPolicy_serial
=== RUN   TestAccECRScanningConfiguration_serial
=== PAUSE TestAccECRScanningConfiguration_serial
=== RUN   TestAccECRReplicationConfiguration_serial
=== PAUSE TestAccECRReplicationConfiguration_serial
=== RUN   TestAccECRRepositoriesDataSource_basic
=== PAUSE TestAccECRRepositoriesDataSource_basic
=== RUN   TestAccECRRepositoryDataSource_basic
=== PAUSE TestAccECRRepositoryDataSource_basic
=== RUN   TestAccECRRepositoryDataSource_encryption
=== PAUSE TestAccECRRepositoryDataSource_encryption
=== RUN   TestAccECRRepositoryDataSource_nonExistent
=== PAUSE TestAccECRRepositoryDataSource_nonExistent
=== RUN   TestAccECRRepositoryPolicy_basic
=== PAUSE TestAccECRRepositoryPolicy_basic
=== RUN   TestAccECRRepositoryPolicy_IAM_basic
=== PAUSE TestAccECRRepositoryPolicy_IAM_basic
=== RUN   TestAccECRRepositoryPolicy_IAM_principalOrder
=== PAUSE TestAccECRRepositoryPolicy_IAM_principalOrder
=== RUN   TestAccECRRepositoryPolicy_disappears
=== PAUSE TestAccECRRepositoryPolicy_disappears
=== RUN   TestAccECRRepositoryPolicy_Disappears_repository
=== PAUSE TestAccECRRepositoryPolicy_Disappears_repository
=== RUN   TestAccECRRepository_basic
=== PAUSE TestAccECRRepository_basic
=== RUN   TestAccECRRepository_disappears
=== PAUSE TestAccECRRepository_disappears
=== RUN   TestAccECRRepository_tags
=== PAUSE TestAccECRRepository_tags
=== RUN   TestAccECRRepository_immutability
=== PAUSE TestAccECRRepository_immutability
=== RUN   TestAccECRRepository_Image_scanning
=== PAUSE TestAccECRRepository_Image_scanning
=== RUN   TestAccECRRepository_Encryption_kms
=== PAUSE TestAccECRRepository_Encryption_kms
=== RUN   TestAccECRRepository_Encryption_aes256
=== PAUSE TestAccECRRepository_Encryption_aes256
=== CONT  TestAccECRImageDataSource_basic
=== CONT  TestAccECRRepositoriesDataSource_basic
=== CONT  TestAccECRPullThroughCacheRule_basic
--- PASS: TestAccECRImageDataSource_basic (21.27s)
=== CONT  TestAccECRRepositoryPolicy_Disappears_repository
--- PASS: TestAccECRRepositoriesDataSource_basic (21.45s)
=== CONT  TestAccECRRepository_Encryption_aes256
--- PASS: TestAccECRPullThroughCacheRule_basic (25.43s)
=== CONT  TestAccECRRepository_Encryption_kms
--- PASS: TestAccECRRepositoryPolicy_Disappears_repository (24.30s)
=== CONT  TestAccECRRepository_Image_scanning
--- PASS: TestAccECRRepository_Encryption_aes256 (48.25s)
=== CONT  TestAccECRRepository_immutability
--- PASS: TestAccECRRepository_Encryption_kms (49.55s)
=== CONT  TestAccECRRepository_tags
--- PASS: TestAccECRRepository_immutability (24.36s)
=== CONT  TestAccECRRepository_disappears
--- PASS: TestAccECRRepository_Image_scanning (56.55s)
=== CONT  TestAccECRRepository_basic
--- PASS: TestAccECRRepository_disappears (22.09s)
=== CONT  TestAccECRLifecyclePolicy_detectDiff
--- PASS: TestAccECRRepository_basic (25.09s)
=== CONT  TestAccECRPullThroughCacheRuleDataSource_credential
--- PASS: TestAccECRRepository_tags (55.86s)
=== CONT  TestAccECRPullThroughCacheRuleDataSource_repositoryPrefixWithSlash
--- PASS: TestAccECRLifecyclePolicy_detectDiff (30.08s)
=== CONT  TestAccECRPullThroughCacheRuleDataSource_basic
--- PASS: TestAccECRPullThroughCacheRuleDataSource_credential (22.79s)
=== CONT  TestAccECRPullThroughCacheRule_repositoryPrefixWithSlash
--- PASS: TestAccECRPullThroughCacheRuleDataSource_repositoryPrefixWithSlash (21.13s)
=== CONT  TestAccECRReplicationConfiguration_serial
=== RUN   TestAccECRReplicationConfiguration_serial/disappears
--- PASS: TestAccECRPullThroughCacheRuleDataSource_basic (19.53s)
=== CONT  TestAccECRScanningConfiguration_serial
=== RUN   TestAccECRScanningConfiguration_serial/basic
--- PASS: TestAccECRPullThroughCacheRule_repositoryPrefixWithSlash (19.01s)
=== CONT  TestAccECRRegistryPolicy_serial
=== RUN   TestAccECRRegistryPolicy_serial/basic
=== RUN   TestAccECRReplicationConfiguration_serial/repositoryFilter
=== RUN   TestAccECRScanningConfiguration_serial/update
=== RUN   TestAccECRRegistryPolicy_serial/disappears
=== RUN   TestAccECRReplicationConfiguration_serial/basic
--- PASS: TestAccECRRegistryPolicy_serial (60.52s)
    --- PASS: TestAccECRRegistryPolicy_serial/basic (39.05s)
    --- PASS: TestAccECRRegistryPolicy_serial/disappears (21.47s)
=== CONT  TestAccECRLifecyclePolicy_basic
--- PASS: TestAccECRScanningConfiguration_serial (85.61s)
    --- PASS: TestAccECRScanningConfiguration_serial/basic (23.77s)
    --- PASS: TestAccECRScanningConfiguration_serial/update (61.85s)
=== CONT  TestAccECRLifecyclePolicy_ignoreEquivalent
--- PASS: TestAccECRLifecyclePolicy_basic (27.78s)
=== CONT  TestAccECRPullThroughCacheRule_disappears
--- PASS: TestAccECRPullThroughCacheRule_disappears (20.74s)
=== CONT  TestAccECRPullThroughCacheRule_failWhenAlreadyExists
--- PASS: TestAccECRLifecyclePolicy_ignoreEquivalent (29.03s)
=== CONT  TestAccECRRepositoryPolicy_basic
--- PASS: TestAccECRReplicationConfiguration_serial (132.81s)
    --- PASS: TestAccECRReplicationConfiguration_serial/disappears (20.33s)
    --- PASS: TestAccECRReplicationConfiguration_serial/repositoryFilter (55.02s)
    --- PASS: TestAccECRReplicationConfiguration_serial/basic (57.45s)
=== CONT  TestAccECRRepositoryPolicy_disappears
--- PASS: TestAccECRPullThroughCacheRule_failWhenAlreadyExists (10.97s)
=== CONT  TestAccECRRepositoryPolicy_IAM_principalOrder
--- PASS: TestAccECRRepositoryPolicy_disappears (19.04s)
=== CONT  TestAccECRRepositoryPolicy_IAM_basic
--- PASS: TestAccECRRepositoryPolicy_basic (35.71s)
=== CONT  TestAccECRPullThroughCacheRule_credentialARN
--- PASS: TestAccECRRepositoryPolicy_IAM_principalOrder (45.51s)
=== CONT  TestAccECRLifecyclePolicy_disappears
=== CONT  TestAccECRRepositoryDataSource_encryption
--- PASS: TestAccECRRepositoryPolicy_IAM_basic (31.91s)
--- PASS: TestAccECRPullThroughCacheRule_credentialARN (24.11s)
=== CONT  TestAccECRRepositoryDataSource_nonExistent
--- PASS: TestAccECRRepositoryDataSource_nonExistent (3.84s)
=== CONT  TestAccECRRepositoryDataSource_basic
--- PASS: TestAccECRLifecyclePolicy_disappears (19.57s)
--- PASS: TestAccECRRepositoryDataSource_encryption (21.08s)
--- PASS: TestAccECRRepositoryDataSource_basic (17.74s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	397.881s

#35231:

% make testacc TESTARGS='-run=TestAccECRLifecyclePolicy_' PKG=ecr ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ecr/... -v -count 1 -parallel 3  -run=TestAccECRLifecyclePolicy_ -timeout 360m
=== RUN   TestAccECRLifecyclePolicy_basic
=== PAUSE TestAccECRLifecyclePolicy_basic
=== RUN   TestAccECRLifecyclePolicy_disappears
=== PAUSE TestAccECRLifecyclePolicy_disappears
=== RUN   TestAccECRLifecyclePolicy_ignoreEquivalent
=== PAUSE TestAccECRLifecyclePolicy_ignoreEquivalent
=== RUN   TestAccECRLifecyclePolicy_detectDiff
=== PAUSE TestAccECRLifecyclePolicy_detectDiff
=== RUN   TestAccECRLifecyclePolicy_detectTagPatternListDiff
=== PAUSE TestAccECRLifecyclePolicy_detectTagPatternListDiff
=== CONT  TestAccECRLifecyclePolicy_basic
=== CONT  TestAccECRLifecyclePolicy_detectDiff
=== CONT  TestAccECRLifecyclePolicy_detectTagPatternListDiff
--- PASS: TestAccECRLifecyclePolicy_basic (29.36s)
=== CONT  TestAccECRLifecyclePolicy_ignoreEquivalent
--- PASS: TestAccECRLifecyclePolicy_detectDiff (35.42s)
=== CONT  TestAccECRLifecyclePolicy_disappears
--- PASS: TestAccECRLifecyclePolicy_detectTagPatternListDiff (35.45s)
--- PASS: TestAccECRLifecyclePolicy_disappears (19.61s)
--- PASS: TestAccECRLifecyclePolicy_ignoreEquivalent (26.76s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	69.548s

#6133:

% make testacc TESTARGS='-run=TestAccECRLifecyclePolicyDocumentDataSource_' PKG=ecr ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ecr/... -v -count 1 -parallel 3  -run=TestAccECRLifecyclePolicyDocumentDataSource_ -timeout 360m
=== RUN   TestAccECRLifecyclePolicyDocumentDataSource_basic
--- PASS: TestAccECRLifecyclePolicyDocumentDataSource_basic (11.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	22.487s

ewbankkit added 11 commits March 29, 2024 11:32
@ewbankkit
Revert "removing unneeded out"
5aee543 
This reverts commit 819b1d6.
@ewbankkit
Revert "fixing docs"
c2221b7 
This reverts commit d3995af.
@ewbankkit
Revert "fixing acc test"
b2f1060 
This reverts commit c3c906d.
@ewbankkit
Revert "adding documentation"
3f25cfc 
This reverts commit 8d96c00.
@ewbankkit
Revert "data_source/ecr_lifecycle_policy_document: adding new data so…
99cc2c2 
…urce for ECR"

This reverts commit 08da208.
@ewbankkit
Merge branch 'main' into HEAD
585d9e1
@ewbankkit
Merge commit '585d9e1cd617ad32b8ffea4566273f7358cc7782' into HEAD
a35a8c3
@ewbankkit
Merge commit 'a35a8c322929cdd8d82f25b2a68f0f5a9212708e' into HEAD
a31db27
@ewbankkit
Acceptance test output:
e182c8b 
% make testacc TESTARGS='-run=TestAccECRLifecyclePolicy_' PKG=ecr ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/ecr/... -v -count 1 -parallel 3  -run=TestAccECRLifecyclePolicy_ -timeout 360m
=== RUN   TestAccECRLifecyclePolicy_basic
=== PAUSE TestAccECRLifecyclePolicy_basic
=== RUN   TestAccECRLifecyclePolicy_disappears
=== PAUSE TestAccECRLifecyclePolicy_disappears
=== RUN   TestAccECRLifecyclePolicy_ignoreEquivalent
=== PAUSE TestAccECRLifecyclePolicy_ignoreEquivalent
=== RUN   TestAccECRLifecyclePolicy_detectDiff
=== PAUSE TestAccECRLifecyclePolicy_detectDiff
=== RUN   TestAccECRLifecyclePolicy_detectTagPatternListDiff
=== PAUSE TestAccECRLifecyclePolicy_detectTagPatternListDiff
=== CONT  TestAccECRLifecyclePolicy_basic
=== CONT  TestAccECRLifecyclePolicy_detectDiff
=== CONT  TestAccECRLifecyclePolicy_ignoreEquivalent
--- PASS: TestAccECRLifecyclePolicy_basic (26.42s)
=== CONT  TestAccECRLifecyclePolicy_detectTagPatternListDiff
--- PASS: TestAccECRLifecyclePolicy_ignoreEquivalent (29.57s)
=== CONT  TestAccECRLifecyclePolicy_disappears
--- PASS: TestAccECRLifecyclePolicy_detectDiff (30.88s)
--- PASS: TestAccECRLifecyclePolicy_disappears (17.91s)
--- PASS: TestAccECRLifecyclePolicy_detectTagPatternListDiff (24.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	62.278s
@ewbankkit
d/aws_ecr_lifecycle_policy_document: New data source.
0d1571f
@ewbankkit
d/aws_ecr_lifecycle_policy_document: Acceptance tests.
cc1947c
@ewbankkit ewbankkit added the new-data-source Introduces a new data source. label Mar 29, 2024
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/bedrock Issues and PRs that pertain to the bedrock service. labels Mar 29, 2024
This was referenced Mar 29, 2024
Merged
Closed
@ewbankkit
Copy link
Contributor

@alexknez Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 00aaba9 into hashicorp:main Mar 29, 2024
9 checks passed
@github-actions github-actions bot added this to the v5.44.0 milestone Mar 29, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

This functionality has been released in v5.44.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-data-source Introduces a new data source. partner Contribution from a partner. service/bedrock Issues and PRs that pertain to the bedrock service. service/ecr Issues and PRs that pertain to the ecr service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.44.0
5 participants
@alexknez @ewbankkit @justinretzolk @slapula @acwwat