Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws_mq_broker): Do not reboot on changes to maintenance_window_start_time or auto_minor_version_upgrade #36506

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

SignalWhisperer
Copy link
Contributor

Description

Rebooting the Amazon MQ broker is not necessary for modifications to maintenance_window_start_time or to auto_minor_version_upgrade. These changes take effect immediately.

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. service/mq Issues and PRs that pertain to the mq service. labels Mar 21, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 21, 2024
@SignalWhisperer SignalWhisperer changed the title fix(mq): No reboot necessary on maintenance_window_start_time or auto_minor_version_upgrade changes fix(aws_mq_broker): No reboot necessary on maintenance_window_start_time or auto_minor_version_upgrade changes Mar 21, 2024
@SignalWhisperer SignalWhisperer changed the title fix(aws_mq_broker): No reboot necessary on maintenance_window_start_time or auto_minor_version_upgrade changes fix(aws_mq_broker): Do not reboot on changes to maintenance_window_start_time or auto_minor_version_upgrade Mar 21, 2024
@SignalWhisperer SignalWhisperer marked this pull request as ready for review March 21, 2024 15:27
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 21, 2024
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🚀

--- PASS: TestAccMQBroker_RabbitMQ_basic (624.25s)
--- PASS: TestAccMQBroker_RabbitMQ_logs (676.49s)
--- PASS: TestAccMQBroker_RabbitMQ_config (703.18s)
--- PASS: TestAccMQBroker_RabbitMQ_validationAuditLog (767.99s)
--- PASS: TestAccMQBroker_throughputOptimized (789.47s)
--- PASS: TestAccMQBroker_RabbitMQ_cluster (789.98s)
--- PASS: TestAccMQBroker_EncryptionOptions_kmsKeyID (802.75s)
--- PASS: TestAccMQBroker_basic (843.52s)
--- PASS: TestAccMQBroker_disappears (882.31s)
--- PASS: TestAccMQBroker_EncryptionOptions_managedKeyEnabled (885.45s)
--- PASS: TestAccMQBroker_tags (889.45s)
--- PASS: TestAccMQBroker_EncryptionOptions_managedKeyDisabled (895.46s)
--- PASS: TestAccMQBroker_ldap (912.36s)
--- PASS: TestAccMQBroker_Update_securityGroup (1056.56s)
--- PASS: TestAccMQBroker_Update_engineVersion (1137.93s)
--- PASS: TestAccMQBroker_Update_users (1247.94s)
--- PASS: TestAccMQBroker_Update_hostInstanceType (1387.90s)
--- PASS: TestAccMQBroker_AllFields_customVPC (1525.25s)
--- PASS: TestAccMQBroker_AllFields_defaultVPC (1586.22s)
--- PASS: TestAccMQBroker_dataReplicationMode (1786.56s)

@gdavison gdavison merged commit d8ec76b into hashicorp:main Jun 4, 2024
27 checks passed
@github-actions github-actions bot added this to the v5.53.0 milestone Jun 4, 2024
Copy link

github-actions bot commented Jun 7, 2024

This functionality has been released in v5.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@SignalWhisperer SignalWhisperer deleted the f-requires-restart branch June 7, 2024 14:10
Copy link

github-actions bot commented Jul 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/mq Issues and PRs that pertain to the mq service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants