Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appconfig: Migrate to AWS SDK v2 #36542

Merged
merged 5 commits into from
Apr 2, 2024

Conversation

mattburgess
Copy link
Collaborator

Description

Relations

Closes #36114

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

No acctests run as unsure of costs.

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/appconfig Issues and PRs that pertain to the appconfig service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Mar 23, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Mar 23, 2024
@mattburgess mattburgess force-pushed the appconfig-awssdkv2-migration branch from 7061927 to 77ed655 Compare March 23, 2024 22:55
@justinretzolk justinretzolk added provider Pertains to the provider itself, rather than any interaction with AWS. aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 25, 2024
@johnsonaj johnsonaj self-assigned this Apr 2, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 2, 2024
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS="-run=TestAccAppConfig" PKG=appconfig

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/appconfig/... -v -count 1 -parallel 20  -run=TestAccAppConfig -timeout 360m
--- PASS: TestAccAppConfigEnvironmentsDataSource_basic (31.58s)
--- PASS: TestAccAppConfigHostedConfigurationVersion_basic (33.51s)
--- PASS: TestAccAppConfigDeployment_kms (34.27s)
--- PASS: TestAccAppConfigEnvironmentDataSource_basic (34.52s)
--- PASS: TestAccAppConfigHostedConfigurationVersion_disappears (34.81s)
--- PASS: TestAccAppConfigExtensionAssociation_disappears (35.61s)
--- PASS: TestAccAppConfigExtension_disappears (35.68s)
--- PASS: TestAccAppConfigApplication_basic (36.69s)
--- PASS: TestAccAppConfigExtensionAssociation_basic (39.69s)
--- PASS: TestAccAppConfigExtension_basic (41.40s)
--- PASS: TestAccAppConfigDeployment_predefinedStrategy (41.92s)
--- PASS: TestAccAppConfigEnvironment_frameworkMigration_monitors (49.25s)
--- PASS: TestAccAppConfigEnvironment_frameworkMigration_basic (51.21s)
--- PASS: TestAccAppConfigExtension_Description (58.12s)
--- PASS: TestAccAppConfigExtension_Name (63.86s)
--- PASS: TestAccAppConfigConfigurationProfilesDataSource_basic (28.35s)
--- PASS: TestAccAppConfigDeploymentStrategy_disappears (30.44s)
--- PASS: TestAccAppConfigDeploymentStrategy_basic (33.41s)
--- PASS: TestAccAppConfigDeployment_basic (37.94s)
--- PASS: TestAccAppConfigConfigurationProfile_updateDescription (70.82s)
--- PASS: TestAccAppConfigEnvironment_multipleEnvironments (76.83s)
--- PASS: TestAccAppConfigExtension_tags (82.43s)
--- PASS: TestAccAppConfigDeployment_tags (83.28s)
--- PASS: TestAccAppConfigConfigurationProfile_disappears (25.50s)
--- PASS: TestAccAppConfigDeploymentStrategy_updateDescription (53.02s)
--- PASS: TestAccAppConfigConfigurationProfile_kmsKey (26.77s)
--- PASS: TestAccAppConfigEnvironment_tagsWithNullValue (61.51s)
--- PASS: TestAccAppConfigExtensionAssociation_Parameters (105.62s)
--- PASS: TestAccAppConfigDeploymentStrategy_tags (73.36s)
--- PASS: TestAccAppConfigConfigurationProfile_tags (76.72s)
--- PASS: TestAccAppConfigEnvironment_disappears (30.63s)
--- PASS: TestAccAppConfigDeploymentStrategy_updateFinalBakeTime (80.07s)
--- PASS: TestAccAppConfigConfigurationProfileDataSource_basic (31.98s)
--- PASS: TestAccAppConfigConfigurationProfile_basic (33.89s)
--- PASS: TestAccAppConfigConfigurationProfile_Validators_multiple (52.31s)
--- PASS: TestAccAppConfigExtension_Parameter (76.12s)
--- PASS: TestAccAppConfigConfigurationProfile_updateName (54.29s)
--- PASS: TestAccAppConfigEnvironment_monitors (81.04s)
--- PASS: TestAccAppConfigApplication_disappears (22.94s)
--- PASS: TestAccAppConfigExtension_ActionPoint (73.95s)
--- PASS: TestAccAppConfigEnvironment_updateDescription (76.82s)
--- PASS: TestAccAppConfigEnvironment_basic (24.06s)
--- PASS: TestAccAppConfigApplication_updateName (42.29s)
--- PASS: TestAccAppConfigConfigurationProfile_Validators_lambda (66.15s)
--- PASS: TestAccAppConfigEnvironment_tags (60.43s)
--- PASS: TestAccAppConfigApplication_tags (55.14s)
--- PASS: TestAccAppConfigConfigurationProfile_Validators_json (64.63s)
--- PASS: TestAccAppConfigEnvironment_updateName (29.88s)
--- PASS: TestAccAppConfigApplication_updateDescription (45.28s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/appconfig	147.414s

@johnsonaj
Copy link
Contributor

@mattburgess thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit e72da85 into hashicorp:main Apr 2, 2024
36 checks passed
@github-actions github-actions bot added this to the v5.44.0 milestone Apr 2, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 5, 2024
Copy link

github-actions bot commented Apr 5, 2024

This functionality has been released in v5.44.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented May 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/appconfig Issues and PRs that pertain to the appconfig service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] AppConfig Service
3 participants