Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech Debt] IAM: Migrate to AWS SDKv2 #36613

Merged
merged 39 commits into from
Mar 28, 2024
Merged

[Tech Debt] IAM: Migrate to AWS SDKv2 #36613

merged 39 commits into from
Mar 28, 2024

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Mar 27, 2024 •
edited
Loading

Description

Relations

Closes #36168

References

Output from Acceptance Testing

% make testacc TESTARGS="-run=TestAccIAM" PKG=iam

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/iam/... -v -count 1 -parallel 20  -run=TestAccIAM -timeout 360m
--- PASS: TestAccIAMUserPolicy_disappears (31.39s)
--- PASS: TestAccIAMVirtualMFADevice_disappears (31.75s)
--- PASS: TestAccIAMUserSSHKey_disappears (33.81s)
--- PASS: TestAccIAMUserSSHKeyDataSource_basic (33.89s)
--- PASS: TestAccIAMUserPolicy_namePrefix (36.30s)
--- PASS: TestAccIAMUserPolicy_nameGenerated (36.39s)
--- PASS: TestAccIAMUserSSHKey_pemEncoding (36.50s)
--- PASS: TestAccIAMAccessKey_basic (36.58s)
--- PASS: TestAccIAMUser_ForceDestroy_serviceSpecificCred (36.86s)
--- PASS: TestAccIAMUserPolicy_policyOrder (39.78s)
--- PASS: TestAccIAMUserSSHKey_basic (41.63s)
--- PASS: TestAccIAMUserPolicy_multiplePolicies (54.22s)
--- PASS: TestAccIAMUser_tags_DefaultTags_updateToProviderOnly (55.44s)
--- PASS: TestAccIAMUserLoginProfile_keybaseDoesntExist (20.99s)
--- PASS: TestAccIAMUser_tags_EmptyTag_OnUpdate_Replace (58.68s)
--- PASS: TestAccIAMSessionContextDataSource_notAssumedRoleUser (22.85s)
--- PASS: TestAccIAMUserPolicy_basic (60.68s)
--- PASS: TestAccIAMUserPolicyAttachment_disappears (29.60s)
--- PASS: TestAccIAMUserLoginProfile_notAKey (24.95s)
--- PASS: TestAccIAMVirtualMFADevice_tags_EmptyTag_OnCreate (62.99s)
--- PASS: TestAccIAMSessionContextDataSource_notAssumedRoleWithPath (25.59s)
--- PASS: TestAccIAMUserLoginProfile_nogpg (34.91s)
--- PASS: TestAccIAMSessionContextDataSource_notAssumedRole (29.31s)
--- PASS: TestAccIAMUserLoginProfile_passwordLength (37.51s)
--- PASS: TestAccIAMUserLoginProfile_keybase (37.43s)
--- PASS: TestAccIAMUserLoginProfile_disappears (47.57s)
--- PASS: TestAccIAMSessionContextDataSource_withPath (30.27s)
--- PASS: TestAccIAMSessionContextDataSource_basic (27.62s)
--- PASS: TestAccIAMUser_tags_EmptyTag_OnUpdate_Add (88.42s)
--- PASS: TestAccIAMUser_tags_DefaultTags_nonOverlapping (89.98s)
--- PASS: TestAccIAMUserDataSource_basic (29.83s)
--- PASS: TestAccIAMUserDataSource_tags (30.89s)
--- PASS: TestAccIAMUserPolicyAttachment_basic (59.38s)
--- PASS: TestAccIAMUser_tags_DefaultTags_overlapping (91.86s)
--- PASS: TestAccIAMServiceSpecificCredential_disappears (31.53s)
--- PASS: TestAccIAMSigningCertificate_disappears (31.40s)
--- PASS: TestAccIAMRole_badJSON (4.13s)
--- PASS: TestAccIAMUserLoginProfile_basic (46.55s)
--- PASS: TestAccIAMSigningCertificate_basic (40.03s)
--- PASS: TestAccIAMRole_InlinePolicy_empty (29.39s)
--- PASS: TestAccIAMUser_tags_DefaultTags_providerOnly (115.82s)
--- PASS: TestAccIAMServiceLinkedRole_customSuffix (49.14s)
--- PASS: TestAccIAMRole_disappears (25.41s)
--- PASS: TestAccIAMServiceLinkedRole_tags_DefaultTags_nullOverlappingResourceTag (45.32s)
--- PASS: TestAccIAMServiceLinkedRole_tags_DefaultTags_nullNonOverlappingResourceTag (47.12s)
--- PASS: TestAccIAMServiceLinkedRole_basic (53.10s)
--- PASS: TestAccIAMServiceLinkedRole_tags_DefaultTags_emptyResourceTag (42.89s)
--- PASS: TestAccIAMRole_policiesForceDetach (32.92s)
--- PASS: TestAccIAMSigningCertificate_status (77.92s)
--- PASS: TestAccIAMServiceLinkedRole_tags_DefaultTags_updateToProviderOnly (60.21s)
--- PASS: TestAccIAMRole_namePrefix (35.01s)
--- PASS: TestAccIAMRole_InlinePolicy_ignoreOrder (66.29s)
--- PASS: TestAccIAMRole_tags_DefaultTags_nullNonOverlappingResourceTag (33.94s)
--- PASS: TestAccIAMRole_nameGenerated (37.10s)
--- PASS: TestAccIAMRole_basic (36.24s)
--- PASS: TestAccIAMRole_testNameChange (52.53s)
--- PASS: TestAccIAMRole_maxSessionDuration (67.08s)
--- PASS: TestAccIAMRole_tags_DefaultTags_nullOverlappingResourceTag (35.02s)
--- PASS: TestAccIAMRole_tags_DefaultTags_emptyResourceTag (34.95s)
--- PASS: TestAccIAMServiceLinkedRole_tags_DefaultTags_updateToResourceOnly (73.83s)
--- PASS: TestAccIAMRole_InlinePolicy_basic (74.06s)
--- PASS: TestAccIAMServiceLinkedRole_tags_null (52.73s)
--- PASS: TestAccIAMRolePolicy_invalidJSON (3.49s)
--- PASS: TestAccIAMRolePolicy_Policy_invalidResource (15.75s)
--- PASS: TestAccIAMRole_tags_DefaultTags_updateToResourceOnly (53.90s)
--- PASS: TestAccIAMRolePolicy_unknownsInPolicy (35.80s)
--- PASS: TestAccIAMUserGroupMembership_basic (137.84s)
--- PASS: TestAccIAMRole_description (79.31s)
--- PASS: TestAccIAMRole_diffsCondition (103.47s)
--- PASS: TestAccIAMRole_tags_DefaultTags_updateToProviderOnly (60.87s)
--- PASS: TestAccIAMRole_tags_null (47.64s)
--- PASS: TestAccIAMRolePolicy_policyOrder (40.73s)
--- PASS: TestAccIAMRole_tags_EmptyTag_OnUpdate_Replace (58.73s)
--- PASS: TestAccIAMRole_tags_AddOnUpdate (58.54s)
--- PASS: TestAccIAMRolePolicy_namePrefix (37.77s)
--- PASS: TestAccIAMRole_tags_EmptyTag_OnCreate (68.17s)
--- PASS: TestAccIAMRolePolicy_disappears (32.70s)
--- PASS: TestAccIAMRolePolicy_basic (38.33s)
--- PASS: TestAccIAMRole_permissionsBoundary (146.10s)
--- PASS: TestAccIAMRolePolicy_nameGenerated (42.17s)
--- PASS: TestAccIAMServerCertificate_path (38.06s)
--- PASS: TestAccIAMServerCertificateDataSource_matchNamePrefix (4.02s)
--- PASS: TestAccIAMServerCertificate_disappears (30.66s)
--- PASS: TestAccIAMRole_tags_EmptyTag_OnUpdate_Add (89.35s)
--- PASS: TestAccIAMServerCertificate_namePrefix (29.85s)
--- PASS: TestAccIAMServerCertificate_nameGenerated (29.84s)
--- PASS: TestAccIAMRole_tags_DefaultTags_overlapping (97.95s)
--- PASS: TestAccIAMRole_tags_DefaultTags_nonOverlapping (98.37s)
--- PASS: TestAccIAMServerCertificateDataSource_path (29.64s)
--- PASS: TestAccIAMServerCertificate_basic (38.53s)
--- PASS: TestAccIAMServerCertificate_file (58.72s)
--- PASS: TestAccIAMServerCertificateDataSource_basic (28.14s)
--- PASS: TestAccIAMSecurityTokenServicePreferences_basic (30.23s)
--- PASS: TestAccIAMSAMLProvider_disappears (30.53s)
--- PASS: TestAccIAMRolesDataSource_nonExistentPathPrefix (25.85s)
--- PASS: TestAccIAMSAMLProviderDataSource_basic (31.02s)
--- PASS: TestAccIAMRolesDataSource_nameRegexAndPathPrefix (29.46s)
--- PASS: TestAccIAMServiceLinkedRole_tags_DefaultTags_overlapping (109.07s)
--- PASS: TestAccIAMRole_tags_DefaultTags_providerOnly (128.16s)
--- PASS: TestAccIAMServiceSpecificCredential_status (83.16s)
--- PASS: TestAccIAMRolesDataSource_pathPrefix (27.92s)
--- PASS: TestAccIAMServiceLinkedRole_tags_DefaultTags_nonOverlapping (110.31s)
--- PASS: TestAccIAMRole_tags (129.20s)
--- PASS: TestAccIAMServerCertificate_tags (82.56s)
--- PASS: TestAccIAMRolesDataSource_basic (24.30s)
--- PASS: TestAccIAMRolesDataSource_nameRegex (30.81s)
--- PASS: TestAccIAMSAMLProvider_basic (56.79s)
--- PASS: TestAccIAMSAMLProvider_tags (80.33s)
--- PASS: TestAccIAMRole_InlinePolicy_outOfBandAdditionRemovedEmpty (51.45s)
--- PASS: TestAccIAMRole_ManagedPolicy_outOfBandAdditionIgnored (47.82s)
--- PASS: TestAccIAMServiceLinkedRole_tags_EmptyTag_OnUpdate_Replace (81.05s)
--- PASS: TestAccIAMRole_InlinePolicy_outOfBandAdditionRemoved (53.39s)
--- PASS: TestAccIAMRolePolicyAttachment_Disappears_role (29.73s)
--- PASS: TestAccIAMUser_ForceDestroy_mfaDevice (35.72s)
--- PASS: TestAccIAMUser_ForceDestroy_sshKey (40.01s)
--- PASS: TestAccIAMServiceLinkedRole_tags_AddOnUpdate (67.11s)
--- PASS: TestAccIAMRole_ManagedPolicy_outOfBandAdditionRemoved (55.96s)
--- PASS: TestAccIAMPolicy_policyDuplicateKeys (3.37s)
--- PASS: TestAccIAMServiceLinkedRole_tags_EmptyTag_OnCreate (76.53s)
--- PASS: TestAccIAMRole_ManagedPolicy_outOfBandRemovalAddedBack (53.31s)
--- PASS: TestAccIAMRole_InlinePolicy_outOfBandAdditionIgnored (64.50s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_updateToProviderOnly (56.10s)
--- PASS: TestAccIAMUser_basic (57.36s)
--- PASS: TestAccIAMRoleDataSource_tags (27.62s)
--- PASS: TestAccIAMRolePolicyAttachment_disappears (30.67s)
--- PASS: TestAccIAMServiceLinkedRole_tags_EmptyTag_OnUpdate_Add (102.08s)
--- PASS: TestAccIAMRoleDataSource_basic (26.21s)
--- PASS: TestAccIAMPrincipalPolicySimulationDataSource_basic (33.02s)
--- PASS: TestAccIAMVirtualMFADevice_path (35.16s)
--- PASS: TestAccIAMRole_ManagedPolicy_basic (80.96s)
--- PASS: TestAccIAMPolicy_disappears (31.05s)
--- PASS: TestAccIAMPolicy_namePrefix (35.82s)
--- PASS: TestAccIAMPolicy_path (39.25s)
--- PASS: TestAccIAMPolicy_description (38.22s)
--- PASS: TestAccIAMRolePolicyAttachment_basic (59.55s)
--- PASS: TestAccIAMPolicy_basic (38.77s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nullOverlappingResourceTag (36.27s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nullNonOverlappingResourceTag (37.36s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_emptyResourceTag (37.19s)
--- PASS: TestAccIAMPolicy_policy (61.86s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_updateToResourceOnly (57.16s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_updateToProviderOnly (59.38s)
--- PASS: TestAccIAMPolicy_whitespace (74.84s)
    policy_document_data_source_test.go:387: skipping tests; current partition (aws) does not equal aws-us-gov
--- SKIP: TestAccIAMPolicyDocumentDataSource_StatementPrincipalIdentifiers_multiplePrincipalsGov (0.00s)
--- PASS: TestAccIAMServiceSpecificCredential_multi (38.49s)
--- PASS: TestAccIAMServiceLinkedRole_tags_DefaultTags_providerOnly (134.01s)
--- PASS: TestAccIAMServiceLinkedRole_tags (135.50s)
--- PASS: TestAccIAMServiceSpecificCredential_basic (37.26s)
--- PASS: TestAccIAMServiceLinkedRole_disappears (39.39s)
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Replace (59.92s)
--- PASS: TestAccIAMPolicy_tags_null (50.01s)
--- PASS: TestAccIAMPolicy_tags_AddOnUpdate (59.94s)
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnCreate (68.69s)
--- PASS: TestAccIAMPolicyDocumentDataSource_StatementPrincipalIdentifiers_multiplePrincipals (25.76s)
--- PASS: TestAccIAMPolicyDocumentDataSource_version20081017 (41.92s)
--- PASS: TestAccIAMVirtualMFADevice_tags_DefaultTags_nullNonOverlappingResourceTag (35.47s)
--- PASS: TestAccIAMVirtualMFADevice_tags_DefaultTags_nullOverlappingResourceTag (34.60s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_overlapping (96.50s)
--- PASS: TestAccIAMPolicy_tags_EmptyTag_OnUpdate_Add (89.13s)
--- PASS: TestAccIAMServiceLinkedRole_CustomSuffix_diffSuppressFunc (46.66s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_nonOverlapping (96.18s)
--- PASS: TestAccIAMServiceLinkedRole_description (71.69s)
--- PASS: TestAccIAMVirtualMFADevice_basic (37.95s)
--- PASS: TestAccIAMVirtualMFADevice_tags_DefaultTags_updateToProviderOnly (62.17s)
--- PASS: TestAccIAMPolicyDocumentDataSource_overridePolicyDocumentValidJSON (26.95s)
--- PASS: TestAccIAMPolicyDocumentDataSource_sourceListConflicting (4.23s)
--- PASS: TestAccIAMUser_disappears (30.79s)
--- PASS: TestAccIAMRole_diffs (380.64s)
--- PASS: TestAccIAMUser_ForceDestroy_accessKey (39.20s)
--- PASS: TestAccIAMOpenidConnectProviderDataSource_basic (31.35s)
--- PASS: TestAccIAMPolicyDocumentDataSource_duplicateSid (26.37s)
--- PASS: TestAccIAMPolicyDocumentDataSource_sourcePolicyValidJSON (26.97s)
--- PASS: TestAccIAMPolicyDocumentDataSource_noStatementOverride (25.99s)
--- PASS: TestAccIAMRole_InlinePolicy_outOfBandRemovalAddedBack (62.03s)
--- PASS: TestAccIAMPolicyDocumentDataSource_noStatementMerge (25.55s)
--- PASS: TestAccIAMPolicyDocumentDataSource_overrideList (24.49s)
--- PASS: TestAccIAMUser_tags_EmptyTag_OnCreate (69.89s)
--- PASS: TestAccIAMPolicyDocumentDataSource_override (26.22s)
--- PASS: TestAccIAMVirtualMFADevice_tags_EmptyTag_OnUpdate_Replace (59.08s)
--- PASS: TestAccIAMPolicy_tags_DefaultTags_providerOnly (127.70s)
--- PASS: TestAccIAMPolicyDocumentDataSource_sourceConflicting (22.79s)
--- PASS: TestAccIAMPolicyDocumentDataSource_sourceList (23.91s)
--- PASS: TestAccIAMPolicyDocumentDataSource_conditionWithBoolValue (24.88s)
--- PASS: TestAccIAMPolicyDocumentDataSource_duplicateConditionKeys (24.93s)
--- PASS: TestAccIAMPolicyDocumentDataSource_multipleConditionKeys (26.70s)
--- PASS: TestAccIAMPolicy_tags (125.68s)
--- PASS: TestAccIAMPolicyDocumentDataSource_singleConditionValue (24.64s)
--- PASS: TestAccIAMPolicyDocumentDataSource_StatementPrincipalIdentifiers_stringAndSlice (24.77s)
--- PASS: TestAccIAMPolicyDocumentDataSource_basic (25.02s)
--- PASS: TestAccIAMPolicyDocumentDataSource_source (43.56s)
--- PASS: TestAccIAMPolicy_diffs (195.18s)
--- PASS: TestAccIAMPolicyDataSource_nameAndPathPrefixTags (25.31s)
--- PASS: TestAccIAMVirtualMFADevice_tags_DefaultTags_overlapping (89.80s)
--- PASS: TestAccIAMRole_ManagedPolicy_outOfBandAdditionRemovedEmpty (50.33s)
--- PASS: TestAccIAMGroup_disappears (23.73s)
--- PASS: TestAccIAMUser_tags_AddOnUpdate (50.68s)
--- PASS: TestAccIAMOpenIDConnectProvider_basic (52.83s)
--- PASS: TestAccIAMUser_tags_null (54.41s)
--- PASS: TestAccIAMVirtualMFADevice_tags_EmptyTag_OnUpdate_Add (99.46s)
--- PASS: TestAccIAMGroup_basic (27.96s)
--- PASS: TestAccIAMGroupDataSource_basic (33.06s)
--- PASS: TestAccIAMGroupPolicyAttachment_basic (54.81s)
--- PASS: TestAccIAMGroup_nameChange (44.69s)
--- PASS: TestAccIAMGroupPolicy_unknownsInPolicy (29.20s)
--- PASS: TestAccIAMVirtualMFADevice_tags_DefaultTags_emptyResourceTag (28.49s)
--- PASS: TestAccIAMOpenIDConnectProvider_tags_DefaultTags_nullNonOverlappingResourceTag (29.54s)
--- PASS: TestAccIAMOpenIDConnectProvider_tags_DefaultTags_nullOverlappingResourceTag (30.88s)
--- PASS: TestAccIAMGroupPolicy_update (46.40s)
--- PASS: TestAccIAMOpenIDConnectProvider_tags_DefaultTags_emptyResourceTag (30.29s)
--- PASS: TestAccIAMGroupMembership_basic (77.47s)
--- PASS: TestAccIAMOpenIDConnectProvider_tags_DefaultTags_updateToResourceOnly (51.28s)
--- PASS: TestAccIAMOpenIDConnectProvider_tags_DefaultTags_updateToProviderOnly (54.60s)
--- PASS: TestAccIAMOpenidConnectProviderDataSource_tags (31.88s)
--- PASS: TestAccIAMOpenidConnectProviderDataSource_url (29.82s)
--- PASS: TestAccIAMGroupPolicy_disappears (31.19s)
--- PASS: TestAccIAMOpenIDConnectProvider_tags_null (45.16s)
--- PASS: TestAccIAMUser_tags (115.40s)
--- PASS: TestAccIAMOpenIDConnectProvider_tags_EmptyTag_OnUpdate_Replace (56.87s)
--- PASS: TestAccIAMOpenIDConnectProvider_tags_AddOnUpdate (54.80s)
--- PASS: TestAccIAMOpenIDConnectProvider_tags_EmptyTag_OnCreate (59.44s)
--- PASS: TestAccIAMAccountPasswordPolicy_serial (84.23s)
    --- PASS: TestAccIAMAccountPasswordPolicy_serial/basic (50.13s)
    --- PASS: TestAccIAMAccountPasswordPolicy_serial/disappears (34.11s)
--- PASS: TestAccIAMOpenIDConnectProvider_tags_DefaultTags_nonOverlapping (76.63s)
--- PASS: TestAccIAMGroupDataSource_users (105.73s)
--- PASS: TestAccIAMGroupPolicy_nameGenerated (31.71s)
--- PASS: TestAccIAMPolicyDataSource_nonExistent (124.76s)
--- PASS: TestAccIAMAccessKeysDataSource_twoKeys (26.14s)
--- PASS: TestAccIAMOpenIDConnectProvider_tags_DefaultTags_overlapping (91.57s)
--- PASS: TestAccIAMOpenIDConnectProvider_tags_EmptyTag_OnUpdate_Add (83.13s)
--- PASS: TestAccIAMGroupPolicy_basic (35.32s)
--- PASS: TestAccIAMUsersDataSource_pathPrefix (30.38s)
--- PASS: TestAccIAMUsersDataSource_nonExistentPathPrefix (27.15s)
--- PASS: TestAccIAMUsersDataSource_nonExistentNameRegex (26.89s)
--- PASS: TestAccIAMGroupMembership_paginatedUserList (142.81s)
--- PASS: TestAccIAMGroupPolicyAttachment_disappears (30.87s)
--- PASS: TestAccIAMVirtualMFADevice_tags_null (47.25s)
--- PASS: TestAccIAMGroupPolicy_namePrefix (38.72s)
--- PASS: TestAccIAMOpenIDConnectProvider_tags_DefaultTags_providerOnly (117.71s)
--- PASS: TestAccIAMUser_tags_DefaultTags_nullOverlappingResourceTag (40.55s)
--- PASS: TestAccIAMUser_tags_DefaultTags_nullNonOverlappingResourceTag (42.32s)
--- PASS: TestAccIAMVirtualMFADevice_tags_AddOnUpdate (60.14s)
--- PASS: TestAccIAMUser_ForceDestroy_loginProfile (46.89s)
--- PASS: TestAccIAMInstanceProfilesDataSource_basic (32.08s)
--- PASS: TestAccIAMInstanceProfile_Disappears_role (32.94s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_emptyResourceTag (37.74s)
--- PASS: TestAccIAMInstanceProfile_disappears (33.96s)
--- PASS: TestAccIAMVirtualMFADevice_tags_DefaultTags_nonOverlapping (89.67s)
--- PASS: TestAccIAMInstanceProfile_namePrefix (42.38s)
--- PASS: TestAccIAMAccessKey_status (92.32s)
--- PASS: TestAccIAMOpenIDConnectProvider_tags (125.24s)
--- PASS: TestAccIAMInstanceProfile_nameGenerated (40.15s)
--- PASS: TestAccIAMInstanceProfile_withoutRole (37.31s)
--- PASS: TestAccIAMUsersDataSource_nameRegex (31.89s)
--- PASS: TestAccIAMInstanceProfile_basic (39.36s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_nullNonOverlappingResourceTag (40.02s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_nullOverlappingResourceTag (38.24s)
--- PASS: TestAccIAMVirtualMFADevice_tags_DefaultTags_updateToResourceOnly (57.51s)
--- PASS: TestAccIAMUser_ForceDestroy_signingCertificate (41.91s)
--- PASS: TestAccIAMAccessKeysDataSource_basic (28.75s)
--- PASS: TestAccIAMUser_pathChange (57.56s)
--- PASS: TestAccIAMAccessKey_encrypted (36.53s)
--- PASS: TestAccIAMVirtualMFADevice_tags_DefaultTags_providerOnly (127.48s)
--- PASS: TestAccIAMUser_nameChange (59.39s)
    account_alias_test.go:134: skipping acceptance testing: AccessDenied
    account_alias_test.go:134: skipping acceptance testing: AccessDenied
--- PASS: TestAccIAMAccountAlias_serial (0.20s)
    --- PASS: TestAccIAMAccountAlias_serial/DataSource (0.05s)
        --- SKIP: TestAccIAMAccountAlias_serial/DataSource/basic (0.05s)
    --- PASS: TestAccIAMAccountAlias_serial/Resource (0.12s)
        --- SKIP: TestAccIAMAccountAlias_serial/Resource/basic (0.12s)
--- PASS: TestAccIAMPolicyDataSource_arnTags (28.72s)
--- PASS: TestAccIAMPolicyDataSource_nameTags (33.31s)
--- PASS: TestAccIAMPolicyDataSource_name (31.75s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_updateToResourceOnly (60.64s)
--- PASS: TestAccIAMVirtualMFADevice_tags (125.21s)
--- PASS: TestAccIAMPolicyDataSource_arn (27.83s)
--- PASS: TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Replace (56.20s)
--- PASS: TestAccIAMInstanceProfileDataSource_basic (30.91s)
--- PASS: TestAccIAMAccessKey_disappears (31.71s)
--- PASS: TestAccIAMInstanceProfile_tags_EmptyTag_OnUpdate_Add (90.64s)
--- PASS: TestAccIAMPolicyDataSource_nameAndPathPrefix (30.09s)
--- PASS: TestAccIAMPolicyAttachment_disappears (31.97s)
--- PASS: TestAccIAMGroup_path (54.43s)
--- PASS: TestAccIAMOpenIDConnectProvider_clientIDListOrder (36.19s)
--- PASS: TestAccIAMInstanceProfile_launchConfiguration (136.66s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_nonOverlapping (89.55s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_overlapping (92.23s)
--- PASS: TestAccIAMOpenIDConnectProvider_disappears (27.41s)
--- PASS: TestAccIAMPolicyAttachment_basic (43.53s)
--- PASS: TestAccIAMUser_tags_DefaultTags_emptyResourceTag (22.45s)
--- PASS: TestAccIAMInstanceProfile_tags_AddOnUpdate (49.03s)
--- PASS: TestAccIAMUser_tags_DefaultTags_updateToResourceOnly (41.23s)
--- PASS: TestAccIAMInstanceProfile_tags_null (38.19s)
--- PASS: TestAccIAMInstanceProfile_tags_DefaultTags_providerOnly (101.74s)
--- PASS: TestAccIAMPolicyAttachment_paginatedEntities (95.50s)
--- PASS: TestAccIAMInstanceProfile_tags_EmptyTag_OnCreate (71.56s)
--- PASS: TestAccIAMUser_permissionsBoundary (132.13s)
--- PASS: TestAccIAMInstanceProfile_tags (96.70s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iam	818.367s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/iam Issues and PRs that pertain to the iam service. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Mar 27, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 27, 2024
@johnsonaj johnsonaj added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Mar 27, 2024
@johnsonaj johnsonaj force-pushed the td-iam_sdkv2_migrate branch from 6df751e to 0119a00 Compare March 27, 2024 21:25
johnsonaj added 20 commits March 27, 2024 18:18
@johnsonaj
aws_iam_access_key: migrate to sdkv2
57b9e8b
@johnsonaj
aws_iam_access_key: datasource migrate to sdkv2
36fb24e
@johnsonaj
aws_iam_account_alias: migrate to sdkv2
4a42ffd
@johnsonaj
aws_iam_account_alias: datasource migrate to sdkv2
fba5bc4
@johnsonaj
aws_iam_account_password_policy: migrate to sdkv2
a093256
@johnsonaj
aws_iam_group: migrate to sdkv2
3ec46e0
@johnsonaj
aws_iam_group: datasource migrate to sdkv2
004f8c6
@johnsonaj
aws_iam_group_membership: migrate to sdkv2
1e0ec81
@johnsonaj
aws_iam_group_policy: migrate to sdkv2
7172f7e
@johnsonaj
aws_iam_instance_profile: migrate to sdkv2
7339114
@johnsonaj
aws_iam_instance_profile: datasource migrate to sdkv2
41b1a38
@johnsonaj
aws_iam_instance_profiles: datasource migrate to sdkv2
da175e9
@johnsonaj
aws_iam_openid_connect_provider: migrate to sdkv2
3275878
@johnsonaj
aws_iam_policy_attachment: migrate to sdkv2
bb91c55
@johnsonaj
aws_iam_policy: migrate to sdkv2
f34ec7d
@johnsonaj
aws_iam_policy: migrate to sdkv2
8b1dc1f
@johnsonaj
aws_iam_principal_policy_simulation: migrate to sdkv2
d4de6c0
@johnsonaj
aws_iam_role: migrate to sdkv2
ea1d85e
@johnsonaj
aws_iam_role: datasource migrate to sdkv2
f868d14
@johnsonaj
aws_iam_server_certificate: migrate to sdkv2
8bd11f8
@johnsonaj johnsonaj force-pushed the td-iam_sdkv2_migrate branch from 31a554e to 5d303ef Compare March 27, 2024 22:24
@johnsonaj johnsonaj marked this pull request as ready for review March 28, 2024 04:09
@github-actions github-actions bot added service/batch Issues and PRs that pertain to the batch service. service/ram Issues and PRs that pertain to the ram service. sweeper Pertains to changes to or issues with the sweeper. labels Mar 28, 2024
ewbankkit
ewbankkit approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@johnsonaj johnsonaj merged commit 02f4db4 into main Mar 28, 2024
61 checks passed
@johnsonaj johnsonaj deleted the td-iam_sdkv2_migrate branch March 28, 2024 12:15
@github-actions github-actions bot added this to the v5.43.0 milestone Mar 28, 2024
github-actions bot pushed a commit that referenced this pull request Mar 28, 2024
Update CHANGELOG.md for #36613
7d8adbd
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.43.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 28, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/batch Issues and PRs that pertain to the batch service. service/iam Issues and PRs that pertain to the iam service. service/ram Issues and PRs that pertain to the ram service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.43.0
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] IAM (Identity & Access Management) Service
2 participants
@johnsonaj @ewbankkit