-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add '.' to name regex in ami_distribution_configuration block for aws_imagebuilder_distribution_configuration #36659
fix: Add '.' to name regex in ami_distribution_configuration block for aws_imagebuilder_distribution_configuration #36659
Conversation
Community NoteVoting for Prioritization
For Submitters
|
…r aws_imagebuilder_distribution_configuration
148c792
to
e2aeb9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_na' PKG=imagebuilder
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/imagebuilder/... -v -count 1 -parallel 20 -run=TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_na -timeout 360m
=== RUN TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_name
=== PAUSE TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_name
=== CONT TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_name
--- PASS: TestAccImageBuilderDistributionConfiguration_DistributionAMIDistribution_name (45.23s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/imagebuilder 56.436s
@acwwat Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.44.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR is to fix the regular expression in the validation function for the
name
arg of theami_distribution_configuration
configuration block for theaws_imagebuilder_distribution_configuration
resource.Relations
Closes #36610
References
Referred to AmiDistributionConfiguration for the correct regular expression.
Output from Acceptance Testing