Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECS Service Alarm Config read uses wrong key #36691

Merged
merged 2 commits into from
Apr 3, 2024
Merged

ECS Service Alarm Config read uses wrong key #36691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2bdfbb
ECS Service Alarm Config read uses wrong key
spangaer Apr 2, 2024
2a2e0b7
Add CHANGELOG entry.
ewbankkit Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/36691.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/aws_ecs_service: Correctly set `alarms.rollback` on resource Create and Update
```
2 changes: 1 addition & 1 deletion internal/service/ecs/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1156,7 +1156,7 @@ func expandAlarms(tfMap map[string]interface{}) *ecs.DeploymentAlarms {
apiObject.Enable = aws.Bool(v)
}

if v, ok := tfMap["enable"].(bool); ok {
if v, ok := tfMap["rollback"].(bool); ok {
apiObject.Rollback = aws.Bool(v)
}

Expand Down
Loading