servicediscovery: Migrate to AWS SDK v2

[mattburgess]

Description

Relations

Closes #36125

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

• Check open pull requests with the dependencies label to view other dependency updates.
• If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
• If this pull request is for supporting a new AWS service:
  • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
  • If this pull request is already a separate pull request from the above item, you can ignore this message.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccServiceDiscovery' PKG=servicediscovery ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/servicediscovery/... -v -count 1 -parallel 4  -run=TestAccServiceDiscovery -timeout 360m
=== RUN   TestAccServiceDiscoveryDNSNamespaceDataSource_private
=== PAUSE TestAccServiceDiscoveryDNSNamespaceDataSource_private
=== RUN   TestAccServiceDiscoveryDNSNamespaceDataSource_public
=== PAUSE TestAccServiceDiscoveryDNSNamespaceDataSource_public
=== RUN   TestAccServiceDiscoveryHTTPNamespaceDataSource_basic
=== PAUSE TestAccServiceDiscoveryHTTPNamespaceDataSource_basic
=== RUN   TestAccServiceDiscoveryHTTPNamespace_basic
=== PAUSE TestAccServiceDiscoveryHTTPNamespace_basic
=== RUN   TestAccServiceDiscoveryHTTPNamespace_disappears
=== PAUSE TestAccServiceDiscoveryHTTPNamespace_disappears
=== RUN   TestAccServiceDiscoveryHTTPNamespace_description
=== PAUSE TestAccServiceDiscoveryHTTPNamespace_description
=== RUN   TestAccServiceDiscoveryHTTPNamespace_tags
=== PAUSE TestAccServiceDiscoveryHTTPNamespace_tags
=== RUN   TestAccServiceDiscoveryInstance_private
=== PAUSE TestAccServiceDiscoveryInstance_private
=== RUN   TestAccServiceDiscoveryInstance_public
=== PAUSE TestAccServiceDiscoveryInstance_public
=== RUN   TestAccServiceDiscoveryInstance_http
=== PAUSE TestAccServiceDiscoveryInstance_http
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_basic
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_basic
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_disappears
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_disappears
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_description
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_description
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_Error_overlap
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_Error_overlap
=== RUN   TestAccServiceDiscoveryPrivateDNSNamespace_tags
=== PAUSE TestAccServiceDiscoveryPrivateDNSNamespace_tags
=== RUN   TestAccServiceDiscoveryPublicDNSNamespace_basic
=== PAUSE TestAccServiceDiscoveryPublicDNSNamespace_basic
=== RUN   TestAccServiceDiscoveryPublicDNSNamespace_disappears
=== PAUSE TestAccServiceDiscoveryPublicDNSNamespace_disappears
=== RUN   TestAccServiceDiscoveryPublicDNSNamespace_description
=== PAUSE TestAccServiceDiscoveryPublicDNSNamespace_description
=== RUN   TestAccServiceDiscoveryPublicDNSNamespace_tags
=== PAUSE TestAccServiceDiscoveryPublicDNSNamespace_tags
=== RUN   TestAccServiceDiscoveryServiceDataSource_basic
=== PAUSE TestAccServiceDiscoveryServiceDataSource_basic
=== RUN   TestAccServiceDiscoveryServiceDataSource_private
=== PAUSE TestAccServiceDiscoveryServiceDataSource_private
=== RUN   TestAccServiceDiscoveryServiceDataSource_public
=== PAUSE TestAccServiceDiscoveryServiceDataSource_public
=== RUN   TestAccServiceDiscoveryService_private
=== PAUSE TestAccServiceDiscoveryService_private
=== RUN   TestAccServiceDiscoveryService_public
=== PAUSE TestAccServiceDiscoveryService_public
=== RUN   TestAccServiceDiscoveryService_private_http
=== PAUSE TestAccServiceDiscoveryService_private_http
=== RUN   TestAccServiceDiscoveryService_http
=== PAUSE TestAccServiceDiscoveryService_http
=== RUN   TestAccServiceDiscoveryService_disappears
=== PAUSE TestAccServiceDiscoveryService_disappears
=== RUN   TestAccServiceDiscoveryService_tags
=== PAUSE TestAccServiceDiscoveryService_tags
=== CONT  TestAccServiceDiscoveryDNSNamespaceDataSource_private
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_tags
=== CONT  TestAccServiceDiscoveryService_tags
=== CONT  TestAccServiceDiscoveryServiceDataSource_public
--- PASS: TestAccServiceDiscoveryServiceDataSource_public (105.92s)
=== CONT  TestAccServiceDiscoveryPublicDNSNamespace_tags
--- PASS: TestAccServiceDiscoveryDNSNamespaceDataSource_private (110.97s)
=== CONT  TestAccServiceDiscoveryServiceDataSource_private
--- PASS: TestAccServiceDiscoveryService_tags (134.28s)
=== CONT  TestAccServiceDiscoveryServiceDataSource_basic
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_tags (146.54s)
=== CONT  TestAccServiceDiscoveryInstance_private
--- PASS: TestAccServiceDiscoveryServiceDataSource_private (109.36s)
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_Error_overlap
--- PASS: TestAccServiceDiscoveryServiceDataSource_basic (103.71s)
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_description
--- PASS: TestAccServiceDiscoveryPublicDNSNamespace_tags (132.44s)
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_disappears
--- PASS: TestAccServiceDiscoveryInstance_private (147.35s)
=== CONT  TestAccServiceDiscoveryPrivateDNSNamespace_basic
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_disappears (107.78s)
=== CONT  TestAccServiceDiscoveryInstance_http
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_description (125.44s)
=== CONT  TestAccServiceDiscoveryInstance_public
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_Error_overlap (172.45s)
=== CONT  TestAccServiceDiscoveryService_private_http
--- PASS: TestAccServiceDiscoveryPrivateDNSNamespace_basic (108.17s)
=== CONT  TestAccServiceDiscoveryService_disappears
--- PASS: TestAccServiceDiscoveryInstance_public (125.99s)
=== CONT  TestAccServiceDiscoveryService_http
--- PASS: TestAccServiceDiscoveryService_disappears (102.98s)
=== CONT  TestAccServiceDiscoveryHTTPNamespace_disappears
--- PASS: TestAccServiceDiscoveryService_private_http (112.25s)
=== CONT  TestAccServiceDiscoveryHTTPNamespace_tags
--- PASS: TestAccServiceDiscoveryInstance_http (171.98s)
=== CONT  TestAccServiceDiscoveryHTTPNamespace_description
--- PASS: TestAccServiceDiscoveryService_http (103.41s)
=== CONT  TestAccServiceDiscoveryHTTPNamespaceDataSource_basic
--- PASS: TestAccServiceDiscoveryHTTPNamespace_disappears (101.61s)
=== CONT  TestAccServiceDiscoveryHTTPNamespace_basic
--- PASS: TestAccServiceDiscoveryHTTPNamespace_description (102.29s)
=== CONT  TestAccServiceDiscoveryService_public
--- PASS: TestAccServiceDiscoveryHTTPNamespace_tags (123.08s)
=== CONT  TestAccServiceDiscoveryPublicDNSNamespace_disappears
--- PASS: TestAccServiceDiscoveryHTTPNamespaceDataSource_basic (102.52s)
=== CONT  TestAccServiceDiscoveryPublicDNSNamespace_description
--- PASS: TestAccServiceDiscoveryHTTPNamespace_basic (106.21s)
=== CONT  TestAccServiceDiscoveryDNSNamespaceDataSource_public
--- PASS: TestAccServiceDiscoveryPublicDNSNamespace_disappears (100.67s)
=== CONT  TestAccServiceDiscoveryPublicDNSNamespace_basic
--- PASS: TestAccServiceDiscoveryService_public (126.62s)
=== CONT  TestAccServiceDiscoveryService_private
--- PASS: TestAccServiceDiscoveryPublicDNSNamespace_description (113.19s)
--- PASS: TestAccServiceDiscoveryDNSNamespaceDataSource_public (102.86s)
--- PASS: TestAccServiceDiscoveryPublicDNSNamespace_basic (105.18s)
--- PASS: TestAccServiceDiscoveryService_private (128.85s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicediscovery	880.440s

[ewbankkit]

@mattburgess Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.