-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Set view_arn and other attrs properly for aws_resourcexplorer2_search data source #36778
Fix: Set view_arn and other attrs properly for aws_resourcexplorer2_search data source #36778
Conversation
Community NoteVoting for Prioritization
For Submitters
|
05cf754
to
8e8925d
Compare
8e8925d
to
536afb6
Compare
…earch data source
536afb6
to
e7114e2
Compare
LGTM 🚀 Thank you for your contribution!
|
This functionality has been released in v5.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR is to fix various functional issues with the
aws_resourceexplorer2_search
data source, including:aws_resourceexplorer2_search
panic #36720view_arn
argument not used in the AWS API callHELP NEEDED FROM MAINTAINERS: While I am able to fix most of the problems, I am still not able to get the
resource.*.properties.*.data
attribute to persist. The data type forData
is JSON, and I tried to useterraform-plugin-framework-jsontypes
to no avail. I believe it is because the AWS return type is an actual object and not a JSON string. With the Terraform Plugin Framework, I am not sure how we can properly map the data to Terraform types. I can only think of using a Dynamic data type or somehow encode the JSON and store it as so, since there's no set schema withData
. I would like a maintainer to assist with fixing this case - let me know how else I can help. Thanks.Relations
Closes #36720
Closes #36721
References
Output from Acceptance Testing