Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS SDK for Go v2 MaxBackoff delay to match AWS SDK for Go v1 default #36855

Merged
merged 5 commits into from
Apr 11, 2024
Merged

AWS SDK for Go v2 MaxBackoff delay to match AWS SDK for Go v1 default #36855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
301e7ca
Run 'go get github.com/hashicorp/aws-sdk-go-base/v2@b78c18eb91aec33ce…
ewbankkit Apr 11, 2024
772a502
Set AWS SDK for Go v2 API client MaxBackoff to 300s, the AWS SDK for …
ewbankkit Apr 11, 2024
429ef4a
Add CHANGELOG entry.
ewbankkit Apr 11, 2024
77a11ef
Revert "Run 'go get github.com/hashicorp/aws-sdk-go-base/v2@b78c18eb9…
ewbankkit Apr 11, 2024
9c28e9f
Merge branch 'main' into f-config.MaxBackoff
ewbankkit Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/36855.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
provider: Change the default AWS SDK for Go v2 API client [`MaxBackoff`](https://aws.github.io/aws-sdk-go-v2/docs/configuring-sdk/retries-timeouts/#limiting-the-max-back-off-delay) value to 300 seconds so that services migrated to AWS SDK for Go v2 maintain behavioral compatibility with AWS SDK for Go v1
```
2 changes: 2 additions & 0 deletions internal/conns/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"context"
"fmt"
"strings"
"time"

aws_sdkv2 "github.com/aws/aws-sdk-go-v2/aws"
imds_sdkv2 "github.com/aws/aws-sdk-go-v2/feature/ec2/imds"
Expand Down Expand Up @@ -91,6 +92,7 @@ func (c *Config) ConfigureProvider(ctx context.Context, client *AWSClient) (*AWS
HTTPSProxy: c.HTTPSProxy,
HTTPProxyMode: awsbase.HTTPProxyModeLegacy,
Logger: logger,
MaxBackoff: 300 * time.Second, // AWS SDK for Go v1 DefaultRetryerMaxRetryDelay: https://github.com/aws/aws-sdk-go/blob/9f6e3bb9f523aef97fa1cd5c5f8ba8ecf212e44e/aws/client/default_retryer.go#L48-L49.
MaxRetries: c.MaxRetries,
NoProxy: c.NoProxy,
Profile: c.Profile,
Expand Down
Loading