Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_backup_restore_testing_plan: Adding resource for managing AWS Backup Restore Testing plans #36907

Conversation

bkumar5-atlassian
Copy link

Description

Adding resource to manage AWS Backup Restore Testing plans: aws_backup_restore_testing_plan

Relations

Relates #34699

References

Output from Acceptance Testing

make testacc TESTS=TestAccRestoreTestingPlan PKG=backup
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/backup/... -v -count 1 -parallel 20 -run='TestAccRestoreTestingPlan'  -timeout 360m
=== RUN   TestAccRestoreTestingPlan_basic
=== PAUSE TestAccRestoreTestingPlan_basic
=== RUN   TestAccRestoreTestingPlan_disappears
=== PAUSE TestAccRestoreTestingPlan_disappears
=== RUN   TestAccRestoreTestingPlan_withTags
=== PAUSE TestAccRestoreTestingPlan_withTags
=== RUN   TestAccRestoreTestingPlan_updateRecoveryPointSelection
=== PAUSE TestAccRestoreTestingPlan_updateRecoveryPointSelection
=== RUN   TestAccRestoreTestingPlan_withOptionalArguments
=== PAUSE TestAccRestoreTestingPlan_withOptionalArguments
=== CONT  TestAccRestoreTestingPlan_basic
=== CONT  TestAccRestoreTestingPlan_updateRecoveryPointSelection
=== CONT  TestAccRestoreTestingPlan_withTags
=== CONT  TestAccRestoreTestingPlan_disappears
=== CONT  TestAccRestoreTestingPlan_withOptionalArguments
--- PASS: TestAccRestoreTestingPlan_disappears (19.25s)
--- PASS: TestAccRestoreTestingPlan_basic (22.74s)
--- PASS: TestAccRestoreTestingPlan_withTags (47.81s)
--- PASS: TestAccRestoreTestingPlan_updateRecoveryPointSelection (47.87s)
--- PASS: TestAccRestoreTestingPlan_withOptionalArguments (48.06s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/backup     54.161s
...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/backup Issues and PRs that pertain to the backup service. generators Relates to code generators. labels Apr 15, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 15, 2024
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 15, 2024
@Thomas-Franklin
Copy link
Contributor

Hi @bkumar5-atlassian , I had also started work on this last week #37039 and submitted it this morning only to see you've already proposed it as a resource, not sure if this causes problems and hopefully we can get traction on one of them.

@mervin-hemaraju-cko
Copy link

Heyy, when is this getting merged?

@jeroenhabets
Copy link

Please be aware there are two open PRs on this. This one and #37039

@jeroenhabets
Copy link

It seems competing PR #37039 is about to get merged...

Copy link

github-actions bot commented Nov 4, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/backup Issues and PRs that pertain to the backup service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants