Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rum: Migrate to AWS SDK v2 #36966

Merged
merged 9 commits into from
Jun 17, 2024
Merged

Conversation

mattburgess
Copy link
Collaborator

@mattburgess mattburgess commented Apr 17, 2024

Description

Relations

Closes #36129.
Closes #33182.

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/rum Issues and PRs that pertain to the rum service. labels Apr 17, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Apr 17, 2024
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@justinretzolk justinretzolk added aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. and removed needs-triage Waiting for first response or review from a maintainer. labels May 1, 2024
# Conflicts:
#	go.mod
#	go.sum
#	internal/conns/awsclient_gen.go
#	internal/service/rum/app_monitor.go
#	internal/service/rum/metrics_destination.go
#	internal/service/rum/service_endpoints_gen_test.go
#	internal/service/rum/service_package_gen.go
#	names/data/names_data.csv
#	names/names.go
@ewbankkit ewbankkit requested a review from a team as a code owner June 14, 2024 15:14
@ewbankkit ewbankkit self-assigned this Jun 14, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 14, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRUM' PKG=rum ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/rum/... -v -count 1 -parallel 3  -run=TestAccRUM -timeout 360m
=== RUN   TestAccRUMAppMonitor_basic
=== PAUSE TestAccRUMAppMonitor_basic
=== RUN   TestAccRUMAppMonitor_customEvents
=== PAUSE TestAccRUMAppMonitor_customEvents
=== RUN   TestAccRUMAppMonitor_tags
=== PAUSE TestAccRUMAppMonitor_tags
=== RUN   TestAccRUMAppMonitor_disappears
=== PAUSE TestAccRUMAppMonitor_disappears
=== RUN   TestAccRUMMetricsDestination_basic
=== PAUSE TestAccRUMMetricsDestination_basic
=== RUN   TestAccRUMMetricsDestination_disappears
=== PAUSE TestAccRUMMetricsDestination_disappears
=== RUN   TestAccRUMMetricsDestination_disappears_appMonitor
=== PAUSE TestAccRUMMetricsDestination_disappears_appMonitor
=== CONT  TestAccRUMAppMonitor_basic
=== CONT  TestAccRUMMetricsDestination_basic
=== CONT  TestAccRUMMetricsDestination_disappears_appMonitor
--- PASS: TestAccRUMMetricsDestination_disappears_appMonitor (22.89s)
=== CONT  TestAccRUMMetricsDestination_disappears
--- PASS: TestAccRUMMetricsDestination_basic (24.53s)
=== CONT  TestAccRUMAppMonitor_tags
--- PASS: TestAccRUMAppMonitor_basic (38.42s)
=== CONT  TestAccRUMAppMonitor_disappears
--- PASS: TestAccRUMMetricsDestination_disappears (18.93s)
=== CONT  TestAccRUMAppMonitor_customEvents
--- PASS: TestAccRUMAppMonitor_disappears (17.82s)
--- PASS: TestAccRUMAppMonitor_tags (48.49s)
--- PASS: TestAccRUMAppMonitor_customEvents (48.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/rum	95.196s
% make testacc TESTARGS='-run=TestAccVPCNetworkInsights' PKG=ec2 ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 4  -run=TestAccVPCNetworkInsights -timeout 360m
=== RUN   TestAccVPCNetworkInsightsAnalysisDataSource_basic
=== PAUSE TestAccVPCNetworkInsightsAnalysisDataSource_basic
=== RUN   TestAccVPCNetworkInsightsAnalysis_basic
=== PAUSE TestAccVPCNetworkInsightsAnalysis_basic
=== RUN   TestAccVPCNetworkInsightsAnalysis_disappears
=== PAUSE TestAccVPCNetworkInsightsAnalysis_disappears
=== RUN   TestAccVPCNetworkInsightsAnalysis_tags
=== PAUSE TestAccVPCNetworkInsightsAnalysis_tags
=== RUN   TestAccVPCNetworkInsightsAnalysis_filterInARNs
=== PAUSE TestAccVPCNetworkInsightsAnalysis_filterInARNs
=== RUN   TestAccVPCNetworkInsightsAnalysis_waitForCompletion
=== PAUSE TestAccVPCNetworkInsightsAnalysis_waitForCompletion
=== RUN   TestAccVPCNetworkInsightsPathDataSource_basic
=== PAUSE TestAccVPCNetworkInsightsPathDataSource_basic
=== RUN   TestAccVPCNetworkInsightsPath_basic
=== PAUSE TestAccVPCNetworkInsightsPath_basic
=== RUN   TestAccVPCNetworkInsightsPath_disappears
=== PAUSE TestAccVPCNetworkInsightsPath_disappears
=== RUN   TestAccVPCNetworkInsightsPath_tags
=== PAUSE TestAccVPCNetworkInsightsPath_tags
=== RUN   TestAccVPCNetworkInsightsPath_sourceAndDestinationARN
=== PAUSE TestAccVPCNetworkInsightsPath_sourceAndDestinationARN
=== RUN   TestAccVPCNetworkInsightsPath_sourceIP
=== PAUSE TestAccVPCNetworkInsightsPath_sourceIP
=== RUN   TestAccVPCNetworkInsightsPath_destinationIP
=== PAUSE TestAccVPCNetworkInsightsPath_destinationIP
=== RUN   TestAccVPCNetworkInsightsPath_destinationPort
=== PAUSE TestAccVPCNetworkInsightsPath_destinationPort
=== CONT  TestAccVPCNetworkInsightsAnalysisDataSource_basic
=== CONT  TestAccVPCNetworkInsightsPath_basic
=== CONT  TestAccVPCNetworkInsightsAnalysis_filterInARNs
=== CONT  TestAccVPCNetworkInsightsPathDataSource_basic
--- PASS: TestAccVPCNetworkInsightsPathDataSource_basic (14.98s)
=== CONT  TestAccVPCNetworkInsightsAnalysis_disappears
--- PASS: TestAccVPCNetworkInsightsPath_basic (16.70s)
=== CONT  TestAccVPCNetworkInsightsAnalysis_tags
--- PASS: TestAccVPCNetworkInsightsAnalysisDataSource_basic (57.23s)
=== CONT  TestAccVPCNetworkInsightsPath_sourceIP
--- PASS: TestAccVPCNetworkInsightsAnalysis_disappears (48.61s)
=== CONT  TestAccVPCNetworkInsightsPath_destinationPort
--- PASS: TestAccVPCNetworkInsightsPath_sourceIP (40.43s)
=== CONT  TestAccVPCNetworkInsightsPath_destinationIP
--- PASS: TestAccVPCNetworkInsightsAnalysis_tags (81.02s)
=== CONT  TestAccVPCNetworkInsightsAnalysis_waitForCompletion
--- PASS: TestAccVPCNetworkInsightsPath_destinationPort (38.25s)
=== CONT  TestAccVPCNetworkInsightsPath_tags
--- PASS: TestAccVPCNetworkInsightsAnalysis_waitForCompletion (24.08s)
=== CONT  TestAccVPCNetworkInsightsPath_sourceAndDestinationARN
--- PASS: TestAccVPCNetworkInsightsPath_destinationIP (24.95s)
=== CONT  TestAccVPCNetworkInsightsAnalysis_basic
--- PASS: TestAccVPCNetworkInsightsPath_tags (32.75s)
=== CONT  TestAccVPCNetworkInsightsPath_disappears
--- PASS: TestAccVPCNetworkInsightsPath_sourceAndDestinationARN (15.91s)
--- PASS: TestAccVPCNetworkInsightsPath_disappears (17.49s)
--- PASS: TestAccVPCNetworkInsightsAnalysis_filterInARNs (153.01s)
--- PASS: TestAccVPCNetworkInsightsAnalysis_basic (73.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	200.762s

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/vpc Issues and PRs that pertain to the vpc service. labels Jun 14, 2024
# Conflicts:
#	names/data/names_data.csv
@ewbankkit ewbankkit merged commit a559ca0 into hashicorp:main Jun 17, 2024
51 checks passed
@github-actions github-actions bot added this to the v5.55.0 milestone Jun 17, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 20, 2024
Copy link

This functionality has been released in v5.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/rum Issues and PRs that pertain to the rum service. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
3 participants