Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_bedrockagent_knowledge_base: Aurora Cluster is publicly accessible in acceptance tests #37109

Merged
merged 10 commits into from
Apr 26, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Apr 25, 2024

Description

Makes the Aurora Cluster used in aws_bedrockagent_knowledge_base acceptance tests publicly accessible so that tests can be run from a laptop.

Relations

Relates #36783.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccBedrockAgent_serial/KnowledgeBase/basicRDS\|TestAccBedrockAgent_serial/KnowledgeBase/disappears\|TestAccBedrockAgent_serial/KnowledgeBase/tags' PKG=bedrockagent ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/bedrockagent/... -v -count 1 -parallel 1  -run=TestAccBedrockAgent_serial/KnowledgeBase/basicRDS\|TestAccBedrockAgent_serial/KnowledgeBase/disappears\|TestAccBedrockAgent_serial/KnowledgeBase/tags -timeout 360m
=== RUN   TestAccBedrockAgent_serial
=== PAUSE TestAccBedrockAgent_serial
=== CONT  TestAccBedrockAgent_serial
=== RUN   TestAccBedrockAgent_serial/KnowledgeBase
=== RUN   TestAccBedrockAgent_serial/KnowledgeBase/basicRDS
=== RUN   TestAccBedrockAgent_serial/KnowledgeBase/disappears
=== RUN   TestAccBedrockAgent_serial/KnowledgeBase/tags
--- PASS: TestAccBedrockAgent_serial (4183.96s)
    --- PASS: TestAccBedrockAgent_serial/KnowledgeBase (4183.96s)
        --- PASS: TestAccBedrockAgent_serial/KnowledgeBase/basicRDS (1722.32s)
        --- PASS: TestAccBedrockAgent_serial/KnowledgeBase/disappears (1619.73s)
        --- PASS: TestAccBedrockAgent_serial/KnowledgeBase/tags (1983.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent	4195.500s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/rds Issues and PRs that pertain to the rds service. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. labels Apr 25, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Apr 25, 2024
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@ewbankkit ewbankkit merged commit fb116e6 into main Apr 26, 2024
36 checks passed
@ewbankkit ewbankkit deleted the t-aws_bedrockagent_knowledge_base.rds-public-access branch April 26, 2024 13:10
@github-actions github-actions bot added this to the v5.48.0 milestone Apr 26, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 2, 2024
Copy link

github-actions bot commented May 2, 2024

This functionality has been released in v5.48.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jun 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/bedrockagent Issues and PRs that pertain to the bedrockagent service. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant