Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix by_provider regex for aws_bedrock_foundation_models data source #37306

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented May 7, 2024

Description

This PR is to fix the regex for the by_provider argument in the aws_bedrock_foundation_models data source.

Relations

Closes #37305

References

Referred to ListFoundationModels for the correct regex.

Output from Acceptance Testing

$ make testacc TESTS=TestAccBedrockFoundationModelsDataSource_ PKG=bedrock
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/bedrock/... -v -count 1 -parallel 20 -run='TestAccBedrockFoundationModelsDataSource_'  -timeout 360m
=== RUN   TestAccBedrockFoundationModelsDataSource_basic
=== PAUSE TestAccBedrockFoundationModelsDataSource_basic
=== RUN   TestAccBedrockFoundationModelsDataSource_byCustomizationType
=== PAUSE TestAccBedrockFoundationModelsDataSource_byCustomizationType
=== RUN   TestAccBedrockFoundationModelsDataSource_byInferenceType
=== PAUSE TestAccBedrockFoundationModelsDataSource_byInferenceType
=== RUN   TestAccBedrockFoundationModelsDataSource_byOutputModality
=== PAUSE TestAccBedrockFoundationModelsDataSource_byOutputModality
=== RUN   TestAccBedrockFoundationModelsDataSource_byProvider
=== PAUSE TestAccBedrockFoundationModelsDataSource_byProvider
=== CONT  TestAccBedrockFoundationModelsDataSource_basic
=== CONT  TestAccBedrockFoundationModelsDataSource_byOutputModality
=== CONT  TestAccBedrockFoundationModelsDataSource_byProvider
=== CONT  TestAccBedrockFoundationModelsDataSource_byInferenceType
=== CONT  TestAccBedrockFoundationModelsDataSource_byCustomizationType
--- PASS: TestAccBedrockFoundationModelsDataSource_byCustomizationType (13.40s)
--- PASS: TestAccBedrockFoundationModelsDataSource_byProvider (13.40s)
--- PASS: TestAccBedrockFoundationModelsDataSource_byInferenceType (13.51s)
--- PASS: TestAccBedrockFoundationModelsDataSource_byOutputModality (13.82s)
--- PASS: TestAccBedrockFoundationModelsDataSource_basic (13.90s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrock    14.088s

Copy link

github-actions bot commented May 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/bedrock Issues and PRs that pertain to the bedrock service. labels May 7, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels May 7, 2024
@acwwat acwwat force-pushed the b-aws_bedrock_foundational_models-fix_data_source_provider_regex branch from 3ad5c7f to a8dba3f Compare May 7, 2024 02:36
@acwwat acwwat changed the title [WIP] fix: Fix by_provider regex for aws_bedrock_foundation_models data source fix: Fix by_provider regex for aws_bedrock_foundation_models data source May 7, 2024
@acwwat acwwat changed the title fix: Fix by_provider regex for aws_bedrock_foundation_models data source fix: Fix by_provider regex for aws_bedrock_foundation_models data source May 7, 2024
@LowlySysadmin
Copy link

Thank you so much for this speedy fix @acwwat ! 🏆 ❤️

@justinretzolk justinretzolk added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. and removed needs-triage Waiting for first response or review from a maintainer. labels May 8, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@acwwat Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 805ca6d into hashicorp:main May 13, 2024
64 checks passed
@github-actions github-actions bot added this to the v5.50.0 milestone May 13, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 17, 2024
Copy link

This functionality has been released in v5.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@acwwat acwwat deleted the b-aws_bedrock_foundational_models-fix_data_source_provider_regex branch May 18, 2024 17:08
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-maintainer Contribution from a trusted external contributor. service/bedrock Issues and PRs that pertain to the bedrock service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: aws_bedrock_foundation_models data source has incorrect regex validation for by_provider
4 participants