Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate vpnsite resources to AWS Go SDKv2 #37409

Merged
merged 20 commits into from
May 21, 2024
Merged

Migrate vpnsite resources to AWS Go SDKv2 #37409

merged 20 commits into from
May 21, 2024

Conversation

DanielRieske
Copy link
Contributor

@DanielRieske DanielRieske commented May 9, 2024 •
edited
Loading

Description

This PR migrates vpnsite resources to AWS SDKv2

And fixes TestAccSiteVPNCustomerGateway_certificate in #35747

Relations

Relates #35747

Closes #36222

References

Output from Acceptance Testing

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 1  -run=TestAccSiteVPN -timeout 360m
=== RUN   TestAccSiteVPNConnectionRoute_basic
=== PAUSE TestAccSiteVPNConnectionRoute_basic
=== RUN   TestAccSiteVPNConnectionRoute_disappears
=== PAUSE TestAccSiteVPNConnectionRoute_disappears
=== RUN   TestAccSiteVPNConnection_basic
=== PAUSE TestAccSiteVPNConnection_basic
=== RUN   TestAccSiteVPNConnection_withoutTGWorVGW
=== PAUSE TestAccSiteVPNConnection_withoutTGWorVGW
=== RUN   TestAccSiteVPNConnection_cloudWatchLogOptions
=== PAUSE TestAccSiteVPNConnection_cloudWatchLogOptions
=== RUN   TestAccSiteVPNConnection_transitGatewayID
=== PAUSE TestAccSiteVPNConnection_transitGatewayID
=== RUN   TestAccSiteVPNConnection_tunnel1InsideCIDR
=== PAUSE TestAccSiteVPNConnection_tunnel1InsideCIDR
=== RUN   TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR
=== PAUSE TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR
=== RUN   TestAccSiteVPNConnection_tunnel1PreSharedKey
=== PAUSE TestAccSiteVPNConnection_tunnel1PreSharedKey
=== RUN   TestAccSiteVPNConnection_tunnelOptions
=== PAUSE TestAccSiteVPNConnection_tunnelOptions
=== RUN   TestAccSiteVPNConnection_tunnelOptionsLesser
=== PAUSE TestAccSiteVPNConnection_tunnelOptionsLesser
=== RUN   TestAccSiteVPNConnection_staticRoutes
=== PAUSE TestAccSiteVPNConnection_staticRoutes
=== RUN   TestAccSiteVPNConnection_outsideAddressTypePrivate
=== PAUSE TestAccSiteVPNConnection_outsideAddressTypePrivate
=== RUN   TestAccSiteVPNConnection_outsideAddressTypePublic
=== PAUSE TestAccSiteVPNConnection_outsideAddressTypePublic
=== RUN   TestAccSiteVPNConnection_enableAcceleration
=== PAUSE TestAccSiteVPNConnection_enableAcceleration
=== RUN   TestAccSiteVPNConnection_ipv6
=== PAUSE TestAccSiteVPNConnection_ipv6
=== RUN   TestAccSiteVPNConnection_tags
=== PAUSE TestAccSiteVPNConnection_tags
=== RUN   TestAccSiteVPNConnection_specifyIPv4
=== PAUSE TestAccSiteVPNConnection_specifyIPv4
=== RUN   TestAccSiteVPNConnection_specifyIPv6
=== PAUSE TestAccSiteVPNConnection_specifyIPv6
=== RUN   TestAccSiteVPNConnection_disappears
=== PAUSE TestAccSiteVPNConnection_disappears
=== RUN   TestAccSiteVPNConnection_updateCustomerGatewayID
=== PAUSE TestAccSiteVPNConnection_updateCustomerGatewayID
=== RUN   TestAccSiteVPNConnection_updateVPNGatewayID
=== PAUSE TestAccSiteVPNConnection_updateVPNGatewayID
=== RUN   TestAccSiteVPNConnection_updateTransitGatewayID
=== PAUSE TestAccSiteVPNConnection_updateTransitGatewayID
=== RUN   TestAccSiteVPNConnection_vpnGatewayIDToTransitGatewayID
=== PAUSE TestAccSiteVPNConnection_vpnGatewayIDToTransitGatewayID
=== RUN   TestAccSiteVPNConnection_transitGatewayIDToVPNGatewayID
=== PAUSE TestAccSiteVPNConnection_transitGatewayIDToVPNGatewayID
=== RUN   TestAccSiteVPNCustomerGatewayDataSource_filter
=== PAUSE TestAccSiteVPNCustomerGatewayDataSource_filter
=== RUN   TestAccSiteVPNCustomerGatewayDataSource_id
=== PAUSE TestAccSiteVPNCustomerGatewayDataSource_id
=== RUN   TestAccSiteVPNCustomerGateway_basic
=== PAUSE TestAccSiteVPNCustomerGateway_basic
=== RUN   TestAccSiteVPNCustomerGateway_disappears
=== PAUSE TestAccSiteVPNCustomerGateway_disappears
=== RUN   TestAccSiteVPNCustomerGateway_tags
=== PAUSE TestAccSiteVPNCustomerGateway_tags
=== RUN   TestAccSiteVPNCustomerGateway_deviceName
=== PAUSE TestAccSiteVPNCustomerGateway_deviceName
=== RUN   TestAccSiteVPNCustomerGateway_4ByteASN
=== PAUSE TestAccSiteVPNCustomerGateway_4ByteASN
=== RUN   TestAccSiteVPNCustomerGateway_certificate
=== PAUSE TestAccSiteVPNCustomerGateway_certificate
=== RUN   TestAccSiteVPNGatewayAttachment_basic
=== PAUSE TestAccSiteVPNGatewayAttachment_basic
=== RUN   TestAccSiteVPNGatewayAttachment_disappears
=== PAUSE TestAccSiteVPNGatewayAttachment_disappears
=== RUN   TestAccSiteVPNGatewayDataSource_unattached
=== PAUSE TestAccSiteVPNGatewayDataSource_unattached
=== RUN   TestAccSiteVPNGatewayDataSource_attached
=== PAUSE TestAccSiteVPNGatewayDataSource_attached
=== RUN   TestAccSiteVPNGatewayRoutePropagation_basic
=== PAUSE TestAccSiteVPNGatewayRoutePropagation_basic
=== RUN   TestAccSiteVPNGatewayRoutePropagation_disappears
=== PAUSE TestAccSiteVPNGatewayRoutePropagation_disappears
=== RUN   TestAccSiteVPNGateway_basic
=== PAUSE TestAccSiteVPNGateway_basic
=== RUN   TestAccSiteVPNGateway_withAvailabilityZoneSetToState
=== PAUSE TestAccSiteVPNGateway_withAvailabilityZoneSetToState
=== RUN   TestAccSiteVPNGateway_amazonSideASN
=== PAUSE TestAccSiteVPNGateway_amazonSideASN
=== RUN   TestAccSiteVPNGateway_disappears
=== PAUSE TestAccSiteVPNGateway_disappears
=== RUN   TestAccSiteVPNGateway_reattach
=== PAUSE TestAccSiteVPNGateway_reattach
=== RUN   TestAccSiteVPNGateway_tags
=== PAUSE TestAccSiteVPNGateway_tags
=== CONT  TestAccSiteVPNConnectionRoute_basic
--- PASS: TestAccSiteVPNConnectionRoute_basic (240.37s)
=== CONT  TestAccSiteVPNConnection_vpnGatewayIDToTransitGatewayID
--- PASS: TestAccSiteVPNConnection_vpnGatewayIDToTransitGatewayID (660.38s)
=== CONT  TestAccSiteVPNGateway_tags
--- PASS: TestAccSiteVPNGateway_tags (114.36s)
=== CONT  TestAccSiteVPNGateway_reattach
--- PASS: TestAccSiteVPNGateway_reattach (404.48s)
=== CONT  TestAccSiteVPNGateway_disappears
--- PASS: TestAccSiteVPNGateway_disappears (154.57s)
=== CONT  TestAccSiteVPNGateway_amazonSideASN
--- PASS: TestAccSiteVPNGateway_amazonSideASN (115.60s)
=== CONT  TestAccSiteVPNGateway_withAvailabilityZoneSetToState
--- PASS: TestAccSiteVPNGateway_withAvailabilityZoneSetToState (127.40s)
=== CONT  TestAccSiteVPNGateway_basic
--- PASS: TestAccSiteVPNGateway_basic (273.76s)
=== CONT  TestAccSiteVPNGatewayRoutePropagation_disappears
--- PASS: TestAccSiteVPNGatewayRoutePropagation_disappears (135.06s)
=== CONT  TestAccSiteVPNGatewayRoutePropagation_basic
--- PASS: TestAccSiteVPNGatewayRoutePropagation_basic (135.18s)
=== CONT  TestAccSiteVPNGatewayDataSource_attached
--- PASS: TestAccSiteVPNGatewayDataSource_attached (139.72s)
=== CONT  TestAccSiteVPNGatewayDataSource_unattached
--- PASS: TestAccSiteVPNGatewayDataSource_unattached (37.61s)
=== CONT  TestAccSiteVPNGatewayAttachment_disappears
--- PASS: TestAccSiteVPNGatewayAttachment_disappears (182.68s)
=== CONT  TestAccSiteVPNGatewayAttachment_basic
--- PASS: TestAccSiteVPNGatewayAttachment_basic (119.58s)
=== CONT  TestAccSiteVPNCustomerGateway_certificate
--- PASS: TestAccSiteVPNCustomerGateway_certificate (81.19s)
=== CONT  TestAccSiteVPNCustomerGateway_4ByteASN
--- PASS: TestAccSiteVPNCustomerGateway_4ByteASN (28.47s)
=== CONT  TestAccSiteVPNCustomerGateway_deviceName
--- PASS: TestAccSiteVPNCustomerGateway_deviceName (28.32s)
=== CONT  TestAccSiteVPNCustomerGateway_tags
--- PASS: TestAccSiteVPNCustomerGateway_tags (51.68s)
=== CONT  TestAccSiteVPNCustomerGateway_disappears
--- PASS: TestAccSiteVPNCustomerGateway_disappears (26.06s)
=== CONT  TestAccSiteVPNCustomerGateway_basic
--- PASS: TestAccSiteVPNCustomerGateway_basic (28.96s)
=== CONT  TestAccSiteVPNCustomerGatewayDataSource_id
--- PASS: TestAccSiteVPNCustomerGatewayDataSource_id (26.31s)
=== CONT  TestAccSiteVPNCustomerGatewayDataSource_filter
--- PASS: TestAccSiteVPNCustomerGatewayDataSource_filter (26.24s)
=== CONT  TestAccSiteVPNConnection_transitGatewayIDToVPNGatewayID
--- PASS: TestAccSiteVPNConnection_transitGatewayIDToVPNGatewayID (714.85s)
=== CONT  TestAccSiteVPNConnection_specifyIPv6
--- PASS: TestAccSiteVPNConnection_specifyIPv6 (479.04s)
=== CONT  TestAccSiteVPNConnection_updateTransitGatewayID
--- PASS: TestAccSiteVPNConnection_updateTransitGatewayID (784.75s)
=== CONT  TestAccSiteVPNConnection_updateVPNGatewayID
--- PASS: TestAccSiteVPNConnection_updateVPNGatewayID (615.99s)
=== CONT  TestAccSiteVPNConnection_updateCustomerGatewayID
--- PASS: TestAccSiteVPNConnection_updateCustomerGatewayID (605.41s)
=== CONT  TestAccSiteVPNConnection_disappears
--- PASS: TestAccSiteVPNConnection_disappears (237.33s)
=== CONT  TestAccSiteVPNConnection_tunnel1InsideCIDR
--- PASS: TestAccSiteVPNConnection_tunnel1InsideCIDR (236.24s)
=== CONT  TestAccSiteVPNConnection_staticRoutes
--- PASS: TestAccSiteVPNConnection_staticRoutes (239.41s)
=== CONT  TestAccSiteVPNConnection_tunnelOptionsLesser
--- PASS: TestAccSiteVPNConnection_tunnelOptionsLesser (1465.69s)
=== CONT  TestAccSiteVPNConnection_tunnelOptions
--- PASS: TestAccSiteVPNConnection_tunnelOptions (248.11s)
=== CONT  TestAccSiteVPNConnection_tunnel1PreSharedKey
--- PASS: TestAccSiteVPNConnection_tunnel1PreSharedKey (237.38s)
=== CONT  TestAccSiteVPNConnection_outsideAddressTypePrivate
--- PASS: TestAccSiteVPNConnection_outsideAddressTypePrivate (1719.36s)
=== CONT  TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR
--- PASS: TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR (50.20s)
=== CONT  TestAccSiteVPNConnection_specifyIPv4
--- PASS: TestAccSiteVPNConnection_specifyIPv4 (574.67s)
=== CONT  TestAccSiteVPNConnection_ipv6
--- PASS: TestAccSiteVPNConnection_ipv6 (461.21s)
=== CONT  TestAccSiteVPNConnection_enableAcceleration
--- PASS: TestAccSiteVPNConnection_enableAcceleration (926.11s)
=== CONT  TestAccSiteVPNConnection_tags
--- PASS: TestAccSiteVPNConnection_tags (265.42s)
=== CONT  TestAccSiteVPNConnection_outsideAddressTypePublic
--- PASS: TestAccSiteVPNConnection_outsideAddressTypePublic (239.29s)
=== CONT  TestAccSiteVPNConnection_withoutTGWorVGW
--- PASS: TestAccSiteVPNConnection_withoutTGWorVGW (53.13s)
=== CONT  TestAccSiteVPNConnection_transitGatewayID
--- PASS: TestAccSiteVPNConnection_transitGatewayID (410.46s)
=== CONT  TestAccSiteVPNConnection_basic
--- PASS: TestAccSiteVPNConnection_basic (239.02s)
=== CONT  TestAccSiteVPNConnection_cloudWatchLogOptions
--- PASS: TestAccSiteVPNConnection_cloudWatchLogOptions (585.99s)
=== CONT  TestAccSiteVPNConnectionRoute_disappears
--- PASS: TestAccSiteVPNConnectionRoute_disappears (240.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	14771.640s

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/vpnsite Issues and PRs that pertain to the vpnsite service. and removed size/XL Managed by automation to categorize the size of a PR. labels May 9, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels May 9, 2024
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label May 11, 2024
@DanielRieske DanielRieske marked this pull request as ready for review May 13, 2024 11:01
@justinretzolk justinretzolk added aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. and removed needs-triage Waiting for first response or review from a maintainer. labels May 13, 2024
ewbankkit
ewbankkit approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCMainRouteTableAssociation_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccVPCMainRouteTableAssociation_ -timeout 360m
=== RUN   TestAccVPCMainRouteTableAssociation_basic
=== PAUSE TestAccVPCMainRouteTableAssociation_basic
=== CONT  TestAccVPCMainRouteTableAssociation_basic
--- PASS: TestAccVPCMainRouteTableAssociation_basic (33.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	38.192s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccSiteVPN' PKG=ec2 ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 4  -run=TestAccSiteVPN -timeout 720m
=== RUN   TestAccSiteVPNConnectionRoute_basic
=== PAUSE TestAccSiteVPNConnectionRoute_basic
=== RUN   TestAccSiteVPNConnectionRoute_disappears
=== PAUSE TestAccSiteVPNConnectionRoute_disappears
=== RUN   TestAccSiteVPNConnection_basic
=== PAUSE TestAccSiteVPNConnection_basic
=== RUN   TestAccSiteVPNConnection_withoutTGWorVGW
=== PAUSE TestAccSiteVPNConnection_withoutTGWorVGW
=== RUN   TestAccSiteVPNConnection_cloudWatchLogOptions
=== PAUSE TestAccSiteVPNConnection_cloudWatchLogOptions
=== RUN   TestAccSiteVPNConnection_transitGatewayID
=== PAUSE TestAccSiteVPNConnection_transitGatewayID
=== RUN   TestAccSiteVPNConnection_tunnel1InsideCIDR
=== PAUSE TestAccSiteVPNConnection_tunnel1InsideCIDR
=== RUN   TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR
=== PAUSE TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR
=== RUN   TestAccSiteVPNConnection_tunnel1PreSharedKey
=== PAUSE TestAccSiteVPNConnection_tunnel1PreSharedKey
=== RUN   TestAccSiteVPNConnection_tunnelOptions
=== PAUSE TestAccSiteVPNConnection_tunnelOptions
=== RUN   TestAccSiteVPNConnection_tunnelOptionsLesser
=== PAUSE TestAccSiteVPNConnection_tunnelOptionsLesser
=== RUN   TestAccSiteVPNConnection_staticRoutes
=== PAUSE TestAccSiteVPNConnection_staticRoutes
=== RUN   TestAccSiteVPNConnection_outsideAddressTypePrivate
=== PAUSE TestAccSiteVPNConnection_outsideAddressTypePrivate
=== RUN   TestAccSiteVPNConnection_outsideAddressTypePublic
=== PAUSE TestAccSiteVPNConnection_outsideAddressTypePublic
=== RUN   TestAccSiteVPNConnection_enableAcceleration
=== PAUSE TestAccSiteVPNConnection_enableAcceleration
=== RUN   TestAccSiteVPNConnection_ipv6
=== PAUSE TestAccSiteVPNConnection_ipv6
=== RUN   TestAccSiteVPNConnection_tags
=== PAUSE TestAccSiteVPNConnection_tags
=== RUN   TestAccSiteVPNConnection_specifyIPv4
=== PAUSE TestAccSiteVPNConnection_specifyIPv4
=== RUN   TestAccSiteVPNConnection_specifyIPv6
=== PAUSE TestAccSiteVPNConnection_specifyIPv6
=== RUN   TestAccSiteVPNConnection_disappears
=== PAUSE TestAccSiteVPNConnection_disappears
=== RUN   TestAccSiteVPNConnection_updateCustomerGatewayID
=== PAUSE TestAccSiteVPNConnection_updateCustomerGatewayID
=== RUN   TestAccSiteVPNConnection_updateVPNGatewayID
=== PAUSE TestAccSiteVPNConnection_updateVPNGatewayID
=== RUN   TestAccSiteVPNConnection_updateTransitGatewayID
=== PAUSE TestAccSiteVPNConnection_updateTransitGatewayID
=== RUN   TestAccSiteVPNConnection_vpnGatewayIDToTransitGatewayID
=== PAUSE TestAccSiteVPNConnection_vpnGatewayIDToTransitGatewayID
=== RUN   TestAccSiteVPNConnection_transitGatewayIDToVPNGatewayID
=== PAUSE TestAccSiteVPNConnection_transitGatewayIDToVPNGatewayID
=== RUN   TestAccSiteVPNCustomerGatewayDataSource_filter
=== PAUSE TestAccSiteVPNCustomerGatewayDataSource_filter
=== RUN   TestAccSiteVPNCustomerGatewayDataSource_id
=== PAUSE TestAccSiteVPNCustomerGatewayDataSource_id
=== RUN   TestAccSiteVPNCustomerGateway_basic
=== PAUSE TestAccSiteVPNCustomerGateway_basic
=== RUN   TestAccSiteVPNCustomerGateway_disappears
=== PAUSE TestAccSiteVPNCustomerGateway_disappears
=== RUN   TestAccSiteVPNCustomerGateway_tags
=== PAUSE TestAccSiteVPNCustomerGateway_tags
=== RUN   TestAccSiteVPNCustomerGateway_deviceName
=== PAUSE TestAccSiteVPNCustomerGateway_deviceName
=== RUN   TestAccSiteVPNCustomerGateway_4ByteASN
=== PAUSE TestAccSiteVPNCustomerGateway_4ByteASN
=== RUN   TestAccSiteVPNCustomerGateway_certificate
=== PAUSE TestAccSiteVPNCustomerGateway_certificate
=== RUN   TestAccSiteVPNGatewayAttachment_basic
=== PAUSE TestAccSiteVPNGatewayAttachment_basic
=== RUN   TestAccSiteVPNGatewayAttachment_disappears
=== PAUSE TestAccSiteVPNGatewayAttachment_disappears
=== RUN   TestAccSiteVPNGatewayDataSource_unattached
=== PAUSE TestAccSiteVPNGatewayDataSource_unattached
=== RUN   TestAccSiteVPNGatewayDataSource_attached
=== PAUSE TestAccSiteVPNGatewayDataSource_attached
=== RUN   TestAccSiteVPNGatewayRoutePropagation_basic
=== PAUSE TestAccSiteVPNGatewayRoutePropagation_basic
=== RUN   TestAccSiteVPNGatewayRoutePropagation_disappears
=== PAUSE TestAccSiteVPNGatewayRoutePropagation_disappears
=== RUN   TestAccSiteVPNGateway_basic
=== PAUSE TestAccSiteVPNGateway_basic
=== RUN   TestAccSiteVPNGateway_withAvailabilityZoneSetToState
=== PAUSE TestAccSiteVPNGateway_withAvailabilityZoneSetToState
=== RUN   TestAccSiteVPNGateway_amazonSideASN
=== PAUSE TestAccSiteVPNGateway_amazonSideASN
=== RUN   TestAccSiteVPNGateway_disappears
=== PAUSE TestAccSiteVPNGateway_disappears
=== RUN   TestAccSiteVPNGateway_reattach
=== PAUSE TestAccSiteVPNGateway_reattach
=== RUN   TestAccSiteVPNGateway_tags
=== PAUSE TestAccSiteVPNGateway_tags
=== CONT  TestAccSiteVPNGateway_basic
=== CONT  TestAccSiteVPNConnectionRoute_basic
=== CONT  TestAccSiteVPNConnection_updateVPNGatewayID
=== CONT  TestAccSiteVPNConnection_updateTransitGatewayID
--- PASS: TestAccSiteVPNConnectionRoute_basic (233.56s)
=== CONT  TestAccSiteVPNConnection_updateCustomerGatewayID
--- PASS: TestAccSiteVPNGateway_basic (260.36s)
=== CONT  TestAccSiteVPNConnection_disappears
--- PASS: TestAccSiteVPNConnection_updateVPNGatewayID (571.73s)
=== CONT  TestAccSiteVPNConnection_specifyIPv6
--- PASS: TestAccSiteVPNConnection_disappears (393.63s)
=== CONT  TestAccSiteVPNGatewayRoutePropagation_disappears
--- PASS: TestAccSiteVPNConnection_updateTransitGatewayID (761.99s)
=== CONT  TestAccSiteVPNConnection_specifyIPv4
--- PASS: TestAccSiteVPNConnection_updateCustomerGatewayID (574.44s)
=== CONT  TestAccSiteVPNGatewayRoutePropagation_basic
--- PASS: TestAccSiteVPNGatewayRoutePropagation_basic (139.62s)
=== CONT  TestAccSiteVPNConnection_tags
--- PASS: TestAccSiteVPNGatewayRoutePropagation_disappears (296.48s)
=== CONT  TestAccSiteVPNGatewayDataSource_attached
--- PASS: TestAccSiteVPNConnection_specifyIPv6 (380.64s)
=== CONT  TestAccSiteVPNConnection_ipv6
--- PASS: TestAccSiteVPNGatewayDataSource_attached (114.67s)
=== CONT  TestAccSiteVPNGatewayDataSource_unattached
--- PASS: TestAccSiteVPNGatewayDataSource_unattached (34.11s)
=== CONT  TestAccSiteVPNConnection_enableAcceleration
--- PASS: TestAccSiteVPNConnection_tags (236.49s)
=== CONT  TestAccSiteVPNGatewayAttachment_disappears
--- PASS: TestAccSiteVPNConnection_specifyIPv4 (514.03s)
=== CONT  TestAccSiteVPNConnection_outsideAddressTypePublic
--- PASS: TestAccSiteVPNGatewayAttachment_disappears (125.57s)
=== CONT  TestAccSiteVPNGatewayAttachment_basic
--- PASS: TestAccSiteVPNConnection_ipv6 (382.57s)
=== CONT  TestAccSiteVPNConnection_outsideAddressTypePrivate
--- PASS: TestAccSiteVPNGatewayAttachment_basic (83.66s)
=== CONT  TestAccSiteVPNCustomerGateway_certificate
--- PASS: TestAccSiteVPNCustomerGateway_certificate (66.05s)
=== CONT  TestAccSiteVPNConnection_staticRoutes
--- PASS: TestAccSiteVPNConnection_enableAcceleration (399.91s)
=== CONT  TestAccSiteVPNCustomerGateway_4ByteASN
--- PASS: TestAccSiteVPNCustomerGateway_4ByteASN (23.01s)
=== CONT  TestAccSiteVPNConnection_tunnelOptionsLesser
--- PASS: TestAccSiteVPNConnection_outsideAddressTypePublic (267.89s)
=== CONT  TestAccSiteVPNCustomerGateway_deviceName
--- PASS: TestAccSiteVPNCustomerGateway_deviceName (22.62s)
=== CONT  TestAccSiteVPNConnection_tunnelOptions
--- PASS: TestAccSiteVPNConnection_staticRoutes (233.83s)
=== CONT  TestAccSiteVPNCustomerGateway_tags
--- PASS: TestAccSiteVPNCustomerGateway_tags (39.44s)
=== CONT  TestAccSiteVPNConnection_tunnel1PreSharedKey
--- PASS: TestAccSiteVPNConnection_tunnelOptions (238.33s)
=== CONT  TestAccSiteVPNCustomerGateway_disappears
--- PASS: TestAccSiteVPNCustomerGateway_disappears (21.11s)
=== CONT  TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR
--- PASS: TestAccSiteVPNConnection_tunnel1InsideIPv6CIDR (44.98s)
=== CONT  TestAccSiteVPNCustomerGateway_basic
--- PASS: TestAccSiteVPNCustomerGateway_basic (22.77s)
=== CONT  TestAccSiteVPNConnection_tunnel1InsideCIDR
--- PASS: TestAccSiteVPNConnection_tunnel1PreSharedKey (230.35s)
=== CONT  TestAccSiteVPNCustomerGatewayDataSource_id
--- PASS: TestAccSiteVPNCustomerGatewayDataSource_id (21.43s)
=== CONT  TestAccSiteVPNConnection_transitGatewayID
--- PASS: TestAccSiteVPNConnection_tunnel1InsideCIDR (230.98s)
=== CONT  TestAccSiteVPNCustomerGatewayDataSource_filter
--- PASS: TestAccSiteVPNCustomerGatewayDataSource_filter (21.61s)
=== CONT  TestAccSiteVPNConnection_cloudWatchLogOptions
--- PASS: TestAccSiteVPNConnection_transitGatewayID (540.98s)
=== CONT  TestAccSiteVPNConnection_transitGatewayIDToVPNGatewayID
--- PASS: TestAccSiteVPNConnection_tunnelOptionsLesser (1380.62s)
=== CONT  TestAccSiteVPNConnection_withoutTGWorVGW
--- PASS: TestAccSiteVPNConnection_cloudWatchLogOptions (773.32s)
=== CONT  TestAccSiteVPNConnection_vpnGatewayIDToTransitGatewayID
--- PASS: TestAccSiteVPNConnection_outsideAddressTypePrivate (1626.46s)
=== CONT  TestAccSiteVPNConnectionRoute_disappears
--- PASS: TestAccSiteVPNConnection_withoutTGWorVGW (263.81s)
=== CONT  TestAccSiteVPNGateway_disappears
--- PASS: TestAccSiteVPNConnectionRoute_disappears (285.68s)
=== CONT  TestAccSiteVPNGateway_amazonSideASN
--- PASS: TestAccSiteVPNConnection_transitGatewayIDToVPNGatewayID (742.10s)
=== CONT  TestAccSiteVPNGateway_tags
--- PASS: TestAccSiteVPNGateway_disappears (136.49s)
=== CONT  TestAccSiteVPNGateway_reattach
--- PASS: TestAccSiteVPNGateway_amazonSideASN (169.90s)
=== CONT  TestAccSiteVPNGateway_withAvailabilityZoneSetToState
--- PASS: TestAccSiteVPNGateway_tags (215.31s)
=== CONT  TestAccSiteVPNConnection_basic
--- PASS: TestAccSiteVPNGateway_withAvailabilityZoneSetToState (138.00s)
--- PASS: TestAccSiteVPNConnection_vpnGatewayIDToTransitGatewayID (769.38s)
--- PASS: TestAccSiteVPNGateway_reattach (397.56s)
--- PASS: TestAccSiteVPNConnection_basic (235.75s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	3723.247s

@ewbankkit
Copy link
Contributor

@DanielRieske Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit d922391 into hashicorp:main May 21, 2024
36 checks passed
@github-actions github-actions bot added this to the v5.51.0 milestone May 21, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. external-maintainer Contribution from a trusted external contributor. service/vpnsite Issues and PRs that pertain to the vpnsite service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.51.0
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] VPN (Site-to-Site) Service
3 participants
@DanielRieske @ewbankkit @justinretzolk