-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/app fabric app authorization #37468
Feature/app fabric app authorization #37468
Conversation
Community NoteVoting for Prioritization
For Submitters
|
After fixing the tests: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent code, job well done. Just some minor edits to follow.
# Conflicts: # internal/service/appfabric/appfabric_test.go # internal/service/appfabric/exports_test.go # internal/service/appfabric/service_package_gen.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% AWS_DEFAULT_REGION=us-east-1 make testacc TESTARGS='-run=TestAccAppFabric_serial/AppAuthorization' PKG=appfabric
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/appfabric/... -v -count 1 -parallel 20 -run=TestAccAppFabric_serial/AppAuthorization -timeout 360m
=== RUN TestAccAppFabric_serial
=== PAUSE TestAccAppFabric_serial
=== CONT TestAccAppFabric_serial
=== RUN TestAccAppFabric_serial/AppAuthorization
=== RUN TestAccAppFabric_serial/AppAuthorization/apiKeyUpdate
=== RUN TestAccAppFabric_serial/AppAuthorization/oath2Update
=== RUN TestAccAppFabric_serial/AppAuthorization/tags
=== RUN TestAccAppFabric_serial/AppAuthorization/basic
=== RUN TestAccAppFabric_serial/AppAuthorization/disappears
--- PASS: TestAccAppFabric_serial (168.77s)
--- PASS: TestAccAppFabric_serial/AppAuthorization (168.77s)
--- PASS: TestAccAppFabric_serial/AppAuthorization/apiKeyUpdate (41.93s)
--- PASS: TestAccAppFabric_serial/AppAuthorization/oath2Update (34.36s)
--- PASS: TestAccAppFabric_serial/AppAuthorization/tags (46.55s)
--- PASS: TestAccAppFabric_serial/AppAuthorization/basic (24.49s)
--- PASS: TestAccAppFabric_serial/AppAuthorization/disappears (21.44s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appfabric 173.143s
@markoskandylis Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR adds a resource for aws_appfabric_app_authorization
https://docs.aws.amazon.com/appfabric/latest/api/API_CreateAppAuthorization.html
Relations
Relates #34549.
Requires #37468.
References
Output from Acceptance Testing