Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate organizations resources to AWS SDK for Go v2 #37505

Merged
merged 37 commits into from
May 16, 2024
Merged

Migrate organizations resources to AWS SDK for Go v2 #37505

merged 37 commits into from
May 16, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented May 14, 2024 •
edited
Loading

Description

Ibid.

Relations

Closes #36194.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccMetaPartitionDataSource_' PKG=meta
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/meta/... -v -count 1 -parallel 20  -run=TestAccMetaPartitionDataSource_ -timeout 360m
=== RUN   TestAccMetaPartitionDataSource_basic
=== PAUSE TestAccMetaPartitionDataSource_basic
=== CONT  TestAccMetaPartitionDataSource_basic
--- PASS: TestAccMetaPartitionDataSource_basic (6.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/meta	11.343s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccOrganizations' PKG=organizations ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/organizations/... -v -count 1 -parallel 2  -run=TestAccOrganizations -timeout 720m
=== RUN   TestAccOrganizations_serial
=== PAUSE TestAccOrganizations_serial
=== RUN   TestAccOrganizationsPoliciesDataSource_basic
    policies_data_source_test.go:27: this AWS account must be an existing member of an AWS Organization
--- SKIP: TestAccOrganizationsPoliciesDataSource_basic (0.57s)
=== RUN   TestAccOrganizationsPoliciesForTargetDataSource_basic
--- PASS: TestAccOrganizationsPoliciesForTargetDataSource_basic (28.55s)
=== CONT  TestAccOrganizations_serial
=== RUN   TestAccOrganizations_serial/PolicyDataSource
=== RUN   TestAccOrganizations_serial/PolicyDataSource/UnattachedPolicy
=== RUN   TestAccOrganizations_serial/DelegatedServices
=== RUN   TestAccOrganizations_serial/DelegatedServices/basic
    delegated_services_data_source_test.go:23: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== RUN   TestAccOrganizations_serial/DelegatedServices/multiple
    delegated_services_data_source_test.go:48: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== RUN   TestAccOrganizations_serial/ResourceTags
=== RUN   TestAccOrganizations_serial/ResourceTags/basic
=== RUN   TestAccOrganizations_serial/Organization
=== RUN   TestAccOrganizations_serial/Organization/FeatureSet_Basic
=== RUN   TestAccOrganizations_serial/Organization/FeatureSet_Update
=== RUN   TestAccOrganizations_serial/Organization/FeatureSet_ForcesNew
=== RUN   TestAccOrganizations_serial/Organization/DataSource_basic
=== RUN   TestAccOrganizations_serial/Organization/DataSource_memberAccount
    organization_data_source_test.go:58: this AWS account must be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/Organization/DataSource_delegatedAdministrator
    organization_data_source_test.go:93: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== RUN   TestAccOrganizations_serial/Organization/basic
=== RUN   TestAccOrganizations_serial/Organization/disappears
=== RUN   TestAccOrganizations_serial/Organization/AwsServiceAccessPrincipals
=== RUN   TestAccOrganizations_serial/Organization/EnabledPolicyTypes
=== RUN   TestAccOrganizations_serial/Policy
=== RUN   TestAccOrganizations_serial/Policy/Type_Backup
=== RUN   TestAccOrganizations_serial/Policy/ImportAwsManagedPolicy
=== RUN   TestAccOrganizations_serial/Policy/concurrent
=== RUN   TestAccOrganizations_serial/Policy/disappears
=== RUN   TestAccOrganizations_serial/Policy/Type_AI_OPT_OUT
=== RUN   TestAccOrganizations_serial/Policy/SkipDestroy
=== RUN   TestAccOrganizations_serial/Policy/Type_SCP
=== RUN   TestAccOrganizations_serial/Policy/Type_Tag
=== RUN   TestAccOrganizations_serial/Policy/basic
=== RUN   TestAccOrganizations_serial/Policy/Description
=== RUN   TestAccOrganizations_serial/Policy/Tags
=== RUN   TestAccOrganizations_serial/PolicyAttachment
=== RUN   TestAccOrganizations_serial/PolicyAttachment/SkipDestroy
=== RUN   TestAccOrganizations_serial/PolicyAttachment/disappears
=== RUN   TestAccOrganizations_serial/PolicyAttachment/Account
=== RUN   TestAccOrganizations_serial/PolicyAttachment/OrganizationalUnit
=== RUN   TestAccOrganizations_serial/PolicyAttachment/Root
=== RUN   TestAccOrganizations_serial/DelegatedAdministrator
=== RUN   TestAccOrganizations_serial/DelegatedAdministrator/basic
    delegated_administrator_test.go:31: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== RUN   TestAccOrganizations_serial/DelegatedAdministrator/disappears
    delegated_administrator_test.go:61: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== RUN   TestAccOrganizations_serial/DelegatedAdministrators
=== RUN   TestAccOrganizations_serial/DelegatedAdministrators/basic
    delegated_administrators_data_source_test.go:23: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== RUN   TestAccOrganizations_serial/Account
=== RUN   TestAccOrganizations_serial/Account/CloseOnDeletion
    account_test.go:80: Environment variable TEST_AWS_ORGANIZATION_ACCOUNT_EMAIL_DOMAIN is not set
=== RUN   TestAccOrganizations_serial/Account/ParentId
    account_test.go:120: Environment variable TEST_AWS_ORGANIZATION_ACCOUNT_EMAIL_DOMAIN is not set
=== RUN   TestAccOrganizations_serial/Account/Tags
    account_test.go:161: Environment variable TEST_AWS_ORGANIZATION_ACCOUNT_EMAIL_DOMAIN is not set
=== RUN   TestAccOrganizations_serial/Account/GovCloud
    account_test.go:211: Environment variable TEST_AWS_ORGANIZATION_ACCOUNT_EMAIL_DOMAIN is not set
=== RUN   TestAccOrganizations_serial/Account/basic
    account_test.go:41: Environment variable TEST_AWS_ORGANIZATION_ACCOUNT_EMAIL_DOMAIN is not set
=== RUN   TestAccOrganizations_serial/OrganizationalUnit
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/DataSource_basic
    organizational_unit_data_source_test.go:25: this AWS account must be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/ChildAccountsDataSource_basic
    organizational_unit_child_accounts_data_source_test.go:21: this AWS account must be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/DescendantAccountsDataSource_basic
    organizational_unit_descendant_accounts_data_source_test.go:26: this AWS account must be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/PluralDataSource_basic
    organizational_units_data_source_test.go:25: this AWS account must be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/basic
    organizational_unit_test.go:31: this AWS account must be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/disappears
    organizational_unit_test.go:65: this AWS account must be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/update
    organizational_unit_test.go:93: this AWS account must be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/tags
    organizational_unit_test.go:131: this AWS account must be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/ResourcePolicy
=== RUN   TestAccOrganizations_serial/ResourcePolicy/basic
    resource_policy_test.go:30: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== RUN   TestAccOrganizations_serial/ResourcePolicy/disappears
    resource_policy_test.go:63: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
=== RUN   TestAccOrganizations_serial/ResourcePolicy/tags
    resource_policy_test.go:90: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- PASS: TestAccOrganizations_serial (644.50s)
    --- PASS: TestAccOrganizations_serial/PolicyDataSource (24.97s)
        --- PASS: TestAccOrganizations_serial/PolicyDataSource/UnattachedPolicy (24.97s)
    --- PASS: TestAccOrganizations_serial/DelegatedServices (0.00s)
        --- SKIP: TestAccOrganizations_serial/DelegatedServices/basic (0.00s)
        --- SKIP: TestAccOrganizations_serial/DelegatedServices/multiple (0.00s)
    --- PASS: TestAccOrganizations_serial/ResourceTags (14.56s)
        --- PASS: TestAccOrganizations_serial/ResourceTags/basic (14.56s)
    --- PASS: TestAccOrganizations_serial/Organization (226.93s)
        --- PASS: TestAccOrganizations_serial/Organization/FeatureSet_Basic (13.80s)
        --- PASS: TestAccOrganizations_serial/Organization/FeatureSet_Update (22.44s)
        --- PASS: TestAccOrganizations_serial/Organization/FeatureSet_ForcesNew (23.49s)
        --- PASS: TestAccOrganizations_serial/Organization/DataSource_basic (13.45s)
        --- SKIP: TestAccOrganizations_serial/Organization/DataSource_memberAccount (0.13s)
        --- SKIP: TestAccOrganizations_serial/Organization/DataSource_delegatedAdministrator (0.00s)
        --- PASS: TestAccOrganizations_serial/Organization/basic (14.57s)
        --- PASS: TestAccOrganizations_serial/Organization/disappears (12.00s)
        --- PASS: TestAccOrganizations_serial/Organization/AwsServiceAccessPrincipals (31.72s)
        --- PASS: TestAccOrganizations_serial/Organization/EnabledPolicyTypes (95.33s)
    --- PASS: TestAccOrganizations_serial/Policy (244.80s)
        --- PASS: TestAccOrganizations_serial/Policy/Type_Backup (15.63s)
        --- PASS: TestAccOrganizations_serial/Policy/ImportAwsManagedPolicy (17.50s)
        --- PASS: TestAccOrganizations_serial/Policy/concurrent (42.84s)
        --- PASS: TestAccOrganizations_serial/Policy/disappears (14.60s)
        --- PASS: TestAccOrganizations_serial/Policy/Type_AI_OPT_OUT (16.32s)
        --- PASS: TestAccOrganizations_serial/Policy/SkipDestroy (12.56s)
        --- PASS: TestAccOrganizations_serial/Policy/Type_SCP (23.28s)
        --- PASS: TestAccOrganizations_serial/Policy/Type_Tag (15.33s)
        --- PASS: TestAccOrganizations_serial/Policy/basic (25.86s)
        --- PASS: TestAccOrganizations_serial/Policy/Description (25.96s)
        --- PASS: TestAccOrganizations_serial/Policy/Tags (34.92s)
    --- PASS: TestAccOrganizations_serial/PolicyAttachment (131.93s)
        --- PASS: TestAccOrganizations_serial/PolicyAttachment/SkipDestroy (20.17s)
        --- PASS: TestAccOrganizations_serial/PolicyAttachment/disappears (22.94s)
        --- PASS: TestAccOrganizations_serial/PolicyAttachment/Account (33.87s)
        --- PASS: TestAccOrganizations_serial/PolicyAttachment/OrganizationalUnit (34.27s)
        --- PASS: TestAccOrganizations_serial/PolicyAttachment/Root (20.67s)
    --- PASS: TestAccOrganizations_serial/DelegatedAdministrator (0.00s)
        --- SKIP: TestAccOrganizations_serial/DelegatedAdministrator/basic (0.00s)
        --- SKIP: TestAccOrganizations_serial/DelegatedAdministrator/disappears (0.00s)
    --- PASS: TestAccOrganizations_serial/DelegatedAdministrators (0.00s)
        --- SKIP: TestAccOrganizations_serial/DelegatedAdministrators/basic (0.00s)
    --- PASS: TestAccOrganizations_serial/Account (0.00s)
        --- SKIP: TestAccOrganizations_serial/Account/CloseOnDeletion (0.00s)
        --- SKIP: TestAccOrganizations_serial/Account/ParentId (0.00s)
        --- SKIP: TestAccOrganizations_serial/Account/Tags (0.00s)
        --- SKIP: TestAccOrganizations_serial/Account/GovCloud (0.00s)
        --- SKIP: TestAccOrganizations_serial/Account/basic (0.00s)
    --- PASS: TestAccOrganizations_serial/OrganizationalUnit (1.31s)
        --- SKIP: TestAccOrganizations_serial/OrganizationalUnit/DataSource_basic (0.19s)
        --- SKIP: TestAccOrganizations_serial/OrganizationalUnit/ChildAccountsDataSource_basic (0.17s)
        --- SKIP: TestAccOrganizations_serial/OrganizationalUnit/DescendantAccountsDataSource_basic (0.20s)
        --- SKIP: TestAccOrganizations_serial/OrganizationalUnit/PluralDataSource_basic (0.15s)
        --- SKIP: TestAccOrganizations_serial/OrganizationalUnit/basic (0.17s)
        --- SKIP: TestAccOrganizations_serial/OrganizationalUnit/disappears (0.15s)
        --- SKIP: TestAccOrganizations_serial/OrganizationalUnit/update (0.14s)
        --- SKIP: TestAccOrganizations_serial/OrganizationalUnit/tags (0.15s)
    --- PASS: TestAccOrganizations_serial/ResourcePolicy (0.00s)
        --- SKIP: TestAccOrganizations_serial/ResourcePolicy/basic (0.00s)
        --- SKIP: TestAccOrganizations_serial/ResourcePolicy/disappears (0.00s)
        --- SKIP: TestAccOrganizations_serial/ResourcePolicy/tags (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/organizations	677.825s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccOrganizations' PKG=organizations ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/organizations/... -v -count 1 -parallel 2  -run=TestAccOrganizations -timeout 720m
=== RUN   TestAccOrganizations_serial
=== PAUSE TestAccOrganizations_serial
=== RUN   TestAccOrganizationsPoliciesDataSource_basic
--- PASS: TestAccOrganizationsPoliciesDataSource_basic (11.78s)
=== RUN   TestAccOrganizationsPoliciesForTargetDataSource_basic
    policies_for_target_data_source_test.go:24: skipping tests; this AWS account must not be an existing member of an AWS Organization
--- SKIP: TestAccOrganizationsPoliciesForTargetDataSource_basic (0.10s)
=== CONT  TestAccOrganizations_serial
=== RUN   TestAccOrganizations_serial/PolicyDataSource
=== RUN   TestAccOrganizations_serial/PolicyDataSource/UnattachedPolicy
    policy_data_source_test.go:25: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/ResourcePolicy
=== RUN   TestAccOrganizations_serial/ResourcePolicy/basic
=== RUN   TestAccOrganizations_serial/ResourcePolicy/disappears
=== RUN   TestAccOrganizations_serial/ResourcePolicy/tags
=== RUN   TestAccOrganizations_serial/DelegatedAdministrators
=== RUN   TestAccOrganizations_serial/DelegatedAdministrators/basic
=== RUN   TestAccOrganizations_serial/DelegatedServices
=== RUN   TestAccOrganizations_serial/DelegatedServices/basic
=== RUN   TestAccOrganizations_serial/DelegatedServices/multiple
=== RUN   TestAccOrganizations_serial/ResourceTags
=== RUN   TestAccOrganizations_serial/ResourceTags/basic
    resource_tags_data_source_test.go:23: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/Organization
=== RUN   TestAccOrganizations_serial/Organization/disappears
    organization_test.go:72: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/Organization/FeatureSet_Basic
    organization_test.go:226: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/Organization/FeatureSet_ForcesNew
    organization_test.go:253: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/Organization/DataSource_basic
    organization_data_source_test.go:23: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/Organization/DataSource_delegatedAdministrator
=== RUN   TestAccOrganizations_serial/Organization/basic
    organization_test.go:30: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/Organization/AwsServiceAccessPrincipals
    organization_test.go:95: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/Organization/EnabledPolicyTypes
    organization_test.go:140: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/Organization/FeatureSet_Update
    organization_test.go:288: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/Organization/DataSource_memberAccount
    organization_data_source_test.go:59: this AWS account must not be the management account of an AWS Organization
=== RUN   TestAccOrganizations_serial/Account
=== RUN   TestAccOrganizations_serial/Account/basic
    account_test.go:41: Environment variable TEST_AWS_ORGANIZATION_ACCOUNT_EMAIL_DOMAIN is not set
=== RUN   TestAccOrganizations_serial/Account/CloseOnDeletion
    account_test.go:80: Environment variable TEST_AWS_ORGANIZATION_ACCOUNT_EMAIL_DOMAIN is not set
=== RUN   TestAccOrganizations_serial/Account/ParentId
    account_test.go:120: Environment variable TEST_AWS_ORGANIZATION_ACCOUNT_EMAIL_DOMAIN is not set
=== RUN   TestAccOrganizations_serial/Account/Tags
    account_test.go:161: Environment variable TEST_AWS_ORGANIZATION_ACCOUNT_EMAIL_DOMAIN is not set
=== RUN   TestAccOrganizations_serial/Account/GovCloud
    account_test.go:211: Environment variable TEST_AWS_ORGANIZATION_ACCOUNT_EMAIL_DOMAIN is not set
=== RUN   TestAccOrganizations_serial/Policy
=== RUN   TestAccOrganizations_serial/Policy/disappears
    policy_test.go:218: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/Policy/Type_AI_OPT_OUT
    policy_test.go:244: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/Policy/Type_SCP
    policy_test.go:373: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/Policy/Description
    policy_test.go:106: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/Policy/concurrent
    policy_test.go:80: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/Policy/Tags
    policy_test.go:142: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/Policy/SkipDestroy
    policy_test.go:190: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/Policy/Type_Backup
    policy_test.go:343: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/Policy/Type_Tag
    policy_test.go:410: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/Policy/ImportAwsManagedPolicy
    policy_test.go:439: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/Policy/basic
    policy_test.go:35: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/OrganizationalUnit
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/DataSource_basic
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/ChildAccountsDataSource_basic
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/DescendantAccountsDataSource_basic
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/PluralDataSource_basic
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/basic
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/disappears
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/update
=== RUN   TestAccOrganizations_serial/OrganizationalUnit/tags
=== RUN   TestAccOrganizations_serial/PolicyAttachment
=== RUN   TestAccOrganizations_serial/PolicyAttachment/Account
    policy_attachment_test.go:35: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/PolicyAttachment/OrganizationalUnit
    policy_attachment_test.go:74: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/PolicyAttachment/Root
    policy_attachment_test.go:105: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/PolicyAttachment/SkipDestroy
    policy_attachment_test.go:138: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/PolicyAttachment/disappears
    policy_attachment_test.go:162: skipping tests; this AWS account must not be an existing member of an AWS Organization
=== RUN   TestAccOrganizations_serial/DelegatedAdministrator
=== RUN   TestAccOrganizations_serial/DelegatedAdministrator/basic
=== RUN   TestAccOrganizations_serial/DelegatedAdministrator/disappears
--- PASS: TestAccOrganizations_serial (344.87s)
    --- PASS: TestAccOrganizations_serial/PolicyDataSource (0.11s)
        --- SKIP: TestAccOrganizations_serial/PolicyDataSource/UnattachedPolicy (0.11s)
    --- PASS: TestAccOrganizations_serial/ResourcePolicy (72.69s)
        --- PASS: TestAccOrganizations_serial/ResourcePolicy/basic (19.18s)
        --- PASS: TestAccOrganizations_serial/ResourcePolicy/disappears (14.54s)
        --- PASS: TestAccOrganizations_serial/ResourcePolicy/tags (38.97s)
    --- PASS: TestAccOrganizations_serial/DelegatedAdministrators (14.13s)
        --- PASS: TestAccOrganizations_serial/DelegatedAdministrators/basic (14.13s)
    --- PASS: TestAccOrganizations_serial/DelegatedServices (30.94s)
        --- PASS: TestAccOrganizations_serial/DelegatedServices/basic (13.88s)
        --- PASS: TestAccOrganizations_serial/DelegatedServices/multiple (17.06s)
    --- PASS: TestAccOrganizations_serial/ResourceTags (0.12s)
        --- SKIP: TestAccOrganizations_serial/ResourceTags/basic (0.12s)
    --- PASS: TestAccOrganizations_serial/Organization (25.26s)
        --- SKIP: TestAccOrganizations_serial/Organization/disappears (0.13s)
        --- SKIP: TestAccOrganizations_serial/Organization/FeatureSet_Basic (1.24s)
        --- SKIP: TestAccOrganizations_serial/Organization/FeatureSet_ForcesNew (1.56s)
        --- SKIP: TestAccOrganizations_serial/Organization/DataSource_basic (0.10s)
        --- PASS: TestAccOrganizations_serial/Organization/DataSource_delegatedAdministrator (18.87s)
        --- SKIP: TestAccOrganizations_serial/Organization/basic (0.11s)
        --- SKIP: TestAccOrganizations_serial/Organization/AwsServiceAccessPrincipals (0.10s)
        --- SKIP: TestAccOrganizations_serial/Organization/EnabledPolicyTypes (1.33s)
        --- SKIP: TestAccOrganizations_serial/Organization/FeatureSet_Update (0.11s)
        --- SKIP: TestAccOrganizations_serial/Organization/DataSource_memberAccount (1.71s)
    --- PASS: TestAccOrganizations_serial/Account (0.00s)
        --- SKIP: TestAccOrganizations_serial/Account/basic (0.00s)
        --- SKIP: TestAccOrganizations_serial/Account/CloseOnDeletion (0.00s)
        --- SKIP: TestAccOrganizations_serial/Account/ParentId (0.00s)
        --- SKIP: TestAccOrganizations_serial/Account/Tags (0.00s)
        --- SKIP: TestAccOrganizations_serial/Account/GovCloud (0.00s)
    --- PASS: TestAccOrganizations_serial/Policy (11.80s)
        --- SKIP: TestAccOrganizations_serial/Policy/disappears (1.71s)
        --- SKIP: TestAccOrganizations_serial/Policy/Type_AI_OPT_OUT (0.11s)
        --- SKIP: TestAccOrganizations_serial/Policy/Type_SCP (1.49s)
        --- SKIP: TestAccOrganizations_serial/Policy/Description (0.09s)
        --- SKIP: TestAccOrganizations_serial/Policy/concurrent (2.07s)
        --- SKIP: TestAccOrganizations_serial/Policy/Tags (1.86s)
        --- SKIP: TestAccOrganizations_serial/Policy/SkipDestroy (0.09s)
        --- SKIP: TestAccOrganizations_serial/Policy/Type_Backup (2.11s)
        --- SKIP: TestAccOrganizations_serial/Policy/Type_Tag (0.11s)
        --- SKIP: TestAccOrganizations_serial/Policy/ImportAwsManagedPolicy (2.05s)
        --- SKIP: TestAccOrganizations_serial/Policy/basic (0.10s)
    --- PASS: TestAccOrganizations_serial/OrganizationalUnit (157.14s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/DataSource_basic (18.30s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/ChildAccountsDataSource_basic (8.75s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/DescendantAccountsDataSource_basic (21.20s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/PluralDataSource_basic (14.10s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/basic (16.50s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/disappears (14.28s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/update (26.98s)
        --- PASS: TestAccOrganizations_serial/OrganizationalUnit/tags (37.03s)
    --- PASS: TestAccOrganizations_serial/PolicyAttachment (4.31s)
        --- SKIP: TestAccOrganizations_serial/PolicyAttachment/Account (0.17s)
        --- SKIP: TestAccOrganizations_serial/PolicyAttachment/OrganizationalUnit (0.09s)
        --- SKIP: TestAccOrganizations_serial/PolicyAttachment/Root (1.96s)
        --- SKIP: TestAccOrganizations_serial/PolicyAttachment/SkipDestroy (0.09s)
        --- SKIP: TestAccOrganizations_serial/PolicyAttachment/disappears (1.99s)
    --- PASS: TestAccOrganizations_serial/DelegatedAdministrator (28.38s)
        --- PASS: TestAccOrganizations_serial/DelegatedAdministrator/basic (13.85s)
        --- PASS: TestAccOrganizations_serial/DelegatedAdministrator/disappears (14.38s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/organizations	360.847s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccOrganizations_serial/Organization/DataSource_memberAccount' PKG=organizations ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/organizations/... -v -count 1 -parallel 2  -run=TestAccOrganizations_serial/Organization/DataSource_memberAccount -timeout 720m
=== RUN   TestAccOrganizations_serial
=== PAUSE TestAccOrganizations_serial
=== CONT  TestAccOrganizations_serial
=== RUN   TestAccOrganizations_serial/Organization
=== RUN   TestAccOrganizations_serial/Organization/DataSource_memberAccount
=== RUN   TestAccOrganizations_serial/OrganizationalUnit
--- PASS: TestAccOrganizations_serial (8.10s)
    --- PASS: TestAccOrganizations_serial/Organization (8.10s)
        --- PASS: TestAccOrganizations_serial/Organization/DataSource_memberAccount (8.10s)
    --- PASS: TestAccOrganizations_serial/OrganizationalUnit (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/organizations	12.335s
% make testacc TESTARGS='-run=TestAccIPAMOrganizationAdminAccount_serial' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccIPAMOrganizationAdminAccount_serial -timeout 360m
=== RUN   TestAccIPAMOrganizationAdminAccount_serial
=== PAUSE TestAccIPAMOrganizationAdminAccount_serial
=== CONT  TestAccIPAMOrganizationAdminAccount_serial
=== RUN   TestAccIPAMOrganizationAdminAccount_serial/basic
=== RUN   TestAccIPAMOrganizationAdminAccount_serial/disappears
--- PASS: TestAccIPAMOrganizationAdminAccount_serial (46.60s)
    --- PASS: TestAccIPAMOrganizationAdminAccount_serial/basic (24.37s)
    --- PASS: TestAccIPAMOrganizationAdminAccount_serial/disappears (22.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	51.312s

@ewbankkit ewbankkit changed the title Migrate organizations resources to AWS SDK for Go v2 [WIP] Migrate organizations resources to AWS SDK for Go v2 May 14, 2024
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/organizations Issues and PRs that pertain to the organizations service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/ram Issues and PRs that pertain to the ram service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. size/XL Managed by automation to categorize the size of a PR. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/ipam Issues and PRs that pertain to the ipam service. service/securitylake Issues and PRs that pertain to the securitylake service. labels May 14, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 14, 2024
ewbankkit added 10 commits May 15, 2024 07:38
@ewbankkit
Merge branch 'main' into td-migrate-organizations-to-aws-sdk-v2
3dfcf29
@ewbankkit
r/aws_organizations_delegated_administrator: Migrate to AWS SDK for G…
87d02c5 
…o v2.
@ewbankkit
d/aws_organizations_delegated_administrators: Migrate to AWS SDK for …
31d6692 
…Go v2.
@ewbankkit
d/aws_organizations_delegated_services: Migrate to AWS SDK for Go v2.
80febb1
@ewbankkit
tfresource: Fix nilness warnings.
af9c7c9
@ewbankkit
r/aws_organizations_organization: Migrate to AWS SDK for Go v2.
6a476e5
@ewbankkit
d/aws_organizations_organization: Migrate to AWS SDK for Go v2.
7ef0f30
@ewbankkit
Merge branch 'main' into td-migrate-organizations-to-aws-sdk-v2
3672f6a 
# Conflicts:
#	go.mod
#	go.sum
@ewbankkit
d/aws_organizations_organizational_unit_child_accounts: Migrate to AW…
a64891b 
…S SDK for Go v2.
@ewbankkit
r/aws_organizations_organizational_unit: Migrate to AWS SDK for Go v2.
4c161c7
ewbankkit added 16 commits May 15, 2024 13:00
@ewbankkit
d/aws_organizations_organizational_units: Migrate to AWS SDK for Go v2.
cdb9459
@ewbankkit
d/aws_organizations_organizational_unit & d/aws_organizations_organiz…
bcfb311 
…ational_unit_descendant_accounts: Migrate to AWS SDK for Go v2.
@ewbankkit
d/aws_organizations_resource_tags: Migrate to AWS SDK for Go v2.
b3b9959
@ewbankkit
organizations: Custom API client.
2ab7ee4
@ewbankkit
Use 'name' partition functionality.
dce2ec9
@ewbankkit
r/aws_organizations_policy: Migrate to AWS SDK for Go v2.
e812445
@ewbankkit
d/aws_organizations_policy: Migrate to AWS SDK for Go v2.
e9f8336
@ewbankkit
r/aws_organizations_policy_attachment: Migrate to AWS SDK for Go v2.
db2eccf
@ewbankkit
d/aws_organizations_policies: Migrate to AWS SDK for Go v2.
9c88700
@ewbankkit
d/aws_organizations_policies_for_target: Migrate to AWS SDK for Go v2.
fe33853
@ewbankkit
r/aws_organizations_resource_policy: Migrate to AWS SDK for Go v2.
5bf5faa
@ewbankkit
r/aws_vpc_ipam_organization_admin_account: Tidy up use of organizatio…
a6df5fb 
…ns package.
@ewbankkit
Merge branch 'main' into td-migrate-organizations-to-aws-sdk-v2
de2da01
@ewbankkit
PreCheckOrganizationManagementAccountWithProvider & PreCheckOrganizat…
f684bb6 
…ionMemberAccountWithProvider: Skip if no Organization.
@ewbankkit
r/aws_organizations_policy_attachment: Fix 'PolicyNotAttachedExceptio…
8da98e6 
…n: The specified policy is not currently attached to the target' on Delete.
@ewbankkit
Merge branch 'main' into td-migrate-organizations-to-aws-sdk-v2
01182ac 
# Conflicts:
#	internal/service/securitylake/securitylake_test.go
@ewbankkit ewbankkit added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label May 15, 2024
@ewbankkit ewbankkit changed the title [WIP] Migrate organizations resources to AWS SDK for Go v2 Migrate organizations resources to AWS SDK for Go v2 May 16, 2024
@ewbankkit ewbankkit merged commit 28ea345 into main May 16, 2024
53 checks passed
@ewbankkit ewbankkit deleted the td-migrate-organizations-to-aws-sdk-v2 branch May 16, 2024 14:19
@github-actions github-actions bot added this to the v5.50.0 milestone May 16, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 17, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/ipam Issues and PRs that pertain to the ipam service. service/organizations Issues and PRs that pertain to the organizations service. service/ram Issues and PRs that pertain to the ram service. service/securitylake Issues and PRs that pertain to the securitylake service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.50.0
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] Organizations Service
1 participant
@ewbankkit