Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Resource] aws_rekognition_stream_processor #37536

Merged
merged 72 commits into from
Jul 18, 2024
Merged

[New Resource] aws_rekognition_stream_processor #37536

merged 72 commits into from
Jul 18, 2024

Conversation

bruceharrison1984
Copy link
Contributor

@bruceharrison1984 bruceharrison1984 commented May 15, 2024 •
edited
Loading

Description

The adds the aws_rekognition_stream_processor resource to the provider.

API Docs

Output from Acceptance Testing

% make testacc TESTS=TestAccRekognitionStreamProcessor_ PKG=rekognition

...

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/rekognition Issues and PRs that pertain to the rekognition service. labels May 15, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label May 15, 2024
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels May 16, 2024
@bruceharrison1984 bruceharrison1984 marked this pull request as ready for review May 23, 2024 14:11
@jar-b jar-b self-assigned this Jul 16, 2024
jar-b added 10 commits July 16, 2024 16:49
@jar-b
Merge branch 'main' into rekognition-stream-processor
8098e5b
@jar-b
r/aws_rekognition_stream_processor: adjust regex validation
a84c75f 
Specifically, removes ARN and KMS key ID validation in favor of AWS server-side validation. Also moves regular expression initialization to the package level so memory is not allocated on each call to the Schema method.
@jar-b
r/aws_rekognition_stream_processor: tidy local enum
520cd62
@jar-b
r/aws_rekognition_stream_processor: consistent arn types
8c35a39
@jar-b
r/aws_rekognition_stream_processor: remove magic numbers
c357c2e
@jar-b
r/aws_rekognition_stream_processor: remove connect home min_confidenc…
36d7371 
…e default

The AWS documentation does not specify a default value for this argument.
@jar-b
r/aws_rekognition_stream_processor(test): compose test configs
0d8832f
@jar-b
r/aws_rekognition_stream_processor(test): tidy config names
38f38ab
@jar-b
chore: changelog
c8b05b7
@jar-b
r/aws_rekognition_stream_processor: prefer ListNestedBlock
1c35443 
SingleNestedBlock is not broadly tested. The Terraform Plugin Framework documentation suggests using SingleNestedAttribute instead, which the AWS provider cannot currently adopt due to continued support of Terraform protocol V5. Given these constraints the current preferred convention is to use ListNestedBlock with a SizeAtMost(1) list validator.
@jar-b jar-b requested a review from a team as a code owner July 17, 2024 18:48
@jar-b
r/aws_rekognition_stream_processor(doc): tidy registry docs
b7fcc45
@jar-b
r/aws_rekognition_stream_processor(test): add tagging test
d9939d9 
Also renames the `arn` attribute to `stream_processor_arn` to align with the AWS API.
@jar-b
r/aws_rekognition_stream_processor: rm explicit ImportState method
bfe298c 
This is already provided by the embedded `framework.WithImportByID` struct.
jar-b
jar-b approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=rekognition TESTS=TestAccRekognitionStreamProcessor_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/rekognition/... -v -count 1 -parallel 20 -run='TestAccRekognitionStreamProcessor_'  -timeout 360m

--- PASS: TestAccRekognitionStreamProcessor_disappears (95.06s)
--- PASS: TestAccRekognitionStreamProcessor_basic (97.00s)
--- PASS: TestAccRekognitionStreamProcessor_faceRecognition_boundingBox (104.94s)
--- PASS: TestAccRekognitionStreamProcessor_faceRecognition_polygon (104.97s)
--- PASS: TestAccRekognitionStreamProcessor_connectedHome (105.40s)
--- PASS: TestAccRekognitionStreamProcessor_faceRecognition (107.02s)
--- PASS: TestAccRekognitionStreamProcessor_tags (120.70s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rekognition        126.632s

@jar-b
Copy link
Member

jar-b commented Jul 18, 2024

Thanks for your contribution, @bruceharrison1984! 👍

@bruceharrison1984
Copy link
Contributor Author

Thanks for whipping it into shape @jar-b

jar-b
jar-b approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests still passing after latest additions:

% make testacc PKG=rekognition TESTS=TestAccRekognitionStreamProcessor_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/rekognition/... -v -count 1 -parallel 20 -run='TestAccRekognitionStreamProcessor_'  -timeout 360m

--- PASS: TestAccRekognitionStreamProcessor_disappears (94.71s)
--- PASS: TestAccRekognitionStreamProcessor_basic (97.21s)
--- PASS: TestAccRekognitionStreamProcessor_faceRecognition_boundingBox (104.64s)
--- PASS: TestAccRekognitionStreamProcessor_faceRecognition_polygon (104.96s)
--- PASS: TestAccRekognitionStreamProcessor_connectedHome (105.45s)
--- PASS: TestAccRekognitionStreamProcessor_faceRecognition (107.28s)
--- PASS: TestAccRekognitionStreamProcessor_tags (118.75s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/rekognition        124.688s

@jar-b jar-b merged commit f6f55ae into hashicorp:main Jul 18, 2024
46 checks passed
@github-actions github-actions bot added this to the v5.59.0 milestone Jul 18, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees

@jar-b jar-b

Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/rekognition Issues and PRs that pertain to the rekognition service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.59.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bruceharrison1984 @jar-b @justinretzolk