Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aws_appfabric_ingestion_destination resource #37627

Merged
merged 13 commits into from
Jun 25, 2024
Merged

add aws_appfabric_ingestion_destination resource #37627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b048264
Adding AppFabric Ingestion Destination
professional-ian May 21, 2024
dd72854
added changelog and html docs
professional-ian May 28, 2024
791e566
adding tag support
davelemons Jun 3, 2024
fbc1da9
Merge branch 'main' into HEAD
ewbankkit Jun 24, 2024
7581ceb
r/aws_appfabric_ingestion_destination: Tidy up.
ewbankkit Jun 25, 2024
b605cf4
r/aws_appfabric_ingestion_destination: Fixes after some testing.
ewbankkit Jun 25, 2024
b10b92c
r/aws_appfabric_ingestion_destination: Acceptance tests.
ewbankkit Jun 25, 2024
ab8e621
r/aws_appfabric_ingestion_destination: Documentation.
ewbankkit Jun 25, 2024
795d75e
Run 'make fix-constants PKG=appfabric'.
ewbankkit Jun 25, 2024
f6f6921
Fix golangci-lint 'unparam'.
ewbankkit Jun 25, 2024
0f01df7
Fix markdownlint 'MD009/no-trailing-spaces Trailing spaces [Expected:…
ewbankkit Jun 25, 2024
804bb91
Fix markdownlint 'MD047/single-trailing-newline Files should end with…
ewbankkit Jun 25, 2024
e05f243
Fix 'testAccIngestionDestination_firehose'.
ewbankkit Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/37627.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:new-resource
aws_appfabric_ingestion_destination
```
2 changes: 2 additions & 0 deletions internal/service/appfabric/app_authorization.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"github.com/hashicorp/terraform-plugin-framework-validators/listvalidator"
"github.com/hashicorp/terraform-plugin-framework-validators/stringvalidator"
"github.com/hashicorp/terraform-plugin-framework/diag"
"github.com/hashicorp/terraform-plugin-framework/path"
"github.com/hashicorp/terraform-plugin-framework/resource"
"github.com/hashicorp/terraform-plugin-framework/resource/schema"
"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
Expand Down Expand Up @@ -235,6 +236,7 @@ func (r *appAuthorizationResource) Create(ctx context.Context, request resource.
appAuthorization, err := waitAppAuthorizationCreated(ctx, conn, data.AppAuthorizationARN.ValueString(), data.AppBundleARN.ValueString(), r.CreateTimeout(ctx, data.Timeouts))

if err != nil {
response.State.SetAttribute(ctx, path.Root(names.AttrID), data.ID) // Set 'id' so as to taint the resource.
response.Diagnostics.AddError(fmt.Sprintf("waiting for AppFabric App Authorization (%s) create", data.ID.ValueString()), err.Error())

return
Expand Down
2 changes: 2 additions & 0 deletions internal/service/appfabric/app_authorization_connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (
awstypes "github.com/aws/aws-sdk-go-v2/service/appfabric/types"
"github.com/hashicorp/terraform-plugin-framework-timeouts/resource/timeouts"
"github.com/hashicorp/terraform-plugin-framework-validators/listvalidator"
"github.com/hashicorp/terraform-plugin-framework/path"
"github.com/hashicorp/terraform-plugin-framework/resource"
"github.com/hashicorp/terraform-plugin-framework/resource/schema"
"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
Expand Down Expand Up @@ -139,6 +140,7 @@ func (r *appAuthorizationConnectionResource) Create(ctx context.Context, request
appAuthorization, err := waitConnectAppAuthorizationCreated(ctx, conn, data.AppAuthorizationARN.ValueString(), data.AppBundleARN.ValueString(), r.CreateTimeout(ctx, data.Timeouts))

if err != nil {
response.State.SetAttribute(ctx, path.Root(names.AttrID), data.ID) // Set 'id' so as to taint the resource.
response.Diagnostics.AddError(fmt.Sprintf("waiting for AppFabric App Authorization Connection (%s) create", data.ID.ValueString()), err.Error())

return
Expand Down
7 changes: 7 additions & 0 deletions internal/service/appfabric/appfabric_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,13 @@ func TestAccAppFabric_serial(t *testing.T) {
acctest.CtDisappears: testAccIngestion_disappears,
"tags": testAccIngestion_tags,
},
"IngestionDestination": {
acctest.CtBasic: testAccIngestionDestination_basic,
acctest.CtDisappears: testAccIngestionDestination_disappears,
"tags": testAccIngestionDestination_tags,
"update": testAccIngestionDestination_update,
"firehose": testAccIngestionDestination_firehose,
},
}

acctest.RunSerialTests2Levels(t, testCases, serializeDelay)
Expand Down
2 changes: 2 additions & 0 deletions internal/service/appfabric/exports_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,11 @@ var (
ResourceAppAuthorizationConnection = newAppAuthorizationConnectionResource
ResourceAppBundle = newAppBundleResource
ResourceIngestion = newIngestionResource
ResourceIngestionDestination = newIngestionDestinationResource

FindAppAuthorizationByTwoPartKey = findAppAuthorizationByTwoPartKey
FindAppAuthorizationConnectionByTwoPartKey = findAppAuthorizationConnectionByTwoPartKey
FindAppBundleByID = findAppBundleByID
FindIngestionByTwoPartKey = findIngestionByTwoPartKey
FindIngestionDestinationByThreePartKey = findIngestionDestinationByThreePartKey
)
Loading
Loading