-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Resource] aws_glue_catalog_table_optimizer #38052
[New Resource] aws_glue_catalog_table_optimizer #38052
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @t04glovern 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
@johnsonaj @justinretzolk could you help find a reviewer for this one? This supports a new-ish feature from AWS Glue, from Nov 2023. Having this supported in terraform-provider-aws is huge, otherwise folks are tracking up to thousands of these resources outside of terraform (1 per data lake table). |
8bd38ff
to
3d5828d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
% make testacc TESTARGS='-run=TestAccGlue_serial/CatalogTableOptimizer/' PKG=glue
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/glue/... -v -count 1 -parallel 20 -run=TestAccGlue_serial/CatalogTableOptimizer/ -timeout 360m
=== RUN TestAccGlue_serial
=== PAUSE TestAccGlue_serial
=== CONT TestAccGlue_serial
=== RUN TestAccGlue_serial/CatalogTableOptimizer
=== RUN TestAccGlue_serial/CatalogTableOptimizer/basic
=== RUN TestAccGlue_serial/CatalogTableOptimizer/update
=== PAUSE TestAccGlue_serial/CatalogTableOptimizer/update
=== CONT TestAccGlue_serial/CatalogTableOptimizer/update
--- PASS: TestAccGlue_serial (66.11s)
--- PASS: TestAccGlue_serial/CatalogTableOptimizer (28.16s)
--- PASS: TestAccGlue_serial/CatalogTableOptimizer/basic (28.16s)
--- PASS: TestAccGlue_serial/CatalogTableOptimizer/update (37.95s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/glue 72.172s
@t04glovern thank you for the contribution! 🎉 |
This functionality has been released in v5.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Glue released new optimizer features [1], filed #39405 to track adding them |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
aws_glue_catalog_table_optimizer
resource added to support automatic compaction of Iceberg tables in AWS Glue was added last year (https://aws.amazon.com/blogs/aws/aws-glue-data-catalog-now-supports-automatic-compaction-of-apache-iceberg-tables/).aws_glue_catalog_table_optimizer
aws_glue_catalog_table_optimizer
Relations
Closes #38035
References
Output from Acceptance Testing