Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource] aws_glue_catalog_table_optimizer #38052

Merged
merged 27 commits into from
Aug 22, 2024

Conversation

t04glovern
Copy link
Contributor

Description

Relations

Closes #38035

References

Output from Acceptance Testing

% make testacc TESTS=TestAccGlueCatalogTableOptimizer PKG=glue
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/glue/... -v -count 1 -parallel 20 -run='TestAccGlueCatalogTableOptimizer'  -timeout 360m
=== RUN   TestAccGlueCatalogTableOptimizer_basic
=== PAUSE TestAccGlueCatalogTableOptimizer_basic
=== CONT  TestAccGlueCatalogTableOptimizer_basic
--- PASS: TestAccGlueCatalogTableOptimizer_basic (56.20s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/glue       56.366s
...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label Jun 20, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 20, 2024
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/glue Issues and PRs that pertain to the glue service. generators Relates to code generators. labels Jun 20, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @t04glovern 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@t04glovern t04glovern marked this pull request as ready for review June 21, 2024 02:54
@t04glovern t04glovern requested a review from a team as a code owner June 21, 2024 02:54
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 25, 2024
@nickdelnano
Copy link

nickdelnano commented Jul 15, 2024

@johnsonaj @justinretzolk could you help find a reviewer for this one? This supports a new-ish feature from AWS Glue, from Nov 2023. Having this supported in terraform-provider-aws is huge, otherwise folks are tracking up to thousands of these resources outside of terraform (1 per data lake table).

@johnsonaj johnsonaj self-assigned this Aug 21, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 21, 2024
@johnsonaj johnsonaj force-pushed the f-glue-catalog-table-optimizer branch from 8bd38ff to 3d5828d Compare August 22, 2024 19:24
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=TestAccGlue_serial/CatalogTableOptimizer/' PKG=glue

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/glue/... -v -count 1 -parallel 20  -run=TestAccGlue_serial/CatalogTableOptimizer/ -timeout 360m
=== RUN   TestAccGlue_serial
=== PAUSE TestAccGlue_serial
=== CONT  TestAccGlue_serial
=== RUN   TestAccGlue_serial/CatalogTableOptimizer
=== RUN   TestAccGlue_serial/CatalogTableOptimizer/basic
=== RUN   TestAccGlue_serial/CatalogTableOptimizer/update
=== PAUSE TestAccGlue_serial/CatalogTableOptimizer/update
=== CONT  TestAccGlue_serial/CatalogTableOptimizer/update
--- PASS: TestAccGlue_serial (66.11s)
    --- PASS: TestAccGlue_serial/CatalogTableOptimizer (28.16s)
        --- PASS: TestAccGlue_serial/CatalogTableOptimizer/basic (28.16s)
        --- PASS: TestAccGlue_serial/CatalogTableOptimizer/update (37.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/glue	72.172s

@johnsonaj
Copy link
Contributor

@t04glovern thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit 8490fa5 into hashicorp:main Aug 22, 2024
39 checks passed
@github-actions github-actions bot added this to the v5.65.0 milestone Aug 22, 2024
@t04glovern t04glovern deleted the f-glue-catalog-table-optimizer branch August 23, 2024 01:27
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 29, 2024
Copy link

This functionality has been released in v5.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@nickdelnano
Copy link

Glue released new optimizer features [1], filed #39405 to track adding them

[1] https://aws.amazon.com/blogs/big-data/the-aws-glue-data-catalog-now-supports-storage-optimization-of-apache-iceberg-tables/

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/glue Issues and PRs that pertain to the glue service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: AWS Glue catalog table optimizer
4 participants