Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix: Fixes 400 error in dataSourceUserPoolClientRead #38168

Merged
merged 4 commits into from
Jun 28, 2024
Merged

BugFix: Fixes 400 error in dataSourceUserPoolClientRead #38168

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
64b1ee2
fix 400 error in dataSourceUserPoolClientRead
t-oki Jun 28, 2024
d8a482f
add change log
t-oki Jun 28, 2024
81f2756
Tweak CHANGELOG entry.
ewbankkit Jun 28, 2024
57ac819
Bump GitHub.
ewbankkit Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/service/cognitoidp/user_pool_client_data_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ func dataSourceUserPoolClientRead(ctx context.Context, d *schema.ResourceData, m
conn := meta.(*conns.AWSClient).CognitoIDPClient(ctx)

clientID := d.Get(names.AttrClientID).(string)
userPoolClient, err := findUserPoolClientByTwoPartKey(ctx, conn, d.Get(names.AttrUserPoolID).(string), d.Id())
userPoolClient, err := findUserPoolClientByTwoPartKey(ctx, conn, d.Get(names.AttrUserPoolID).(string), clientID)

if err != nil {
return sdkdiag.AppendErrorf(diags, "reading Cognito User Pool Client (%s): %s", clientID, err)
Expand Down
3 changes: 3 additions & 0 deletions internal/service/cognitoidp/user_pool_client_data_source_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package cognitoidp_test
import (
"testing"

awstypes "github.com/aws/aws-sdk-go-v2/service/cognitoidentityprovider/types"
sdkacctest "github.com/hashicorp/terraform-plugin-testing/helper/acctest"
"github.com/hashicorp/terraform-plugin-testing/helper/resource"
"github.com/hashicorp/terraform-provider-aws/internal/acctest"
Expand All @@ -14,6 +15,7 @@ import (

func TestAccCognitoIDPUserPoolClientDataSource_basic(t *testing.T) {
ctx := acctest.Context(t)
var client awstypes.UserPoolClientType
rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
resourceName := "data.aws_cognito_user_pool_client.test"

Expand All @@ -25,6 +27,7 @@ func TestAccCognitoIDPUserPoolClientDataSource_basic(t *testing.T) {
{
Config: testAccUserPoolClientDataSourceConfig_basic(rName),
Check: resource.ComposeAggregateTestCheckFunc(
testAccCheckUserPoolClientExists(ctx, resourceName, &client),
resource.TestCheckResourceAttr(resourceName, names.AttrName, rName),
resource.TestCheckResourceAttr(resourceName, "explicit_auth_flows.#", acctest.Ct1),
resource.TestCheckTypeSetElemAttr(resourceName, "explicit_auth_flows.*", "ADMIN_NO_SRP_AUTH"),
Expand Down