Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Data Source]: aws_appstream_image #38180

Closed
wants to merge 7 commits into from

Conversation

ThomasZalewski
Copy link
Contributor

Description

This datasource will allow practitioners to read the description of an existing AWS Appstream2.0 image with terraform.

Relations

Relates #6508
Closes #22536

References

https://docs.aws.amazon.com/appstream2/latest/APIReference/API_DescribeImages.html

Output from Acceptance Testing

% make testacc TESTS=TestAccAppStreamImageDataSource_basic PKG=appstream
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/appstream/... -v -count 1 -parallel 20 -run='TestAccAppStreamImageDataSource_basic'  -timeout 360m
=== RUN   TestAccAppStreamImageDataSource_basic
=== PAUSE TestAccAppStreamImageDataSource_basic
=== CONT  TestAccAppStreamImageDataSource_basic
--- PASS: TestAccAppStreamImageDataSource_basic (7.53s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/appstream  11.927s

@ThomasZalewski ThomasZalewski requested a review from a team as a code owner June 28, 2024 12:47
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/appstream Issues and PRs that pertain to the appstream service. generators Relates to code generators. labels Jun 28, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 28, 2024
@terraform-aws-provider terraform-aws-provider bot removed the needs-triage Waiting for first response or review from a maintainer. label Jun 28, 2024
Copy link

github-actions bot commented Aug 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/appstream Issues and PRs that pertain to the appstream service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Datasource: aws_appstream_image
1 participant