Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource]: Added Verified Permissions identity_source #38181

Conversation

DanielRieske
Copy link
Contributor

@DanielRieske DanielRieske commented Jun 28, 2024

Description

This PR adds the last resource identity_source to make this service complete.

Relations

Closes #35801
Closes #32158

References

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccVerifiedPermissionsIdentitySource_' PKG=verifiedpermissions
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/verifiedpermissions/... -v -count 1 -parallel 20  -run=TestAccVerifiedPermissionsIdentitySource_ -timeout 360m
=== RUN   TestAccVerifiedPermissionsIdentitySource_basic
=== PAUSE TestAccVerifiedPermissionsIdentitySource_basic
=== RUN   TestAccVerifiedPermissionsIdentitySource_update
=== PAUSE TestAccVerifiedPermissionsIdentitySource_update
=== RUN   TestAccVerifiedPermissionsIdentitySource_disappears
=== PAUSE TestAccVerifiedPermissionsIdentitySource_disappears
=== CONT  TestAccVerifiedPermissionsIdentitySource_basic
=== CONT  TestAccVerifiedPermissionsIdentitySource_disappears
=== CONT  TestAccVerifiedPermissionsIdentitySource_update
--- PASS: TestAccVerifiedPermissionsIdentitySource_disappears (19.98s)
--- PASS: TestAccVerifiedPermissionsIdentitySource_basic (22.33s)
--- PASS: TestAccVerifiedPermissionsIdentitySource_update (54.45s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/verifiedpermissions        58.785s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 28, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jun 28, 2024
@github-actions github-actions bot added generators Relates to code generators. service/verifiedpermissions Issues and PRs that pertain to the verifiedpermissions service. labels Jun 28, 2024
@terraform-aws-provider terraform-aws-provider bot added the external-maintainer Contribution from a trusted external contributor. label Jun 28, 2024
@DanielRieske DanielRieske marked this pull request as ready for review June 28, 2024 15:25
@DanielRieske DanielRieske requested a review from a team as a code owner June 28, 2024 15:25
@ewbankkit ewbankkit self-assigned this Jun 28, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 28, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jun 28, 2024
@ewbankkit ewbankkit removed their assignment Jun 28, 2024
@DanielRieske
Copy link
Contributor Author

Want to wait for #38192 to be merged to remove the expanders for the union types and fully use AutoFlex.

@DanielRieske
Copy link
Contributor Author

This PR is ready for review again.

Small note for the reviewer, I added a custom expander for the AutoFlex for certain types but had to make a distinction on the read and update operation within the expander.
This is because it uses a different update type for the update operation.

Example (configuration):

Create: https://docs.aws.amazon.com/verifiedpermissions/latest/apireference/API_Configuration.html
Update: https://docs.aws.amazon.com/verifiedpermissions/latest/apireference/API_UpdateConfiguration.html

@gdavison gdavison self-assigned this Jul 10, 2024
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @DanielRieske. I've updated the tests to separate them out and test conversions in both directions

--- PASS: TestAccVerifiedPermissionsIdentitySource_disappears (82.97s)
--- PASS: TestAccVerifiedPermissionsIdentitySource_OpenID_basic (83.24s)
--- PASS: TestAccVerifiedPermissionsIdentitySource_Cognito_basic (89.08s)
--- PASS: TestAccVerifiedPermissionsIdentitySource_OpenID_convertToCognito (107.56s)
--- PASS: TestAccVerifiedPermissionsIdentitySource_Cognito_update (108.68s)
--- PASS: TestAccVerifiedPermissionsIdentitySource_Cognito_convertToOpenID (108.94s)
--- PASS: TestAccVerifiedPermissionsIdentitySource_OpenID_update (121.13s)

@gdavison gdavison merged commit 2096a66 into hashicorp:main Jul 11, 2024
46 checks passed
@github-actions github-actions bot added this to the v5.58.0 milestone Jul 11, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 12, 2024
Copy link

This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/verifiedpermissions Issues and PRs that pertain to the verifiedpermissions service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_verifiedpermissions_identity_source [New Service]: VerifiedPermissions
4 participants