Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMR awssdkv2 migration #38233

Merged
merged 101 commits into from
Aug 26, 2024
Merged

Conversation

mattburgess
Copy link
Collaborator

@mattburgess mattburgess commented Jul 2, 2024

Description

Relations

Closes #36158.
Relates #32976.
Closes #38380.

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@mattburgess mattburgess requested a review from a team as a code owner July 2, 2024 21:09
Copy link

github-actions bot commented Jul 2, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/emr Issues and PRs that pertain to the emr service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Jul 2, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Jul 2, 2024
@ewbankkit ewbankkit added aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 3, 2024
@ewbankkit ewbankkit self-assigned this Aug 22, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 22, 2024
# Conflicts:
#	internal/conns/awsclient_gen.go
#	internal/service/emr/cluster_test.go
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEMRBlockPublicAccessConfiguration_serial' PKG=emr
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/emr/... -v -count 1 -parallel 20  -run=TestAccEMRBlockPublicAccessConfiguration_serial -timeout 360m
=== RUN   TestAccEMRBlockPublicAccessConfiguration_serial
=== PAUSE TestAccEMRBlockPublicAccessConfiguration_serial
=== CONT  TestAccEMRBlockPublicAccessConfiguration_serial
=== RUN   TestAccEMRBlockPublicAccessConfiguration_serial/basic
=== RUN   TestAccEMRBlockPublicAccessConfiguration_serial/disappears
=== RUN   TestAccEMRBlockPublicAccessConfiguration_serial/default
=== RUN   TestAccEMRBlockPublicAccessConfiguration_serial/enabledMultiRange
--- PASS: TestAccEMRBlockPublicAccessConfiguration_serial (54.10s)
    --- PASS: TestAccEMRBlockPublicAccessConfiguration_serial/basic (21.46s)
    --- PASS: TestAccEMRBlockPublicAccessConfiguration_serial/disappears (9.60s)
    --- PASS: TestAccEMRBlockPublicAccessConfiguration_serial/default (11.61s)
    --- PASS: TestAccEMRBlockPublicAccessConfiguration_serial/enabledMultiRange (11.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	59.006s
% make testacc TESTARGS='-run=TestAccEMRReleaseLabels_' PKG=emr
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/emr/... -v -count 1 -parallel 20  -run=TestAccEMRReleaseLabels_ -timeout 360m
=== RUN   TestAccEMRReleaseLabels_basic
=== PAUSE TestAccEMRReleaseLabels_basic
=== RUN   TestAccEMRReleaseLabels_prefix
=== PAUSE TestAccEMRReleaseLabels_prefix
=== RUN   TestAccEMRReleaseLabels_application
=== PAUSE TestAccEMRReleaseLabels_application
=== RUN   TestAccEMRReleaseLabels_full
=== PAUSE TestAccEMRReleaseLabels_full
=== RUN   TestAccEMRReleaseLabels_empty
=== PAUSE TestAccEMRReleaseLabels_empty
=== CONT  TestAccEMRReleaseLabels_basic
=== CONT  TestAccEMRReleaseLabels_full
=== CONT  TestAccEMRReleaseLabels_application
=== CONT  TestAccEMRReleaseLabels_empty
=== CONT  TestAccEMRReleaseLabels_prefix
--- PASS: TestAccEMRReleaseLabels_full (8.44s)
--- PASS: TestAccEMRReleaseLabels_application (8.47s)
--- PASS: TestAccEMRReleaseLabels_empty (8.50s)
--- PASS: TestAccEMRReleaseLabels_prefix (8.50s)
--- PASS: TestAccEMRReleaseLabels_basic (8.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	13.673s
% make testacc TESTARGS='-run=TestAccEMRSupportedInstanceTypesDataSource_' PKG=emr
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/emr/... -v -count 1 -parallel 20  -run=TestAccEMRSupportedInstanceTypesDataSource_ -timeout 360m
=== RUN   TestAccEMRSupportedInstanceTypesDataSource_basic
=== PAUSE TestAccEMRSupportedInstanceTypesDataSource_basic
=== CONT  TestAccEMRSupportedInstanceTypesDataSource_basic
--- PASS: TestAccEMRSupportedInstanceTypesDataSource_basic (11.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	15.975s
% make testacc TESTARGS='-run=TestAccEMRSecurityConfiguration_' PKG=emr
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/emr/... -v -count 1 -parallel 20  -run=TestAccEMRSecurityConfiguration_ -timeout 360m
=== RUN   TestAccEMRSecurityConfiguration_basic
=== PAUSE TestAccEMRSecurityConfiguration_basic
=== RUN   TestAccEMRSecurityConfiguration_disappears
=== PAUSE TestAccEMRSecurityConfiguration_disappears
=== RUN   TestAccEMRSecurityConfiguration_nameGenerated
=== PAUSE TestAccEMRSecurityConfiguration_nameGenerated
=== RUN   TestAccEMRSecurityConfiguration_namePrefix
=== PAUSE TestAccEMRSecurityConfiguration_namePrefix
=== CONT  TestAccEMRSecurityConfiguration_basic
=== CONT  TestAccEMRSecurityConfiguration_nameGenerated
=== CONT  TestAccEMRSecurityConfiguration_namePrefix
=== CONT  TestAccEMRSecurityConfiguration_disappears
--- PASS: TestAccEMRSecurityConfiguration_disappears (17.95s)
--- PASS: TestAccEMRSecurityConfiguration_basic (25.84s)
--- PASS: TestAccEMRSecurityConfiguration_nameGenerated (30.75s)
--- PASS: TestAccEMRSecurityConfiguration_namePrefix (35.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	40.720s
% make testacc TESTARGS='-run=TestAccEMRManagedScalingPolicy_' PKG=emr
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/emr/... -v -count 1 -parallel 20  -run=TestAccEMRManagedScalingPolicy_ -timeout 360m
=== RUN   TestAccEMRManagedScalingPolicy_basic
=== PAUSE TestAccEMRManagedScalingPolicy_basic
=== RUN   TestAccEMRManagedScalingPolicy_disappears
=== PAUSE TestAccEMRManagedScalingPolicy_disappears
=== RUN   TestAccEMRManagedScalingPolicy_ComputeLimits_maximumCoreCapacityUnits
=== PAUSE TestAccEMRManagedScalingPolicy_ComputeLimits_maximumCoreCapacityUnits
=== RUN   TestAccEMRManagedScalingPolicy_ComputeLimits_maximumOnDemandCapacityUnits
=== PAUSE TestAccEMRManagedScalingPolicy_ComputeLimits_maximumOnDemandCapacityUnits
=== RUN   TestAccEMRManagedScalingPolicy_ComputeLimits_maximumOnDemandCapacityUnitsSpotOnly
=== PAUSE TestAccEMRManagedScalingPolicy_ComputeLimits_maximumOnDemandCapacityUnitsSpotOnly
=== CONT  TestAccEMRManagedScalingPolicy_basic
=== CONT  TestAccEMRManagedScalingPolicy_ComputeLimits_maximumOnDemandCapacityUnits
=== CONT  TestAccEMRManagedScalingPolicy_ComputeLimits_maximumOnDemandCapacityUnitsSpotOnly
=== CONT  TestAccEMRManagedScalingPolicy_ComputeLimits_maximumCoreCapacityUnits
=== CONT  TestAccEMRManagedScalingPolicy_disappears
--- PASS: TestAccEMRManagedScalingPolicy_basic (533.51s)
--- PASS: TestAccEMRManagedScalingPolicy_ComputeLimits_maximumOnDemandCapacityUnitsSpotOnly (534.57s)
--- PASS: TestAccEMRManagedScalingPolicy_ComputeLimits_maximumCoreCapacityUnits (565.70s)
--- PASS: TestAccEMRManagedScalingPolicy_ComputeLimits_maximumOnDemandCapacityUnits (578.29s)
--- PASS: TestAccEMRManagedScalingPolicy_disappears (584.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	589.363s
% make testacc TESTARGS='-run=TestAccEMRInstanceFleet_' PKG=emr
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/emr/... -v -count 1 -parallel 20  -run=TestAccEMRInstanceFleet_ -timeout 360m
=== RUN   TestAccEMRInstanceFleet_basic
=== PAUSE TestAccEMRInstanceFleet_basic
=== RUN   TestAccEMRInstanceFleet_Zero_count
=== PAUSE TestAccEMRInstanceFleet_Zero_count
=== RUN   TestAccEMRInstanceFleet_ebsBasic
=== PAUSE TestAccEMRInstanceFleet_ebsBasic
=== RUN   TestAccEMRInstanceFleet_full
=== PAUSE TestAccEMRInstanceFleet_full
=== CONT  TestAccEMRInstanceFleet_basic
=== CONT  TestAccEMRInstanceFleet_ebsBasic
=== CONT  TestAccEMRInstanceFleet_Zero_count
=== CONT  TestAccEMRInstanceFleet_full
--- PASS: TestAccEMRInstanceFleet_full (659.49s)
--- PASS: TestAccEMRInstanceFleet_basic (673.09s)
--- PASS: TestAccEMRInstanceFleet_ebsBasic (679.97s)
--- PASS: TestAccEMRInstanceFleet_Zero_count (767.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	772.624s
% make testacc TESTARGS='-run=TestAccEMRInstanceGroup_' PKG=emr ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/emr/... -v -count 1 -parallel 4  -run=TestAccEMRInstanceGroup_ -timeout 360m
=== RUN   TestAccEMRInstanceGroup_basic
=== PAUSE TestAccEMRInstanceGroup_basic
=== RUN   TestAccEMRInstanceGroup_disappears
=== PAUSE TestAccEMRInstanceGroup_disappears
=== RUN   TestAccEMRInstanceGroup_Disappears_emrCluster
=== PAUSE TestAccEMRInstanceGroup_Disappears_emrCluster
=== RUN   TestAccEMRInstanceGroup_bidPrice
=== PAUSE TestAccEMRInstanceGroup_bidPrice
=== RUN   TestAccEMRInstanceGroup_sJSON
=== PAUSE TestAccEMRInstanceGroup_sJSON
=== RUN   TestAccEMRInstanceGroup_autoScalingPolicy
=== PAUSE TestAccEMRInstanceGroup_autoScalingPolicy
=== RUN   TestAccEMRInstanceGroup_instanceCount
=== PAUSE TestAccEMRInstanceGroup_instanceCount
=== RUN   TestAccEMRInstanceGroup_EBS_ebsOptimized
=== PAUSE TestAccEMRInstanceGroup_EBS_ebsOptimized
=== CONT  TestAccEMRInstanceGroup_basic
=== CONT  TestAccEMRInstanceGroup_sJSON
=== CONT  TestAccEMRInstanceGroup_instanceCount
=== CONT  TestAccEMRInstanceGroup_EBS_ebsOptimized
--- PASS: TestAccEMRInstanceGroup_basic (655.81s)
=== CONT  TestAccEMRInstanceGroup_Disappears_emrCluster
--- PASS: TestAccEMRInstanceGroup_sJSON (663.75s)
=== CONT  TestAccEMRInstanceGroup_bidPrice
--- PASS: TestAccEMRInstanceGroup_instanceCount (830.28s)
=== CONT  TestAccEMRInstanceGroup_autoScalingPolicy
--- PASS: TestAccEMRInstanceGroup_EBS_ebsOptimized (837.10s)
=== CONT  TestAccEMRInstanceGroup_disappears
--- PASS: TestAccEMRInstanceGroup_Disappears_emrCluster (657.94s)
--- PASS: TestAccEMRInstanceGroup_autoScalingPolicy (695.31s)
--- PASS: TestAccEMRInstanceGroup_disappears (580.24s)
--- PASS: TestAccEMRInstanceGroup_bidPrice (884.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/emr	1675.439s1
% make testacc TESTARGS='-run=TestAccEMRCluster_' PKG=emr ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/emr/... -v -count 1 -parallel 3  -run=TestAccEMRCluster_ -timeout 360m
=== RUN   TestAccEMRCluster_basic
=== PAUSE TestAccEMRCluster_basic
=== RUN   TestAccEMRCluster_autoTerminationPolicy
=== PAUSE TestAccEMRCluster_autoTerminationPolicy
=== RUN   TestAccEMRCluster_additionalInfo
=== PAUSE TestAccEMRCluster_additionalInfo
=== RUN   TestAccEMRCluster_disappears
=== PAUSE TestAccEMRCluster_disappears
=== RUN   TestAccEMRCluster_sJSON
=== PAUSE TestAccEMRCluster_sJSON
=== RUN   TestAccEMRCluster_CoreInstanceGroup_autoScalingPolicy
=== PAUSE TestAccEMRCluster_CoreInstanceGroup_autoScalingPolicy
=== RUN   TestAccEMRCluster_CoreInstanceGroup_bidPrice
=== PAUSE TestAccEMRCluster_CoreInstanceGroup_bidPrice
=== RUN   TestAccEMRCluster_CoreInstanceGroup_instanceCount
=== PAUSE TestAccEMRCluster_CoreInstanceGroup_instanceCount
=== RUN   TestAccEMRCluster_CoreInstanceGroup_instanceType
=== PAUSE TestAccEMRCluster_CoreInstanceGroup_instanceType
=== RUN   TestAccEMRCluster_CoreInstanceGroup_name
=== PAUSE TestAccEMRCluster_CoreInstanceGroup_name
=== RUN   TestAccEMRCluster_EC2Attributes_defaultManagedSecurityGroups
=== PAUSE TestAccEMRCluster_EC2Attributes_defaultManagedSecurityGroups
=== RUN   TestAccEMRCluster_Kerberos_clusterDedicatedKdc
=== PAUSE TestAccEMRCluster_Kerberos_clusterDedicatedKdc
=== RUN   TestAccEMRCluster_MasterInstanceGroup_bidPrice
=== PAUSE TestAccEMRCluster_MasterInstanceGroup_bidPrice
=== RUN   TestAccEMRCluster_MasterInstanceGroup_instanceCount
=== PAUSE TestAccEMRCluster_MasterInstanceGroup_instanceCount
=== RUN   TestAccEMRCluster_MasterInstanceGroup_instanceType
=== PAUSE TestAccEMRCluster_MasterInstanceGroup_instanceType
=== RUN   TestAccEMRCluster_MasterInstanceGroup_name
=== PAUSE TestAccEMRCluster_MasterInstanceGroup_name
=== RUN   TestAccEMRCluster_security
=== PAUSE TestAccEMRCluster_security
=== RUN   TestAccEMRCluster_Step_basic
=== PAUSE TestAccEMRCluster_Step_basic
=== RUN   TestAccEMRCluster_Step_mode
=== PAUSE TestAccEMRCluster_Step_mode
=== RUN   TestAccEMRCluster_Step_multiple
=== PAUSE TestAccEMRCluster_Step_multiple
=== RUN   TestAccEMRCluster_Step_multiple_listStates
=== PAUSE TestAccEMRCluster_Step_multiple_listStates
=== RUN   TestAccEMRCluster_Bootstrap_ordering
=== PAUSE TestAccEMRCluster_Bootstrap_ordering
=== RUN   TestAccEMRCluster_PlacementGroupConfigs
=== PAUSE TestAccEMRCluster_PlacementGroupConfigs
=== RUN   TestAccEMRCluster_terminationProtected
=== PAUSE TestAccEMRCluster_terminationProtected
=== RUN   TestAccEMRCluster_keepJob
=== PAUSE TestAccEMRCluster_keepJob
=== RUN   TestAccEMRCluster_visibleToAllUsers
=== PAUSE TestAccEMRCluster_visibleToAllUsers
=== RUN   TestAccEMRCluster_s3Logging
=== PAUSE TestAccEMRCluster_s3Logging
=== RUN   TestAccEMRCluster_s3LogEncryption
=== PAUSE TestAccEMRCluster_s3LogEncryption
=== RUN   TestAccEMRCluster_tags
=== PAUSE TestAccEMRCluster_tags
=== RUN   TestAccEMRCluster_RootVolume_size
=== PAUSE TestAccEMRCluster_RootVolume_size
=== RUN   TestAccEMRCluster_StepConcurrency_level
=== PAUSE TestAccEMRCluster_StepConcurrency_level
=== RUN   TestAccEMRCluster_ebs
=== PAUSE TestAccEMRCluster_ebs
=== RUN   TestAccEMRCluster_CustomAMI_id
=== PAUSE TestAccEMRCluster_CustomAMI_id
=== RUN   TestAccEMRCluster_InstanceFleet_basic
=== PAUSE TestAccEMRCluster_InstanceFleet_basic
=== RUN   TestAccEMRCluster_InstanceFleetMaster_only
=== PAUSE TestAccEMRCluster_InstanceFleetMaster_only
=== RUN   TestAccEMRCluster_unhealthyNodeReplacement
=== PAUSE TestAccEMRCluster_unhealthyNodeReplacement
=== CONT  TestAccEMRCluster_basic
=== CONT  TestAccEMRCluster_visibleToAllUsers
=== CONT  TestAccEMRCluster_MasterInstanceGroup_instanceCount
--- PASS: TestAccEMRCluster_basic (323.29s)
=== CONT  TestAccEMRCluster_ebs
=== NAME  TestAccEMRCluster_visibleToAllUsers
    cluster_test.go:1296: Step 3/4 error: Check failed: Check 2/2 error: aws_emr_cluster.test: Attribute 'visible_to_all_users' expected "false", got "true"
--- FAIL: TestAccEMRCluster_visibleToAllUsers (558.38s)
=== CONT  TestAccEMRCluster_unhealthyNodeReplacement
--- PASS: TestAccEMRCluster_MasterInstanceGroup_instanceCount (1084.27s)
=== CONT  TestAccEMRCluster_InstanceFleetMaster_only
--- PASS: TestAccEMRCluster_unhealthyNodeReplacement (642.08s)
=== CONT  TestAccEMRCluster_InstanceFleet_basic
--- PASS: TestAccEMRCluster_InstanceFleetMaster_only (667.28s)
=== CONT  TestAccEMRCluster_CustomAMI_id
--- PASS: TestAccEMRCluster_InstanceFleet_basic (1361.58s)
=== CONT  TestAccEMRCluster_CoreInstanceGroup_instanceCount
=== NAME  TestAccEMRCluster_ebs
    cluster_test.go:1539: Step 1/2 error: Error running apply: exit status 1
        
        Error: waiting for EMR Cluster (j-HT86LNOCBIXI) create: unexpected state 'TERMINATING', wanted target 'RUNNING, WAITING'. last error: INTERNAL_ERROR: Failed to start the job flow due to an internal error
        
          with aws_emr_cluster.test,
          on terraform_plugin_test.tf line 193, in resource "aws_emr_cluster" "test":
         193: resource "aws_emr_cluster" "test" {
        
=== CONT  TestAccEMRCluster_MasterInstanceGroup_bidPrice
--- FAIL: TestAccEMRCluster_ebs (2914.23s)
--- PASS: TestAccEMRCluster_CoreInstanceGroup_instanceCount (1224.46s)
=== CONT  TestAccEMRCluster_Kerberos_clusterDedicatedKdc
--- PASS: TestAccEMRCluster_MasterInstanceGroup_bidPrice (792.07s)
=== CONT  TestAccEMRCluster_EC2Attributes_defaultManagedSecurityGroups
--- PASS: TestAccEMRCluster_Kerberos_clusterDedicatedKdc (344.50s)
=== CONT  TestAccEMRCluster_CoreInstanceGroup_name
=== NAME  TestAccEMRCluster_CustomAMI_id
    cluster_test.go:1573: Step 1/2 error: Error running apply: exit status 1
        
        Error: waiting for EMR Cluster (j-3Q1XOYSF6F9KA) create: unexpected state 'TERMINATING', wanted target 'RUNNING, WAITING'. last error: INTERNAL_ERROR: Failed to start the job flow due to an internal error
        
          with aws_emr_cluster.test,
          on terraform_plugin_test.tf line 305, in resource "aws_emr_cluster" "test":
         305: resource "aws_emr_cluster" "test" {
        
--- FAIL: TestAccEMRCluster_CustomAMI_id (3007.17s)
=== CONT  TestAccEMRCluster_CoreInstanceGroup_instanceType
--- PASS: TestAccEMRCluster_CoreInstanceGroup_name (742.23s)
=== CONT  TestAccEMRCluster_Step_multiple
--- PASS: TestAccEMRCluster_Step_multiple (365.32s)
=== CONT  TestAccEMRCluster_Bootstrap_ordering
--- PASS: TestAccEMRCluster_CoreInstanceGroup_instanceType (651.03s)
=== CONT  TestAccEMRCluster_Step_multiple_listStates
--- PASS: TestAccEMRCluster_Step_multiple_listStates (406.09s)
=== CONT  TestAccEMRCluster_tags
--- PASS: TestAccEMRCluster_EC2Attributes_defaultManagedSecurityGroups (1823.67s)
=== CONT  TestAccEMRCluster_StepConcurrency_level
--- PASS: TestAccEMRCluster_Bootstrap_ordering (911.73s)
=== CONT  TestAccEMRCluster_PlacementGroupConfigs
--- PASS: TestAccEMRCluster_StepConcurrency_level (451.71s)
=== CONT  TestAccEMRCluster_RootVolume_size
--- PASS: TestAccEMRCluster_tags (640.76s)
=== CONT  TestAccEMRCluster_keepJob
--- PASS: TestAccEMRCluster_PlacementGroupConfigs (563.61s)
=== CONT  TestAccEMRCluster_sJSON
--- PASS: TestAccEMRCluster_keepJob (344.83s)
=== CONT  TestAccEMRCluster_terminationProtected
--- PASS: TestAccEMRCluster_RootVolume_size (607.99s)
=== CONT  TestAccEMRCluster_CoreInstanceGroup_bidPrice
--- PASS: TestAccEMRCluster_sJSON (363.22s)
=== CONT  TestAccEMRCluster_CoreInstanceGroup_autoScalingPolicy
--- PASS: TestAccEMRCluster_terminationProtected (386.57s)
=== CONT  TestAccEMRCluster_additionalInfo
--- PASS: TestAccEMRCluster_additionalInfo (302.42s)
=== CONT  TestAccEMRCluster_security
--- PASS: TestAccEMRCluster_CoreInstanceGroup_autoScalingPolicy (503.83s)
=== CONT  TestAccEMRCluster_disappears
--- PASS: TestAccEMRCluster_security (335.75s)
=== CONT  TestAccEMRCluster_Step_mode
--- PASS: TestAccEMRCluster_disappears (341.74s)
=== CONT  TestAccEMRCluster_Step_basic
--- PASS: TestAccEMRCluster_CoreInstanceGroup_bidPrice (918.89s)
=== CONT  TestAccEMRCluster_MasterInstanceGroup_name
--- PASS: TestAccEMRCluster_Step_basic (417.99s)
=== CONT  TestAccEMRCluster_MasterInstanceGroup_instanceType
--- PASS: TestAccEMRCluster_Step_mode (769.43s)
=== CONT  TestAccEMRCluster_autoTerminationPolicy
--- PASS: TestAccEMRCluster_MasterInstanceGroup_name (731.55s)
=== CONT  TestAccEMRCluster_s3LogEncryption
--- PASS: TestAccEMRCluster_s3LogEncryption (773.75s)
=== CONT  TestAccEMRCluster_s3Logging
--- PASS: TestAccEMRCluster_MasterInstanceGroup_instanceType (650.78s)
--- PASS: TestAccEMRCluster_autoTerminationPolicy (686.33s)
--- PASS: TestAccEMRCluster_s3Logging (548.73s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/emr	9410.857s
FAIL
make: *** [testacc] Error 1

Failures are unrelated to this change and are occurring in CI.

@ewbankkit
Copy link
Contributor

@mattburgess Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 7c55010 into hashicorp:main Aug 26, 2024
39 checks passed
@github-actions github-actions bot added this to the v5.65.0 milestone Aug 26, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 29, 2024
Copy link

This functionality has been released in v5.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/emr Issues and PRs that pertain to the emr service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace use of AWS SDK for Go v1 private/protocol functions [AWS SDK for Go Migration] EMR Service
2 participants