Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_cloudtrail_event_data_store #38273

Merged

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Jul 7, 2024

Description

Relations

Closes #34494

References

Output from Acceptance Testing

% make testacc TESTS=TestAccCloudTrailEventDataStore_ PKG=cloudtrail 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/cloudtrail/... -v -count 1 -parallel 20 -run='TestAccCloudTrailEventDataStore_'  -timeout 360m
=== RUN   TestAccCloudTrailEventDataStore_basic
=== PAUSE TestAccCloudTrailEventDataStore_basic
=== RUN   TestAccCloudTrailEventDataStore_kmsKeyId
=== PAUSE TestAccCloudTrailEventDataStore_kmsKeyId
=== RUN   TestAccCloudTrailEventDataStore_disappears
=== PAUSE TestAccCloudTrailEventDataStore_disappears
=== RUN   TestAccCloudTrailEventDataStore_tags
=== PAUSE TestAccCloudTrailEventDataStore_tags
=== RUN   TestAccCloudTrailEventDataStore_options
=== PAUSE TestAccCloudTrailEventDataStore_options
=== RUN   TestAccCloudTrailEventDataStore_advancedEventSelector
=== PAUSE TestAccCloudTrailEventDataStore_advancedEventSelector
=== CONT  TestAccCloudTrailEventDataStore_basic
=== CONT  TestAccCloudTrailEventDataStore_tags
=== CONT  TestAccCloudTrailEventDataStore_advancedEventSelector
=== CONT  TestAccCloudTrailEventDataStore_options
=== CONT  TestAccCloudTrailEventDataStore_disappears
=== CONT  TestAccCloudTrailEventDataStore_kmsKeyId
=== NAME  TestAccCloudTrailEventDataStore_options
    event_data_store_test.go:169: this AWS account must be an existing member of an AWS Organization
--- SKIP: TestAccCloudTrailEventDataStore_options (1.39s)
--- PASS: TestAccCloudTrailEventDataStore_disappears (99.63s)
--- PASS: TestAccCloudTrailEventDataStore_basic (121.26s)
--- PASS: TestAccCloudTrailEventDataStore_advancedEventSelector (121.35s)
--- PASS: TestAccCloudTrailEventDataStore_kmsKeyId (122.10s)
--- PASS: TestAccCloudTrailEventDataStore_tags (190.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudtrail	237.895s

...

@nikhil-goenka nikhil-goenka requested a review from a team as a code owner July 7, 2024 09:10
Copy link

github-actions bot commented Jul 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. labels Jul 7, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 7, 2024
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jul 7, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jul 8, 2024
@ewbankkit ewbankkit self-assigned this Jul 8, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 8, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCloudTrailEventDataStore_' PKG=cloudtrail ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.4 test ./internal/service/cloudtrail/... -v -count 1 -parallel 3  -run=TestAccCloudTrailEventDataStore_ -timeout 360m
=== RUN   TestAccCloudTrailEventDataStore_basic
=== PAUSE TestAccCloudTrailEventDataStore_basic
=== RUN   TestAccCloudTrailEventDataStore_billingMode
=== PAUSE TestAccCloudTrailEventDataStore_billingMode
=== RUN   TestAccCloudTrailEventDataStore_kmsKeyId
=== PAUSE TestAccCloudTrailEventDataStore_kmsKeyId
=== RUN   TestAccCloudTrailEventDataStore_disappears
=== PAUSE TestAccCloudTrailEventDataStore_disappears
=== RUN   TestAccCloudTrailEventDataStore_tags
=== PAUSE TestAccCloudTrailEventDataStore_tags
=== RUN   TestAccCloudTrailEventDataStore_options
=== PAUSE TestAccCloudTrailEventDataStore_options
=== RUN   TestAccCloudTrailEventDataStore_advancedEventSelector
=== PAUSE TestAccCloudTrailEventDataStore_advancedEventSelector
=== CONT  TestAccCloudTrailEventDataStore_basic
=== CONT  TestAccCloudTrailEventDataStore_tags
=== CONT  TestAccCloudTrailEventDataStore_kmsKeyId
--- PASS: TestAccCloudTrailEventDataStore_basic (15.36s)
=== CONT  TestAccCloudTrailEventDataStore_advancedEventSelector
--- PASS: TestAccCloudTrailEventDataStore_kmsKeyId (21.18s)
=== CONT  TestAccCloudTrailEventDataStore_options
--- PASS: TestAccCloudTrailEventDataStore_options (24.45s)
=== CONT  TestAccCloudTrailEventDataStore_billingMode
--- PASS: TestAccCloudTrailEventDataStore_billingMode (24.04s)
=== CONT  TestAccCloudTrailEventDataStore_disappears
--- PASS: TestAccCloudTrailEventDataStore_advancedEventSelector (14.74s)
--- PASS: TestAccCloudTrailEventDataStore_tags (33.99s)
--- PASS: TestAccCloudTrailEventDataStore_disappears (12.30s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudtrail	46.374s

@ewbankkit
Copy link
Contributor

@nikhil-goenka Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 2271250 into hashicorp:main Jul 8, 2024
44 checks passed
@github-actions github-actions bot added this to the v5.58.0 milestone Jul 8, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 12, 2024
Copy link

This functionality has been released in v5.58.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@nikhil-goenka nikhil-goenka deleted the f/aws_cloudtrail_event_data_store branch July 16, 2024 16:58
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: CloudTrail Lake Billing Mode
2 participants