Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fsx: Migrate to AWS SDK v2 #38343

Merged
merged 25 commits into from
Jul 19, 2024
Merged

fsx: Migrate to AWS SDK v2 #38343

merged 25 commits into from
Jul 19, 2024

Conversation

mattburgess
Copy link
Collaborator

@mattburgess mattburgess commented Jul 11, 2024 •
edited by ewbankkit
Loading

Description

Relations

Closes #36163.
Closes #38229.
Relates #32976.

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/fsx Issues and PRs that pertain to the fsx service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. labels Jul 11, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@ewbankkit ewbankkit added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label Jul 13, 2024
@mattburgess mattburgess force-pushed the fsx-awssdkv2-migration branch 3 times, most recently from e191e20 to feb0cd1 Compare July 15, 2024 20:31
@mattburgess
fsx: Migrate to AWS SDK v2
e534af8
@mattburgess
gopatch
0d446bb
@mattburgess
make gen
a6ee3a6
@mattburgess
r/fsx_backup: Migrate to AWS SDK v2
155a42a
@mattburgess
r/fsx_data_repository_association: Migrate to AWS SDK v2
7627263
@mattburgess
r/fsx_file_cache: Migrate to AWS SDK v2
565d79a
@mattburgess
r/fsx_lustre_file_system: Migrate to AWS SDK v2
aa7f310
@mattburgess
d/fsx_ontap_file_system,r/fsx_ontap_file_system: Migrate to AWS SDK v2
593c5be
@mattburgess
d/fsx_ontap_storage_virtual_machine,d/fsx_ontap_storage_virtual_machi…
705f2dd 
…nes,r/fsx_ontap_storage_virtual_machine: Migrate to AWS SDK v2
@mattburgess
r/fsx_ontap_volume: Migrate to AWS SDK v2
d37ccf9
@mattburgess
r/fsx_openzfs_file_system: Migrate to AWS SDK v2
0157744
@mattburgess
d/fsx_openzfs_snapshot: Migrate to AWS SDK v2
e236641
@mattburgess
d/fsx_openzfs_snapshot,r/fsx_openzfs_snapshot: Migrate to AWS SDK v2
e20ea27
@mattburgess
r/fsx_openzfs_volume: Migrate to AWS SDK v2
c81701d
@mattburgess
r/fsx_windows_file_system: Migrate to AWS SDK v2
8d4fcf6
@mattburgess
fsx: Migrate sweepers to AWS SDK v2
335a845
@mattburgess
d/fsx_common_schema: Migrate to AWS SDK v2
8cb11b2
@mattburgess mattburgess marked this pull request as ready for review July 15, 2024 21:15
@mattburgess mattburgess requested a review from a team as a code owner July 15, 2024 21:15
@ewbankkit ewbankkit self-assigned this Jul 19, 2024
@ewbankkit
Merge branch 'main' into HEAD
c09be6e 
# Conflicts:
#	internal/conns/awsclient_gen.go
#	internal/service/fsx/lustre_file_system.go
#	internal/service/fsx/ontap_volume.go
#	internal/service/fsx/ontap_volume_test.go
#	internal/service/fsx/openzfs_file_system.go
#	internal/service/fsx/openzfs_file_system_test.go
@ewbankkit
fsx: Cosmetics.
d01db03
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@ewbankkit
r/aws_fsx_openzfs_volume: Correctly set tags on Read.
2b6d716
@ewbankkit
Acceptance test output:
2a07e1c 
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccFSxOpenZFSVolume_tags\|TestAccFSxOpenZFSVolume_copyTags' PKG=fsx
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/fsx/... -v -count 1 -parallel 20  -run=TestAccFSxOpenZFSVolume_tags\|TestAccFSxOpenZFSVolume_copyTags -timeout 720m
=== RUN   TestAccFSxOpenZFSVolume_tags
=== PAUSE TestAccFSxOpenZFSVolume_tags
=== RUN   TestAccFSxOpenZFSVolume_copyTags
=== PAUSE TestAccFSxOpenZFSVolume_copyTags
=== CONT  TestAccFSxOpenZFSVolume_tags
=== CONT  TestAccFSxOpenZFSVolume_copyTags
--- PASS: TestAccFSxOpenZFSVolume_tags (626.55s)
--- PASS: TestAccFSxOpenZFSVolume_copyTags (793.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	798.685s
@ewbankkit
d/aws_fsx_openzfs_snapshot: Correctly set tags on Read.
a5ff10a
@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@github-actions GitHub Actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

ewbankkit
ewbankkit approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Full set of acceptance tests will run in TeamCity this weekend.

@ewbankkit ewbankkit merged commit cc6a0f5 into hashicorp:main Jul 19, 2024
41 checks passed
@github-actions github-actions bot added this to the v5.60.0 milestone Jul 19, 2024
This was referenced Jul 22, 2024
Closed
Merged
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@justinretzolk justinretzolk added the external-maintainer Contribution from a trusted external contributor. label Jul 29, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. client-connections Pertains to the AWS Client and service connections. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/fsx Issues and PRs that pertain to the fsx service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.60.0
3 participants
@mattburgess @ewbankkit @justinretzolk