Migrate remaining EC2 service resources to AWS SDK V2
#38363
Merged
Commits on Jul 12, 2024
Commits on Jul 13, 2024
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
feat: reduce visibility and migrate last CRUD r/vpc_network_interface…
…_attachment to SDKv2
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Commits on Jul 14, 2024
-
fix: added delay for status check for `TestAccEC2AMILaunchPermission_…
…group` for eventual consistency issues.
Commits on Jul 15, 2024
-
fix: emr cluster tests changed
EMR_DefaultRoleand `EMR_EC2_Default……Role` to custom roles
-
-
fix:
resourceIPAMResourceDiscoveryUpdatehandler by adding `resourc……eIPAMResourceDiscoveryRead` for tags
-
Commits on Jul 16, 2024
Commits on Jul 17, 2024
-
-
-
-
fix:
forceRevokeRulesTrueandforceRevokeRulesFalseto ignore cer……tain import arguments and added len checks on removal of dependancy cycle.
-
-
fix:
TestAccVPCManagedPrefixListEntry_disappearsby adding addition……al check in delete handler
-
fix:
TestAccVPCNetworkInterface_ignoreExternalAttachmentby adding ……an removal of external attachment step
-
fix:
TestAccVPCSecurityGroupRule_expectInvalidTypeErrorby changing…… expected error message
-
-
Commits on Jul 18, 2024
-
-
fix: accept pascal case on
actionattribute for r/vpc_network_acl f……or compatibility reasons
-
-
-
-
-
-
-
-
-
-
-
Commits on Jul 19, 2024
-
-
% make testacc TESTARGS='-run=TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment/basic' PKG=ec2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.5 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment/basic -timeout 360m === RUN TestAccVerifiedAccess_serial === PAUSE TestAccVerifiedAccess_serial === CONT TestAccVerifiedAccess_serial === RUN TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic === PAUSE TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic === RUN TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears === PAUSE TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears === CONT TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic === CONT TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears --- PASS: TestAccVerifiedAccess_serial (0.00s) --- PASS: TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_disappears (13.11s) --- PASS: TestAccVerifiedAccess_serial/InstanceTrustProviderAttachment_basic (14.63s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 19.674s -
-
% make testacc TESTARGS='-run=TestAccSiteVPNConnectionRoute_basic' PKG=ec2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.5 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccSiteVPNConnectionRoute_basic -timeout 360m === RUN TestAccSiteVPNConnectionRoute_basic === PAUSE TestAccSiteVPNConnectionRoute_basic === CONT TestAccSiteVPNConnectionRoute_basic --- PASS: TestAccSiteVPNConnectionRoute_basic (230.52s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 235.673s
-
-
% make testacc TESTARGS='-run=TestAccVPCEndpointConnectionAccepter_crossAccount' PKG=ec2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.5 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccVPCEndpointConnectionAccepter_crossAccount -timeout 360m === RUN TestAccVPCEndpointConnectionAccepter_crossAccount --- PASS: TestAccVPCEndpointConnectionAccepter_crossAccount (319.72s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 324.703s
-
-
% make testacc TESTARGS='-run=TestAccTransitGateway_serial/Route_basic' PKG=ec2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.5 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccTransitGateway_serial/Route_basic -timeout 360m === RUN TestAccTransitGateway_serial === PAUSE TestAccTransitGateway_serial === CONT TestAccTransitGateway_serial === RUN TestAccTransitGateway_serial/Route_basic === PAUSE TestAccTransitGateway_serial/Route_basic === RUN TestAccTransitGateway_serial/Route_basicIpv6 === PAUSE TestAccTransitGateway_serial/Route_basicIpv6 === CONT TestAccTransitGateway_serial/Route_basic === CONT TestAccTransitGateway_serial/Route_basicIpv6 --- PASS: TestAccTransitGateway_serial (0.00s) --- PASS: TestAccTransitGateway_serial/Route_basic (330.55s) --- PASS: TestAccTransitGateway_serial/Route_basicIpv6 (358.67s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 363.661s -
-
% make testacc TESTARGS='-run=TestAccVPCNetworkPerformanceMetricSubscription_serial/basic' PKG=ec2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.5 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccVPCNetworkPerformanceMetricSubscription_serial/basic -timeout 360m === RUN TestAccVPCNetworkPerformanceMetricSubscription_serial === PAUSE TestAccVPCNetworkPerformanceMetricSubscription_serial === CONT TestAccVPCNetworkPerformanceMetricSubscription_serial === RUN TestAccVPCNetworkPerformanceMetricSubscription_serial/basic --- PASS: TestAccVPCNetworkPerformanceMetricSubscription_serial (9.27s) --- PASS: TestAccVPCNetworkPerformanceMetricSubscription_serial/basic (9.27s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 14.332s -
-
% make testacc TESTARGS='-run=TestAccIPAMPoolCIDR_' PKG=ec2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.5 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccIPAMPoolCIDR_ -timeout 360m === RUN TestAccIPAMPoolCIDR_basic === PAUSE TestAccIPAMPoolCIDR_basic === RUN TestAccIPAMPoolCIDR_basicNetmaskLength === PAUSE TestAccIPAMPoolCIDR_basicNetmaskLength === RUN TestAccIPAMPoolCIDR_disappears === PAUSE TestAccIPAMPoolCIDR_disappears === RUN TestAccIPAMPoolCIDR_Disappears_ipam === PAUSE TestAccIPAMPoolCIDR_Disappears_ipam === CONT TestAccIPAMPoolCIDR_basic === CONT TestAccIPAMPoolCIDR_disappears === CONT TestAccIPAMPoolCIDR_Disappears_ipam === CONT TestAccIPAMPoolCIDR_basicNetmaskLength --- PASS: TestAccIPAMPoolCIDR_disappears (67.87s) --- PASS: TestAccIPAMPoolCIDR_basic (77.25s) --- PASS: TestAccIPAMPoolCIDR_basicNetmaskLength (101.21s) --- PASS: TestAccIPAMPoolCIDR_Disappears_ipam (110.80s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 115.931s
-
-
% make testacc TESTARGS='-run=TestAccIPAMPoolCIDRAllocation_ipv4Basic' PKG=ec2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.5 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccIPAMPoolCIDRAllocation_ipv4Basic -timeout 360m === RUN TestAccIPAMPoolCIDRAllocation_ipv4Basic === PAUSE TestAccIPAMPoolCIDRAllocation_ipv4Basic === RUN TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask === PAUSE TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask === CONT TestAccIPAMPoolCIDRAllocation_ipv4Basic === CONT TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask --- PASS: TestAccIPAMPoolCIDRAllocation_ipv4BasicNetmask (63.28s) --- PASS: TestAccIPAMPoolCIDRAllocation_ipv4Basic (63.66s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 68.698s
-
-
% make testacc TESTARGS='-run=TestAccEC2EBSSnapshotCreateVolumePermission_basic' PKG=ec2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.5 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2EBSSnapshotCreateVolumePermission_basic -timeout 360m === RUN TestAccEC2EBSSnapshotCreateVolumePermission_basic === PAUSE TestAccEC2EBSSnapshotCreateVolumePermission_basic === CONT TestAccEC2EBSSnapshotCreateVolumePermission_basic --- PASS: TestAccEC2EBSSnapshotCreateVolumePermission_basic (52.17s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 57.159s
-
-
% make testacc TESTARGS='-run=TestAccClientVPNEndpoint_serial/Route_basic' PKG=ec2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.5 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccClientVPNEndpoint_serial/Route_basic -timeout 360m === RUN TestAccClientVPNEndpoint_serial === PAUSE TestAccClientVPNEndpoint_serial === CONT TestAccClientVPNEndpoint_serial === RUN TestAccClientVPNEndpoint_serial/Route_basic === PAUSE TestAccClientVPNEndpoint_serial/Route_basic === CONT TestAccClientVPNEndpoint_serial/Route_basic --- PASS: TestAccClientVPNEndpoint_serial (0.06s) --- PASS: TestAccClientVPNEndpoint_serial/Route_basic (959.23s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 964.272s -
-
% make testacc TESTARGS='-run=TestAccClientVPNEndpoint_serial/AuthorizationRule_basic' PKG=ec2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.5 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccClientVPNEndpoint_serial/AuthorizationRule_basic -timeout 360m === RUN TestAccClientVPNEndpoint_serial === PAUSE TestAccClientVPNEndpoint_serial === CONT TestAccClientVPNEndpoint_serial === RUN TestAccClientVPNEndpoint_serial/AuthorizationRule_basic === PAUSE TestAccClientVPNEndpoint_serial/AuthorizationRule_basic === CONT TestAccClientVPNEndpoint_serial/AuthorizationRule_basic --- PASS: TestAccClientVPNEndpoint_serial (0.12s) --- PASS: TestAccClientVPNEndpoint_serial/AuthorizationRule_basic (51.44s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 56.491s -
-
% make testacc TESTARGS='-run=TestAccEC2AMILaunchPermission_basic' PKG=ec2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.5 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2AMILaunchPermission_basic -timeout 360m === RUN TestAccEC2AMILaunchPermission_basic === PAUSE TestAccEC2AMILaunchPermission_basic === CONT TestAccEC2AMILaunchPermission_basic --- PASS: TestAccEC2AMILaunchPermission_basic (115.25s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 120.318s
-
-
% make testacc TESTARGS='-run=TestAccEC2CapacityBlockOfferingDataSource_' PKG=ec2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.5 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2CapacityBlockOfferingDataSource_ -timeout 360m === RUN TestAccEC2CapacityBlockOfferingDataSource_basic === PAUSE TestAccEC2CapacityBlockOfferingDataSource_basic === CONT TestAccEC2CapacityBlockOfferingDataSource_basic --- PASS: TestAccEC2CapacityBlockOfferingDataSource_basic (7.90s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 12.959s
-
-
% make testacc TESTARGS='-run=TestAccEC2InstanceState_' PKG=ec2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.5 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2InstanceState_ -timeout 360m === RUN TestAccEC2InstanceState_basic === PAUSE TestAccEC2InstanceState_basic === RUN TestAccEC2InstanceState_state === PAUSE TestAccEC2InstanceState_state === RUN TestAccEC2InstanceState_disappears_Instance === PAUSE TestAccEC2InstanceState_disappears_Instance === CONT TestAccEC2InstanceState_basic === CONT TestAccEC2InstanceState_disappears_Instance === CONT TestAccEC2InstanceState_state --- PASS: TestAccEC2InstanceState_basic (348.07s) --- PASS: TestAccEC2InstanceState_disappears_Instance (364.72s) --- PASS: TestAccEC2InstanceState_state (683.51s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 688.657s
-
-
% make testacc TESTARGS='-run=TestAccEC2CapacityBlockReservation_' PKG=ec2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.5 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2CapacityBlockReservation_ -timeout 360m === RUN TestAccEC2CapacityBlockReservation_basic ec2_capacity_block_reservation_test.go:28: Environment variable RUN_EC2_CAPACITY_BLOCK_RESERVATION_TESTS is not set to true --- SKIP: TestAccEC2CapacityBlockReservation_basic (0.00s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 5.075s -
-
% make testacc TESTARGS='-run=TestAccVPCEndpointPrivateDNS_' PKG=ec2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.5 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccVPCEndpointPrivateDNS_ -timeout 360m === RUN TestAccVPCEndpointPrivateDNS_basic === PAUSE TestAccVPCEndpointPrivateDNS_basic === RUN TestAccVPCEndpointPrivateDNS_disabled === PAUSE TestAccVPCEndpointPrivateDNS_disabled === RUN TestAccVPCEndpointPrivateDNS_disappears_Endpoint === PAUSE TestAccVPCEndpointPrivateDNS_disappears_Endpoint === RUN TestAccVPCEndpointPrivateDNS_update === PAUSE TestAccVPCEndpointPrivateDNS_update === CONT TestAccVPCEndpointPrivateDNS_basic === CONT TestAccVPCEndpointPrivateDNS_disappears_Endpoint === CONT TestAccVPCEndpointPrivateDNS_update === CONT TestAccVPCEndpointPrivateDNS_disabled --- PASS: TestAccVPCEndpointPrivateDNS_disabled (43.32s) --- PASS: TestAccVPCEndpointPrivateDNS_disappears_Endpoint (117.40s) --- PASS: TestAccVPCEndpointPrivateDNS_basic (119.36s) --- PASS: TestAccVPCEndpointPrivateDNS_update (167.46s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 172.554s
-
% make testacc TESTARGS='-run=TestAccVPCEndpointServicePrivateDNSVerification_' PKG=ec2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.5 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccVPCEndpointServicePrivateDNSVerification_ -timeout 360m === RUN TestAccVPCEndpointServicePrivateDNSVerification_basic === PAUSE TestAccVPCEndpointServicePrivateDNSVerification_basic === RUN TestAccVPCEndpointServicePrivateDNSVerification_waitForVerification === PAUSE TestAccVPCEndpointServicePrivateDNSVerification_waitForVerification === CONT TestAccVPCEndpointServicePrivateDNSVerification_basic === CONT TestAccVPCEndpointServicePrivateDNSVerification_waitForVerification --- PASS: TestAccVPCEndpointServicePrivateDNSVerification_basic (228.97s) --- PASS: TestAccVPCEndpointServicePrivateDNSVerification_waitForVerification (262.15s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 267.206s
-
r/aws_vpc_ipv4_cidr_block_association: 'aws-sdk-go-base/v2/awsv1shim/…
…v2/tfawserr' -> 'aws-sdk-go-base/v2/tfawserr'.
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.