Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: [aws_rds_cluster] Change the sample string for the Master Password #38394

Merged

Conversation

kuredev
Copy link
Contributor

@kuredev kuredev commented Jul 17, 2024

Description

This Pull Request is to edit the following document:
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/rds_cluster.html

In the current document example, the master password is set to "bar".

スクリーンショット 2024-07-18 15 08 31

However, according to AWS specifications, the master password must be at least 8 characters long, which causes an error during terraform apply.

Must contain from 8 to 41 characters.
https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_CreateDBCluster.html

Error during terraform apply

aws_rds_cluster.postgresql: Creating...
╷
│ Error: creating RDS Cluster (aurora-cluster-demo): InvalidParameterValue: The parameter MasterUserPassword is not a valid password because it is shorter than 8 characters.

Output from Acceptance Testing

There are no changes to the source code.

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR. labels Jul 17, 2024
@kuredev kuredev marked this pull request as ready for review July 18, 2024 06:15
@kuredev kuredev requested a review from a team as a code owner July 18, 2024 06:15
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@kuredev Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b108acd into hashicorp:main Jul 18, 2024
88 checks passed
@github-actions github-actions bot added this to the v5.59.0 milestone Jul 18, 2024
@kuredev kuredev deleted the d-fix_master_password_aurora-cluster branch July 19, 2024 15:18
Copy link

This functionality has been released in v5.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants